]> git.openstreetmap.org Git - rails.git/blobdiff - .rubocop_todo.yml
Merge remote-tracking branch 'upstream/pull/2999'
[rails.git] / .rubocop_todo.yml
index c4eb88ac45041752665077e5733e6c010f3e3613..c1060cbe2338b3c6c95a2344417a527e0c67c465 100644 (file)
@@ -1,55 +1,72 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-02-25 00:27:05 +0000 using RuboCop version 0.29.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-09-02 06:16:56 UTC using RuboCop version 0.90.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 13
-Lint/AmbiguousOperator:
-  Enabled: false
+# Work around erblint issues.
+# https://github.com/openstreetmap/openstreetmap-website/issues/2472
+require:
+  - rubocop-minitest
+  - rubocop-performance
+  - rubocop-rails
 
-# Offense count: 107
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
+# Offense count: 568
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 250
 
-# Offense count: 29
+# Offense count: 36
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
-  Enabled: false
-
-# Offense count: 5
-Lint/HandleExceptions:
-  Enabled: false
-
-# Offense count: 8
-Lint/ParenthesesAsGroupedExpression:
-  Enabled: false
-
-# Offense count: 542
+  Exclude:
+    - 'app/controllers/api/traces_controller.rb'
+    - 'app/controllers/api/user_preferences_controller.rb'
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/geocoder_controller.rb'
+    - 'app/controllers/notes_controller.rb'
+    - 'app/controllers/traces_controller.rb'
+    - 'app/controllers/users_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/browse_tags_helper.rb'
+    - 'app/mailers/user_mailer.rb'
+    - 'app/models/client_application.rb'
+    - 'lib/nominatim.rb'
+    - 'lib/osm.rb'
+    - 'script/deliver-message'
+
+# Offense count: 682
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 194
 
-# Offense count: 12
+# Offense count: 72
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 71
+
+# Offense count: 15
+# Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 60
-# Configuration parameters: CountComments.
+# Offense count: 25
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 1515
+  Max: 643
 
 # Offense count: 68
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 21
-
-# Offense count: 2092
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 520
+  Max: 26
 
-# Offense count: 520
-# Configuration parameters: CountComments.
+# Offense count: 735
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
   Max: 179
 
@@ -58,86 +75,100 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 9
 
-# Offense count: 70
+# Offense count: 69
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 24
+  Max: 26
 
-# Offense count: 164
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, Include.
-Rails/ActionFilter:
-  Enabled: false
+# Offense count: 540
+Minitest/MultipleAssertions:
+  Max: 81
+
+# Offense count: 6
+Naming/AccessorMethodName:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/helpers/title_helper.rb'
+    - 'app/models/old_way.rb'
+    - 'lib/osm.rb'
+    - 'lib/potlatch.rb'
+
+# Offense count: 8
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'app/models/changeset.rb'
+    - 'app/models/old_node.rb'
+    - 'app/models/old_relation.rb'
+    - 'app/models/old_way.rb'
+    - 'app/models/user.rb'
+    - 'lib/classic_pagination/pagination.rb'
+
+# Offense count: 5
+# Configuration parameters: Database, Include.
+# SupportedDatabases: mysql, postgresql
+# Include: db/migrate/*.rb
+Rails/BulkChangeTable:
+  Exclude:
+    - 'db/migrate/20111116184519_update_oauth.rb'
+    - 'db/migrate/20120208194454_add_domain_to_acl.rb'
+    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
 # Offense count: 2
 # Configuration parameters: Include.
+# Include: app/models/**/*.rb
 Rails/HasAndBelongsToMany:
-  Enabled: false
+  Exclude:
+    - 'app/models/changeset.rb'
+    - 'app/models/user.rb'
 
-# Offense count: 17
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-Rails/ReadWriteAttribute:
-  Enabled: false
-
-# Offense count: 123
+# Offense count: 4
 # Configuration parameters: Include.
-Rails/Validation:
-  Enabled: false
+# Include: app/helpers/**/*.rb
+Rails/HelperInstanceVariable:
+  Exclude:
+    - 'app/helpers/title_helper.rb'
 
 # Offense count: 5
-Style/AccessorMethodName:
-  Enabled: false
-
-# Offense count: 1
-Style/AsciiComments:
-  Enabled: false
-
-# Offense count: 305
-Style/Documentation:
-  Enabled: false
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/NotNullColumn:
+  Exclude:
+    - 'db/migrate/002_cleanup_osm_db.rb'
+    - 'db/migrate/020_populate_node_tags_and_remove.rb'
+    - 'db/migrate/021_move_to_innodb.rb'
+    - 'db/migrate/025_add_end_time_to_changesets.rb'
+    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+
+# Offense count: 19
+Rails/OutputSafety:
+  Exclude:
+    - 'app/controllers/users_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'lib/rich_text.rb'
+    - 'test/helpers/application_helper_test.rb'
 
-# Offense count: 39
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
+# Offense count: 95
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
   Enabled: false
 
-# Offense count: 60
+# Offense count: 572
 # Cop supports --auto-correct.
-Style/LineEndConcatenation:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
   Enabled: false
 
-# Offense count: 53
+# Offense count: 78
 # Cop supports --auto-correct.
+# Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 11
-
-# Offense count: 44
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Enabled: false
-
-# Offense count: 8
-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
-Style/PredicateName:
-  Enabled: false
-
-# Offense count: 95
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/RaiseArgs:
-  Enabled: false
-
-# Offense count: 2
-Style/RescueModifier:
-  Enabled: false
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false