Merge remote-tracking branch 'upstream/pull/3194'

[rails.git] / test / controllers / notes_controller_test.rb

diff --git a/test/controllers/notes_controller_test.rb b/test/controllers/notes_controller_test.rb
index 82821de6c0725db74b7e0864706e79e2fd96ec78..50e7ae833615905561666b31b8dbbef3d4bf3301 100644 (file)
--- a/test/controllers/notes_controller_test.rb
+++ b/test/controllers/notes_controller_test.rb
@@ -1,7 +1,8 @@
 require "test_helper"
 
 require "test_helper"
 

-class NotesControllerTest < ActionController::TestCase
+class NotesControllerTest < ActionDispatch::IntegrationTest

   def setup
   def setup

+    super

     # Stub nominatim response for note locations
     stub_request(:get, %r{^https://nominatim\.openstreetmap\.org/reverse\?})
       .to_return(:status => 404)
     # Stub nominatim response for note locations
     stub_request(:get, %r{^https://nominatim\.openstreetmap\.org/reverse\?})
       .to_return(:status => 404)


@@ -12,11 +13,11 @@ class NotesControllerTest < ActionController::TestCase
   def test_routes
     assert_routing(
       { :path => "/user/username/notes", :method => :get },
   def test_routes
     assert_routing(
       { :path => "/user/username/notes", :method => :get },

-      { :controller => "notes", :action => "mine", :display_name => "username" }
+      { :controller => "notes", :action => "index", :display_name => "username" }

     )
   end
 
     )
   end
 

-  def test_mine_success
+  def test_index_success

     first_user = create(:user)
     second_user = create(:user)
     moderator_user = create(:moderator_user)
     first_user = create(:user)
     second_user = create(:user)
     moderator_user = create(:moderator_user)


@@ -32,44 +33,51 @@ class NotesControllerTest < ActionController::TestCase
     end
 
     # Note that the table rows include a header row
     end
 
     # Note that the table rows include a header row

-    get :mine, :params => { :display_name => first_user.display_name }
+    get user_notes_path(:display_name => first_user.display_name)

     assert_response :success
     assert_select "table.note_list tr", :count => 2
 
     assert_response :success
     assert_select "table.note_list tr", :count => 2
 

-    get :mine, :params => { :display_name => second_user.display_name }
+    get user_notes_path(:display_name => second_user.display_name)

     assert_response :success
     assert_select "table.note_list tr", :count => 2
 
     assert_response :success
     assert_select "table.note_list tr", :count => 2
 

-    get :mine, :params => { :display_name => "non-existent" }
+    get user_notes_path(:display_name => "non-existent")

     assert_response :not_found
 
     assert_response :not_found
 

-    session[:user] = moderator_user.id
+    session_for(moderator_user)

 
 

-    get :mine, :params => { :display_name => first_user.display_name }
+    get user_notes_path(:display_name => first_user.display_name)

     assert_response :success
     assert_select "table.note_list tr", :count => 2
 
     assert_response :success
     assert_select "table.note_list tr", :count => 2
 

-    get :mine, :params => { :display_name => second_user.display_name }
+    get user_notes_path(:display_name => second_user.display_name)

     assert_response :success
     assert_select "table.note_list tr", :count => 3
 
     assert_response :success
     assert_select "table.note_list tr", :count => 3
 

-    get :mine, :params => { :display_name => "non-existent" }
+    get user_notes_path(:display_name => "non-existent")

     assert_response :not_found
   end
 
     assert_response :not_found
   end
 

-  def test_mine_paged
+  def test_index_paged

     user = create(:user)
 
     create_list(:note, 50) do |note|
       create(:note_comment, :note => note, :author => user)
     end
 
     user = create(:user)
 
     create_list(:note, 50) do |note|
       create(:note_comment, :note => note, :author => user)
     end
 

-    get :mine, :params => { :display_name => user.display_name }
+    get user_notes_path(:display_name => user.display_name)

     assert_response :success
     assert_select "table.note_list tr", :count => 11
 
     assert_response :success
     assert_select "table.note_list tr", :count => 11
 

-    get :mine, :params => { :display_name => user.display_name, :page => 2 }
+    get user_notes_path(:display_name => user.display_name, :page => 2)

     assert_response :success
     assert_select "table.note_list tr", :count => 11
   end
     assert_response :success
     assert_select "table.note_list tr", :count => 11
   end

+
+  def test_empty_page
+    user = create(:user)
+    get user_notes_path(:display_name => user.display_name)
+    assert_response :success
+    assert_select "h4", :html => "No notes"
+  end

 end
 end