Fix new rubocop warnings

[rails.git] / app / helpers / user_blocks_helper.rb

diff --git a/app/helpers/user_blocks_helper.rb b/app/helpers/user_blocks_helper.rb
index 3cd9373c10542af8ccf85184d2bad181207e6aca..e2770eb69ea5bf655866b04499708eadd70a575e 100644 (file)
--- a/app/helpers/user_blocks_helper.rb
+++ b/app/helpers/user_blocks_helper.rb
@@ -1,20 +1,44 @@
 module UserBlocksHelper
 module UserBlocksHelper

+  include ActionView::Helpers::TranslationHelper
+

   ##
   ##

-  # returns a translated string representing the status of the 
+  # returns a translated string representing the status of the

   # user block (i.e: whether it's active, what the expiry time is)
   def block_status(block)
     if block.active?
   # user block (i.e: whether it's active, what the expiry time is)
   def block_status(block)
     if block.active?

+      # if the block hasn't expired yet show the date, if the user just needs to login show that

       if block.needs_view?
       if block.needs_view?

-        I18n.t('user_block.helper.until_login')
+        if block.ends_at > Time.now.utc
+          t("user_blocks.helper.time_future_and_until_login_html", :time => friendly_date(block.ends_at))
+        else
+          t("user_blocks.helper.until_login")
+        end

       else
       else

-        I18n.t('user_block.helper.time_future', :time => distance_of_time_in_words_to_now(block.ends_at))
+        t("user_blocks.helper.time_future_html", :time => friendly_date(block.ends_at))

       end
     else
       # the max of the last update time or the ends_at time is when this block finished
       end
     else
       # the max of the last update time or the ends_at time is when this block finished

-      # either because the user viewed the block (updated_at) or it expired or was 
+      # either because the user viewed the block (updated_at) or it expired or was

       # revoked (ends_at)
       # revoked (ends_at)

-      last_time = [block.ends_at, block.updated_at].max
-      I18n.t('user_block.helper.time_past', :time => distance_of_time_in_words_to_now(last_time))
+      last_time = block.deactivates_at || [block.ends_at, block.updated_at].max
+      t("user_blocks.helper.time_past_html", :time => friendly_date_ago(last_time))
+    end
+  end
+
+  def block_duration_in_words(duration)
+    # Ensure the requested duration isn't negative, even by a millisecond
+    duration = 0 if duration.negative?
+    parts = ActiveSupport::Duration.build(duration).parts
+    if duration < 1.day
+      t("user_blocks.helper.block_duration.hours", :count => parts.fetch(:hours, 0))
+    elsif duration < 1.week
+      t("user_blocks.helper.block_duration.days", :count => parts[:days])
+    elsif duration < 1.month
+      t("user_blocks.helper.block_duration.weeks", :count => parts[:weeks])
+    elsif duration < 1.year
+      t("user_blocks.helper.block_duration.months", :count => parts[:months])
+    else
+      t("user_blocks.helper.block_duration.years", :count => parts[:years])

     end
   end
 end
     end
   end
 end