Reduce condition complexity

[rails.git] / app / assets / javascripts / social_share_button.js

diff --git a/app/assets/javascripts/social_share_button.js b/app/assets/javascripts/social_share_button.js
index 409b2c58a7a3e2ef469a52749b22b229938232b0..b118c1d3b7f1e9ad302ce97a893fa4a172b581a0 100644 (file)
--- a/app/assets/javascripts/social_share_button.js
+++ b/app/assets/javascripts/social_share_button.js
@@ -1,15 +1,15 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
-  const width = Math.max(100, Math.min(screen.width, initialWidth));
-  const height = Math.max(100, Math.min(screen.height, initialHeight));
+$(document).ready(function () {
+  function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+    const width = Math.max(100, Math.min(screen.width, initialWidth));
+    const height = Math.max(100, Math.min(screen.height, initialHeight));
 
-  const left = (screen.width / 2) - (width / 2);
-  const top = (screen.height * 0.3) - (height / 2);
-  const opts = `width=${width},height=${height},left=${left},top=${top},menubar=no,status=no,location=no`;
+    const left = screenLeft + ((outerWidth - width) / 2);
+    const top = screenTop + ((outerHeight - height) / 2);
+    const opts = `width=${width},height=${height},left=${left},top=${top},menubar=no,status=no,location=no`;
 
-  window.open(url, "popup", opts);
-}
+    window.open(url, "popup", opts);
+  }
 
-$(document).ready(function () {
   $(".ssb-icon").on("click", function (e) {
     const shareUrl = $(this).attr("href");
     if (!shareUrl.startsWith("mailto:")) {
@@ -18,4 +18,3 @@ $(document).ready(function () {
     }
   });
 });
-