Merge remote-tracking branch 'upstream/pull/5391'

[rails.git] / .rubocop.yml

diff --git a/.rubocop.yml b/.rubocop.yml
index dc7590df36d3ee5353256fe2f308af287ae0443c..60d14454437c10c9b2e5f46fe609d619e8c6a44f 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,13 +1,15 @@
 inherit_from: .rubocop_todo.yml
 
 require:
 inherit_from: .rubocop_todo.yml
 
 require:

+  - rubocop-capybara
+  - rubocop-factory_bot

   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails
   - rubocop-rake
 
 AllCops:
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails
   - rubocop-rake
 
 AllCops:

-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.1

   NewCops: enable
   Exclude:
     - 'vendor/**/*'
   NewCops: enable
   Exclude:
     - 'vendor/**/*'


@@ -43,9 +45,16 @@ Naming/FileName:
 Naming/MethodParameterName:
   Enabled: false
 
 Naming/MethodParameterName:
   Enabled: false
 

+# This conflicts with Strong Migrations, which can't check `change_table`
+Rails/BulkChangeTable:
+  Enabled: false
+

 Rails/CreateTableWithTimestamps:
   Enabled: false
 
 Rails/CreateTableWithTimestamps:
   Enabled: false
 

+Rails/FindBy:
+  IgnoreWhereFirst: false
+

 Rails/FindEach:
   Enabled: false
 
 Rails/FindEach:
   Enabled: false
 


@@ -61,7 +70,7 @@ Rails/ReflectionClassName:
 Rails/SkipsModelValidations:
   Exclude:
     - 'db/migrate/*.rb'
 Rails/SkipsModelValidations:
   Exclude:
     - 'db/migrate/*.rb'

-    - 'app/controllers/users_controller.rb'
+    - 'app/controllers/users/lists_controller.rb'

 
 Style/Documentation:
   Enabled: false
 
 Style/Documentation:
   Enabled: false


@@ -96,12 +105,6 @@ Style/MixinUsage:
     - 'bin/setup'
     - 'bin/update'
 
     - 'bin/setup'
     - 'bin/update'
 

-Style/RedundantCondition:
-  Exclude:
-    - 'app/controllers/messages_controller.rb'
-    - 'app/controllers/sessions_controller.rb'
-    - 'app/controllers/users_controller.rb'
-

 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes