Add some more tests, better error handling for dates

[rails.git] / app / models / notifier.rb

diff --git a/app/models/notifier.rb b/app/models/notifier.rb
index 5972a700b8af794c9246c777df171a458e445820..d08bedd8ca05a5c9f9d162a942248499a1b711bf 100644 (file)
--- a/app/models/notifier.rb
+++ b/app/models/notifier.rb
@@ -3,153 +3,214 @@ class Notifier < ActionMailer::Base
           :return_path => EMAIL_RETURN_PATH,
           :auto_submitted => "auto-generated"
   helper :application
           :return_path => EMAIL_RETURN_PATH,
           :auto_submitted => "auto-generated"
   helper :application

+  before_action :set_shared_template_vars
+  before_action :attach_project_logo

 
   def signup_confirm(user, token)
 
   def signup_confirm(user, token)

-    @locale = user.preferred_language_from(I18n.available_locales)
-
-    # If we are passed an email address verification token, create
-    # the confirumation URL for account activation.
-    #
-    # Otherwise the email has already been verified e.g. through
-    # a trusted openID provider and the account is active and a
-    # confirmation URL is not needed.
-    if token
-      @url = url_for(:host => SERVER_URL,
-                     :controller => "user", :action => "confirm",
+    with_recipient_locale user do
+      @url = url_for(:controller => "user", :action => "confirm",

                      :display_name => user.display_name,
                      :confirm_string => token.token)
                      :display_name => user.display_name,
                      :confirm_string => token.token)

-    end

 
 

-    mail :to => user.email,
-         :subject => I18n.t('notifier.signup_confirm.subject', :locale => @locale)
+      mail :to => user.email,
+           :subject => I18n.t("notifier.signup_confirm.subject")
+    end

   end
 
   def email_confirm(user, token)
   end
 
   def email_confirm(user, token)

-    @locale = user.preferred_language_from(I18n.available_locales)
-    @address = user.new_email
-    @url = url_for(:host => SERVER_URL,
-                   :controller => "user", :action => "confirm_email",
-                   :confirm_string => token.token)
+    with_recipient_locale user do
+      @address = user.new_email
+      @url = url_for(:controller => "user", :action => "confirm_email",
+                     :confirm_string => token.token)

 
 

-    mail :to => user.new_email,
-         :subject => I18n.t('notifier.email_confirm.subject', :locale => @locale)
+      mail :to => user.new_email,
+           :subject => I18n.t("notifier.email_confirm.subject")
+    end

   end
 
   def lost_password(user, token)
   end
 
   def lost_password(user, token)

-    @locale = user.preferred_language_from(I18n.available_locales)
-    @url = url_for(:host => SERVER_URL,
-                   :controller => "user", :action => "reset_password",
-                   :token => token.token)
+    with_recipient_locale user do
+      @url = url_for(:controller => "user", :action => "reset_password",
+                     :token => token.token)

 
 

-    mail :to => user.email,
-         :subject => I18n.t('notifier.lost_password.subject', :locale => @locale)
+      mail :to => user.email,
+           :subject => I18n.t("notifier.lost_password.subject")
+    end

   end
 
   def gpx_success(trace, possible_points)
   end
 
   def gpx_success(trace, possible_points)

-    @locale = trace.user.preferred_language_from(I18n.available_locales)
-    @trace_name = trace.name
-    @trace_points = trace.size
-    @trace_description = trace.description
-    @trace_tags = trace.tags
-    @possible_points = possible_points
-
-    mail :to => trace.user.email,
-         :subject => I18n.t('notifier.gpx_notification.success.subject', :locale => @locale)
+    with_recipient_locale trace.user do
+      @trace_name = trace.name
+      @trace_points = trace.size
+      @trace_description = trace.description
+      @trace_tags = trace.tags
+      @possible_points = possible_points
+
+      mail :to => trace.user.email,
+           :subject => I18n.t("notifier.gpx_notification.success.subject")
+    end

   end
 
   def gpx_failure(trace, error)
   end
 
   def gpx_failure(trace, error)

-    @locale = trace.user.preferred_language_from(I18n.available_locales)
-    @trace_name = trace.name
-    @trace_description = trace.description
-    @trace_tags = trace.tags
-    @error = error
-
-    mail :to => trace.user.email,
-         :subject => I18n.t('notifier.gpx_notification.failure.subject', :locale => @locale)
+    with_recipient_locale trace.user do
+      @trace_name = trace.name
+      @trace_description = trace.description
+      @trace_tags = trace.tags
+      @error = error
+
+      mail :to => trace.user.email,
+           :subject => I18n.t("notifier.gpx_notification.failure.subject")
+    end

   end
 
   def message_notification(message)
   end
 
   def message_notification(message)

-    @locale = message.recipient.preferred_language_from(I18n.available_locales)
-    @to_user = message.recipient.display_name
-    @from_user = message.sender.display_name
-    @text = message.body
-    @title = message.title
-    @readurl = url_for(:host => SERVER_URL,
-                       :controller => "message", :action => "read",
-                       :message_id => message.id)
-    @replyurl = url_for(:host => SERVER_URL,
-                        :controller => "message", :action => "reply",
-                        :message_id => message.id)
-
-    mail :from => from_address(message.sender.display_name, "m", message.id, message.digest),
-         :to => message.recipient.email,
-         :subject => I18n.t('notifier.message_notification.subject_header', :subject => message.title, :locale => @locale)
-  end
-
-  def diary_comment_notification(comment)
-    @locale = comment.diary_entry.user.preferred_language_from(I18n.available_locales)
-    @to_user = comment.diary_entry.user.display_name
-    @from_user = comment.user.display_name
-    @text = comment.body
-    @title = comment.diary_entry.title
-    @readurl = url_for(:host => SERVER_URL,
-                       :controller => "diary_entry",
-                       :action => "view",
-                       :display_name => comment.diary_entry.user.display_name,
-                       :id => comment.diary_entry.id,
-                       :anchor => "comment#{comment.id}")
-    @commenturl = url_for(:host => SERVER_URL,
-                          :controller => "diary_entry",
-                          :action => "view",
-                          :display_name => comment.diary_entry.user.display_name,
-                          :id => comment.diary_entry.id,
-                          :anchor => "newcomment")
-    @replyurl = url_for(:host => SERVER_URL,
-                        :controller => "message",
-                        :action => "new",
-                        :display_name => comment.user.display_name,
-                        :title => "Re: #{comment.diary_entry.title}")
-
-    mail :from => from_address(comment.user.display_name, "c", comment.id, comment.digest),
-         :to =>  comment.diary_entry.user.email,
-         :subject => I18n.t('notifier.diary_comment_notification.subject', :user => comment.user.display_name, :locale => @locale)
+    with_recipient_locale message.recipient do
+      @to_user = message.recipient.display_name
+      @from_user = message.sender.display_name
+      @text = message.body
+      @title = message.title
+      @readurl = message_url(message)
+      @replyurl = reply_message_url(message)
+      @author = @from_user
+
+      attach_user_avatar(message.sender)
+
+      mail :from => from_address(message.sender.display_name, "m", message.id, message.digest),
+           :to => message.recipient.email,
+           :subject => I18n.t("notifier.message_notification.subject_header", :subject => message.title)
+    end

   end
 
   end
 

-  def friend_notification(friend)
-    @locale = friend.befriendee.preferred_language_from(I18n.available_locales)
-    @friend = friend
+  def diary_comment_notification(comment, recipient)
+    with_recipient_locale recipient do
+      @to_user = recipient.display_name
+      @from_user = comment.user.display_name
+      @text = comment.body
+      @title = comment.diary_entry.title
+      @readurl = url_for(:controller => "diary_entry",
+                         :action => "view",
+                         :display_name => comment.diary_entry.user.display_name,
+                         :id => comment.diary_entry.id,
+                         :anchor => "comment#{comment.id}")
+      @commenturl = url_for(:controller => "diary_entry",
+                            :action => "view",
+                            :display_name => comment.diary_entry.user.display_name,
+                            :id => comment.diary_entry.id,
+                            :anchor => "newcomment")
+      @replyurl = new_message_url(comment.user, :message => { :title => "Re: #{comment.diary_entry.title}" })
+
+      @author = @from_user
+
+      attach_user_avatar(comment.user)
+
+      mail :from => from_address(comment.user.display_name, "c", comment.id, comment.digest, recipient.id),
+           :to => recipient.email,
+           :subject => I18n.t("notifier.diary_comment_notification.subject", :user => comment.user.display_name)
+    end
+  end

 
 

-    mail :to => friend.befriendee.email,
-         :subject => I18n.t('notifier.friend_notification.subject', :user => friend.befriender.display_name, :locale => @locale)
+  def friend_notification(friend)
+    with_recipient_locale friend.befriendee do
+      @friend = friend
+      @viewurl = url_for(:controller => "user", :action => "view",
+                         :display_name => @friend.befriender.display_name)
+      @friendurl = url_for(:controller => "user", :action => "make_friend",
+                           :display_name => @friend.befriender.display_name)
+      @author = @friend.befriender.display_name
+
+      attach_user_avatar(@friend.befriender)
+      mail :to => friend.befriendee.email,
+           :subject => I18n.t("notifier.friend_notification.subject", :user => friend.befriender.display_name)
+    end

   end
 
   def note_comment_notification(comment, recipient)
   end
 
   def note_comment_notification(comment, recipient)

-    @locale = recipient.preferred_language_from(I18n.available_locales)
-    @noteurl = browse_note_url(comment.note, :host => SERVER_URL)
-    @place = Nominatim.describe_location(comment.note.lat, comment.note.lon, 14, @locale)
-    @comment = comment.body
-    @owner = recipient == comment.note.author
+    with_recipient_locale recipient do
+      @noteurl = browse_note_url(comment.note)
+      @place = Nominatim.describe_location(comment.note.lat, comment.note.lon, 14, I18n.locale)
+      @comment = comment.body
+      @owner = recipient == comment.note.author
+      @event = comment.event
+
+      @commenter = if comment.author
+                     comment.author.display_name
+                   else
+                     I18n.t("notifier.note_comment_notification.anonymous")
+                   end
+
+      @author = @commenter
+      attach_user_avatar(comment.author)
+
+      subject = if @owner
+                  I18n.t("notifier.note_comment_notification.#{@event}.subject_own", :commenter => @commenter)
+                else
+                  I18n.t("notifier.note_comment_notification.#{@event}.subject_other", :commenter => @commenter)
+                end
+
+      mail :to => recipient.email, :subject => subject
+    end
+  end

 
 

-    if comment.author
+  def changeset_comment_notification(comment, recipient)
+    with_recipient_locale recipient do
+      @to_user = recipient.display_name
+      @changeset_url = changeset_url(comment.changeset)
+      @comment = comment.body
+      @owner = recipient == comment.changeset.user

       @commenter = comment.author.display_name
       @commenter = comment.author.display_name

-    else
-      @commenter = I18n.t("notifier.note_comment_notification.anonymous")
+      @changeset_comment = comment.changeset.tags["comment"].presence
+      @time = comment.created_at
+      @changeset_author = comment.changeset.user.display_name
+      @author = @commenter
+
+      subject = if @owner
+                  I18n.t("notifier.changeset_comment_notification.commented.subject_own", :commenter => @commenter)
+                else
+                  I18n.t("notifier.changeset_comment_notification.commented.subject_other", :commenter => @commenter)
+                end
+
+      attach_user_avatar(comment.author)
+
+      mail :to => recipient.email, :subject => subject

     end
     end

+  end
+
+  private
+
+  def set_shared_template_vars
+    @root_url = root_url
+  end
+
+  def attach_project_logo
+    attachments.inline["logo.png"] = File.read(Rails.root.join("app", "assets", "images", "osm_logo_30.png"))
+  end
+
+  def attach_user_avatar(user)
+    attachments.inline["avatar.png"] = File.read(user_avatar_file_path(user))
+  end

 
 

-    if @owner
-      subject = I18n.t('notifier.note_comment_notification.subject_own', :commenter => @commenter)
+  def user_avatar_file_path(user)
+    image = user && user.image
+    if image && image.file?
+      return image.path(:small)

     else
     else

-      subject = I18n.t('notifier.note_comment_notification.subject_other', :commenter => @commenter)
+      return Rails.root.join("app", "assets", "images", "users", "images", "small.png")

     end
     end

-
-    mail :to => recipient.email, :subject => subject

   end
 
   end
 

-private
+  def with_recipient_locale(recipient)
+    I18n.with_locale Locale.available.preferred(recipient.preferred_languages) do
+      yield
+    end
+  end

 
 

-  def from_address(name, type, id, digest)
-    if Object.const_defined?(:MESSAGES_DOMAIN) and domain = MESSAGES_DOMAIN
-      "#{name} <#{type}-#{id}-#{digest[0,6]}@#{domain}>"
+  def from_address(name, type, id, digest, user_id = nil)
+    if Object.const_defined?(:MESSAGES_DOMAIN) && domain = MESSAGES_DOMAIN
+      if user_id
+        "#{name} <#{type}-#{id}-#{user_id}-#{digest[0, 6]}@#{domain}>"
+      else
+        "#{name} <#{type}-#{id}-#{digest[0, 6]}@#{domain}>"
+      end

     else
       EMAIL_FROM
     end
     else
       EMAIL_FROM
     end