Close a number of holes in the API by making it validate changes

[rails.git] / app / models / trace.rb

diff --git a/app/models/trace.rb b/app/models/trace.rb
index 11f912b693aa2f16977544ef3b7eacf63165cb9b..f2dcf9ad9391902c10d81219094abb2c33b2f6c5 100644 (file)
--- a/app/models/trace.rb
+++ b/app/models/trace.rb
@@ -1,10 +1,10 @@
 class Trace < ActiveRecord::Base
   set_table_name 'gpx_files'
 
-  validates_presence_of :user_id, :name, :public, :timestamp
+  validates_presence_of :user_id, :name, :timestamp
   validates_presence_of :description, :on => :create
 #  validates_numericality_of :latitude, :longitude
-  validates_inclusion_of :inserted, :in => [ true, false]
+  validates_inclusion_of :public, :inserted, :in => [ true, false]
   
   belongs_to :user
   has_many :tags, :class_name => 'Tracetag', :foreign_key => 'gpx_id', :dependent => :delete_all
@@ -12,7 +12,13 @@ class Trace < ActiveRecord::Base
 
   def destroy
     super
-    FileUtils.rm_f(trace_name, icon_picture_name, large_picture_name)
+    FileUtils.rm_f(trace_name)
+    FileUtils.rm_f(icon_picture_name)
+    FileUtils.rm_f(large_picture_name)
+  end
+
+  def tagstring
+    return tags.collect {|tt| tt.tag}.join(" ")
   end
 
   def tagstring=(s)
@@ -86,11 +92,15 @@ class Trace < ActiveRecord::Base
       # TODO *nix specific, could do to work on windows... would be functionally inferior though - check for '.gz'
       filetype = `file -b #{trace_name}`.chomp
       gzipped = filetype =~ /^gzip/
+      bzipped = filetype =~ /^bzip2/
       zipped = filetype =~ /^Zip/
 
       if gzipped
         filename = tempfile = "/tmp/#{rand}"
         system("gunzip -c #{trace_name} > #{filename}")
+      elsif bzipped
+        filename = tempfile = "/tmp/#{rand}"
+        system("bunzip2 -c #{trace_name} > #{filename}")
       elsif zipped
         filename = tempfile = "/tmp/#{rand}"
         system("unzip -p #{trace_name} > #{filename}")