+# The NodeController is the RESTful interface to Node objects
+
class NodeController < ApplicationController
require 'xml/libxml'
- before_filter :authorize
+ session :off
+ before_filter :authorize, :only => [:create, :update, :delete]
+ before_filter :check_write_availability, :only => [:create, :update, :delete]
+ before_filter :check_read_availability, :except => [:create, :update, :delete]
+ after_filter :compress_output
+ # Create a node from XML.
def create
if request.put?
- p = XML::Parser.new
- p.string = request.raw_post
- doc = p.parse
-
- doc.find('//osm/node').each do |pt|
- lat = pt['lat'].to_f
- lon = pt['lon'].to_f
- node_id = pt['id'].to_i
-
- if lat > 90 or lat < -90 or lon > 180 or lon < -180 or node_id != 0
- render :nothing => true, :status => 400 # BAD REQUEST
- return
- end
-
- tags = []
-
- pt.find('tag').each do |tag|
- tags << [tag['k'],tag['v']]
- end
- tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
- tags = '' if tags.nil?
-
- now = Time.now
-
- node = Node.new
- node.latitude = lat
- node.longitude = lon
- node.visible = 1
- node.tags = tags
- node.timestamp = now
- node.user_id = @user.id
-
- #FIXME add a node to the old nodes table too
-
- if node.save
- render :text => node.id
- else
- render :nothing => true, :status => 500
- end
-
- return
+ node = Node.from_xml(request.raw_post, true)
+ # FIXME remove debug
+ logger.debug request.raw_post
+ logger.debug node
+
+ if node
+ node.version = 0
+ #node.changeset_id = node.changeset
+ node.visible = true
+ node.save_with_history!
+
+ render :text => node.id.to_s, :content_type => "text/plain"
+ else
+ render :nothing => true, :status => :bad_request
end
+ else
+ render :nothing => true, :status => :method_not_allowed
end
-
- render :nothing => true, :status => 400 # if we got here the doc didnt parse
end
- def rest
- unless Node.exists?(params[:id])
- render :nothing => true, :status => 400
- return
+ # Dump the details on a node given in params[:id]
+ def read
+ begin
+ node = Node.find(params[:id])
+ if node.visible?
+ response.headers['Last-Modified'] = node.timestamp.rfc822
+ render :text => node.to_xml.to_s, :content_type => "text/xml"
+ else
+ render :text => "", :status => :gone
+ end
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
end
-
- node = Node.find(params[:id])
-
-
- case request.method
- when :get
- doc = XML::Document.new
-
- doc.encoding = "UTF-8"
- root = XML::Node.new 'osm'
- root['version'] = '0.4'
- root['generator'] = 'OpenStreetMap server'
- doc.root = root
- el1 = XML::Node.new 'node'
- el1['id'] = node.id.to_s
- el1['lat'] = node.latitude.to_s
- el1['lon'] = node.longitude.to_s
- split_tags(el1, node.tags)
- el1['visible'] = node.visible.to_s
- el1['timestamp'] = node.timestamp.xmlschema
- root << el1
-
- render :text => doc.to_s
-
- when :delete
- #
- # DELETE
- #
-
+ end
+
+ # Dump a specific version of the node based on the given params[:id] and params[:version]
+ def version
+ begin
+ node = Node.find(:first, :conditions => { :id => params[:id], :version => params[:version] } )
if node.visible
- node.visible = 0
- node.save
- render :nothing => true
+ response.headers['Last-Modified'] = node.timestamp.rfc822
+ render :text => node.to_xml.to_s, :content_type => "text/xml"
else
- render :nothing => true, :status => 410
+ render :nothing => true, :status => :gone
end
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
+ end
+ end
- when :put
- #
- # PUT
- #
-
- p = XML::Parser.new
- p.string = request.raw_post
- doc = p.parse
-
- doc.find('//osm/node').each do |pt|
- lat = pt['lat'].to_f
- lon = pt['lon'].to_f
- node_id = pt['id'].to_i
-
- if lat > 90 or lat < -90 or lon > 180 or lon < -180 or node_id != params[:id]
- render :nothing => true, :status => 400
- return
- end
-
- tags = []
-
- pt.find('tag').each do |tag|
- tags << [tag['k'],tag['v']]
- end
- tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
- tags = '' if tags.nil?
-
- now = Time.now
-
- node.latitude = lat
- node.longitude = lon
- node.visible = 1
- node.tags = tags
- node.timestamp = now
- node.user_id = @user.id
-
- #FIXME add a node to the old nodes table too
+ # Update a node from given XML
+ def update
+ begin
+ node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
- if node.save
- render :text => node.id
- else
- render :nothing => true, :status => 500
- end
+ if new_node and new_node.id == node.id
+ node.update_from(new_node, @user)
+ render :text => node.version.to_s, :content_type => "text/plain"
+ else
+ render :nothing => true, :status => :bad_request
end
+ rescue OSM::APIVersionMismatchError => ex
+ render :text => "Version mismatch: Provided " + ex.provided.to_s +
+ ", server had: " + ex.latest.to_s, :status => :bad_request
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
end
end
- private
- def split_tags(el, tags)
- tags.split(';').each do |tag|
- parts = tag.split('=')
- key = ''
- val = ''
- key = parts[0].strip unless parts[0].nil?
- val = parts[1].strip unless parts[1].nil?
- if key != '' && val != ''
- el2 = Node.new('tag')
- el2['k'] = key.to_s
- el2['v'] = val.to_s
- el << el2
+ # Delete a node. Doesn't actually delete it, but retains its history in a wiki-like way.
+ # FIXME remove all the fricking SQL
+ def delete
+ begin
+ node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
+ # FIXME we no longer care about the user, (or maybe we want to check
+ # that the user of the changeset is the same user as is making this
+ # little change?) we really care about the
+ # changeset which must be open, and that the version that we have been
+ # given is the one that is currently stored in the database
+
+ if new_node and new_node.id == node.id
+ node.delete_with_history(new_node, @user)
+ render :nothing => true, :status => :success
+ else
+ render :nothing => true, :status => :bad_request
end
+ rescue ActiveRecord::RecordNotFound
+ render :nothing => true, :status => :not_found
+ rescue OSM::APIError => ex
+ render ex.render_opts
end
end
+ # WTF does this do?
+ def nodes
+ ids = params['nodes'].split(',').collect { |n| n.to_i }
+ if ids.length > 0
+ doc = OSM::API.new.get_xml_doc
+
+ Node.find(ids).each do |node|
+ doc.root << node.to_xml_node
+ end
+
+ render :text => doc.to_s, :content_type => "text/xml"
+ else
+ render :nothing => true, :status => :bad_request
+ end
+ end
end
projects / rails.git / blobdiff