+# The NodeController is the RESTful interface to Node objects
+
class NodeController < ApplicationController
- require 'xml/libxml'
+ require "xml/libxml"
- before_filter :authorize
+ skip_before_action :verify_authenticity_token
+ before_action :authorize, :only => [:create, :update, :delete]
+ before_action :require_allow_write_api, :only => [:create, :update, :delete]
+ before_action :require_public_data, :only => [:create, :update, :delete]
+ before_action :check_api_writable, :only => [:create, :update, :delete]
+ before_action :check_api_readable, :except => [:create, :update, :delete]
+ around_action :api_call_handle_error, :api_call_timeout
+ # Create a node from XML.
def create
- if request.put?
- p = XML::Parser.new
- p.string = request.raw_post
- doc = p.parse
-
- doc.find('//osm/node').each do |pt|
- lat = pt['lat'].to_f
- lon = pt['lon'].to_f
- node_id = pt['id'].to_i
-
- if lat > 90 or lat < -90 or lon > 180 or lon < -180 or node_id != 0
- render :nothing => true, :status => 400 # BAD REQUEST
- return
- end
-
- tags = []
-
- pt.find('tag').each do |tag|
- tags << [tag['k'],tag['v']]
- end
- tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
- tags = '' if tags.nil?
-
- now = Time.now
-
- node = Node.new
- node.latitude = lat
- node.longitude = lon
- node.visible = 1
- node.tags = tags
- node.timestamp = now
- node.user_id = @user.id
-
- #FIXME add a node to the old nodes table too
-
- if node.save
- render :text => node.id
- else
- render :nothing => true, :status => 500
- end
-
- return
- end
- end
+ assert_method :put
+
+ node = Node.from_xml(request.raw_post, true)
- render :nothing => true, :status => 400 # if we got here the doc didnt parse
+ # Assume that Node.from_xml has thrown an exception if there is an error parsing the xml
+ node.create_with_history current_user
+ render :plain => node.id.to_s
end
- def rest
- unless Node.exists?(params[:id])
- render :nothing => true, :status => 400
- return
+ # Dump the details on a node given in params[:id]
+ def read
+ node = Node.find(params[:id])
+
+ response.last_modified = node.timestamp
+
+ if node.visible
+ render :xml => node.to_xml.to_s
+ else
+ head :gone
end
+ end
+ # Update a node from given XML
+ def update
node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
+ raise OSM::APIBadUserInput, "The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})" unless new_node && new_node.id == node.id
- case request.method
- when :get
- doc = XML::Document.new
-
- doc.encoding = "UTF-8"
- root = XML::Node.new 'osm'
- root['version'] = '0.4'
- root['generator'] = 'OpenStreetMap server'
- doc.root = root
- el1 = XML::Node.new 'node'
- el1['id'] = node.id.to_s
- el1['lat'] = node.latitude.to_s
- el1['lon'] = node.longitude.to_s
- split_tags(el1, node.tags)
- el1['visible'] = node.visible.to_s
- el1['timestamp'] = node.timestamp.xmlschema
- root << el1
-
- render :text => doc.to_s
-
- when :delete
- #
- # DELETE
- #
-
- if node.visible
- node.visible = 0
- node.save
- render :nothing => true
- else
- render :nothing => true, :status => 410
- end
-
- when :put
- #
- # PUT
- #
-
- p = XML::Parser.new
- p.string = request.raw_post
- doc = p.parse
-
- doc.find('//osm/node').each do |pt|
- lat = pt['lat'].to_f
- lon = pt['lon'].to_f
- node_id = pt['id'].to_i
-
- if lat > 90 or lat < -90 or lon > 180 or lon < -180 or node_id != params[:id]
- render :nothing => true, :status => 400
- return
- end
-
- tags = []
-
- pt.find('tag').each do |tag|
- tags << [tag['k'],tag['v']]
- end
- tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
- tags = '' if tags.nil?
-
- now = Time.now
-
- node.latitude = lat
- node.longitude = lon
- node.visible = 1
- node.tags = tags
- node.timestamp = now
- node.user_id = @user.id
-
- #FIXME add a node to the old nodes table too
-
- if node.save
- render :text => node.id
- else
- render :nothing => true, :status => 500
- end
- end
- end
+ node.update_from(new_node, current_user)
+ render :plain => node.version.to_s
end
- private
- def split_tags(el, tags)
- tags.split(';').each do |tag|
- parts = tag.split('=')
- key = ''
- val = ''
- key = parts[0].strip unless parts[0].nil?
- val = parts[1].strip unless parts[1].nil?
- if key != '' && val != ''
- el2 = Node.new('tag')
- el2['k'] = key.to_s
- el2['v'] = val.to_s
- el << el2
- end
- end
+ # Delete a node. Doesn't actually delete it, but retains its history
+ # in a wiki-like way. We therefore treat it like an update, so the delete
+ # method returns the new version number.
+ def delete
+ node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
+
+ raise OSM::APIBadUserInput, "The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})" unless new_node && new_node.id == node.id
+
+ node.delete_with_history!(new_node, current_user)
+ render :plain => node.version.to_s
end
+ # Dump the details on many nodes whose ids are given in the "nodes" parameter.
+ def nodes
+ raise OSM::APIBadUserInput, "The parameter nodes is required, and must be of the form nodes=id[,id[,id...]]" unless params["nodes"]
+
+ ids = params["nodes"].split(",").collect(&:to_i)
+
+ raise OSM::APIBadUserInput, "No nodes were given to search for" if ids.empty?
+ doc = OSM::API.new.get_xml_doc
+
+ Node.find(ids).each do |node|
+ doc.root << node.to_xml_node
+ end
+
+ render :xml => doc.to_s
+ end
end
projects / rails.git / blobdiff