Replace show and index abilities with read ability

[rails.git] / app / abilities / api_capability.rb

diff --git a/app/abilities/api_capability.rb b/app/abilities/api_capability.rb
index 44e67634552599c861f9320209e8a7810a155edd..1c2eab41f78bb5b39823d4cda8584fe8b7d9a998 100644 (file)
--- a/app/abilities/api_capability.rb
+++ b/app/abilities/api_capability.rb
@@ -5,21 +5,18 @@ class ApiCapability
 
   def initialize(token)
     if Settings.status != "database_offline"
 
   def initialize(token)
     if Settings.status != "database_offline"

-      user = if token.respond_to?(:resource_owner_id)
-               User.find(token.resource_owner_id)
-             elsif token.respond_to?(:user)
-               token.user
-             end
+      user = User.find(token.resource_owner_id)

 
       if user&.active?
         can [:create, :comment, :close, :reopen], Note if scope?(token, :write_notes)
 
       if user&.active?
         can [:create, :comment, :close, :reopen], Note if scope?(token, :write_notes)

-        can [:show, :data], Trace if scope?(token, :read_gpx)
+        can [:create, :destroy], NoteSubscription if scope?(token, :write_notes)
+        can [:read, :data], Trace if scope?(token, :read_gpx)

         can [:create, :update, :destroy], Trace if scope?(token, :write_gpx)
         can [:details], User if scope?(token, :read_prefs)
         can [:gpx_files], User if scope?(token, :read_gpx)
         can [:create, :update, :destroy], Trace if scope?(token, :write_gpx)
         can [:details], User if scope?(token, :read_prefs)
         can [:gpx_files], User if scope?(token, :read_gpx)

-        can [:index, :show], UserPreference if scope?(token, :read_prefs)
+        can :read, UserPreference if scope?(token, :read_prefs)

         can [:update, :update_all, :destroy], UserPreference if scope?(token, :write_prefs)
         can [:update, :update_all, :destroy], UserPreference if scope?(token, :write_prefs)

-        can [:inbox, :outbox, :show, :update, :destroy], Message if scope?(token, :consume_messages)
+        can [:inbox, :outbox, :read, :update, :destroy], Message if scope?(token, :consume_messages)

         can [:create], Message if scope?(token, :send_messages)
 
         if user.terms_agreed?
         can [:create], Message if scope?(token, :send_messages)
 
         if user.terms_agreed?


@@ -31,7 +28,7 @@ class ApiCapability
         if user.moderator?
           can [:destroy, :restore], ChangesetComment if scope?(token, :write_api)
           can :destroy, Note if scope?(token, :write_notes)
         if user.moderator?
           can [:destroy, :restore], ChangesetComment if scope?(token, :write_api)
           can :destroy, Note if scope?(token, :write_notes)

-          can :redact, [OldNode, OldWay, OldRelation] if user&.terms_agreed? && (scope?(token, :write_api) || scope?(token, :write_redactions))
+          can :redact, [OldNode, OldWay, OldRelation] if user&.terms_agreed? && scope?(token, :write_redactions)

         end
       end
     end
         end
       end
     end