Handle errors a bit better.

[rails.git] / app / models / segment.rb

diff --git a/app/models/segment.rb b/app/models/segment.rb
index b6f60ec3f9dd9d2c181d229ff85c958fb2e15f31..bdb807d9399991cb7faa9ec70898ecccff767345 100644 (file)
--- a/app/models/segment.rb
+++ b/app/models/segment.rb
@@ -2,8 +2,9 @@ class Segment < ActiveRecord::Base
   require 'xml/libxml'
   set_table_name 'current_segments'
 
   require 'xml/libxml'
   set_table_name 'current_segments'
 

-  validates_numericality_of :node_a
-  validates_numericality_of :node_b
+  validates_presence_of :user_id, :timestamp
+  validates_inclusion_of :visible, :in => [ true, false ]
+  validates_numericality_of :node_a, :node_b

 
   has_many :old_segments, :foreign_key => :id
   belongs_to :user
 
   has_many :old_segments, :foreign_key => :id
   belongs_to :user


@@ -13,43 +14,48 @@ class Segment < ActiveRecord::Base
   belongs_to :to_node, :class_name => 'Node', :foreign_key => 'node_b'
 
   def self.from_xml(xml, create=false)
   belongs_to :to_node, :class_name => 'Node', :foreign_key => 'node_b'
 
   def self.from_xml(xml, create=false)

-    p = XML::Parser.new
-    p.string = xml
-    doc = p.parse
-
-    segment = Segment.new
+    begin
+      p = XML::Parser.new
+      p.string = xml
+      doc = p.parse

 
 

-    doc.find('//osm/segment').each do |pt|
+      segment = Segment.new

 
 

-      segment.node_a = pt['from'].to_i
-      segment.node_b = pt['to'].to_i
+      doc.find('//osm/segment').each do |pt|
+        segment.node_a = pt['from'].to_i
+        segment.node_b = pt['to'].to_i

 
 

-      if pt['id'] != '0'
-        segment.id = pt['id'].to_i
-      end
+        unless create
+          if pt['id'] != '0'
+            segment.id = pt['id'].to_i
+          end
+        end

 
 

-      segment.visible = true
+        segment.visible = true

 
 

-      if create
-        segment.timestamp = Time.now
-      else
-        if pt['timestamp']
-          segment.timestamp = Time.parse(pt['timestamp'])
+        if create
+          segment.timestamp = Time.now
+        else
+          if pt['timestamp']
+            segment.timestamp = Time.parse(pt['timestamp'])
+          end

         end
         end

-      end
-
-      tags = []

 
 

-      pt.find('tag').each do |tag|
-        tags << [tag['k'],tag['v']]
-      end
+        tags = []

 
 

-      tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
-      tags = '' if tags.nil?
+        pt.find('tag').each do |tag|
+          tags << [tag['k'],tag['v']]
+        end

 
 

-      segment.tags = tags
+        tags = tags.collect { |k,v| "#{k}=#{v}" }.join(';')
+        tags = '' if tags.nil?

 
 

+        segment.tags = tags
+      end
+    rescue
+      segment = nil

     end
     end

+

     return segment
   end
 
     return segment
   end
 


@@ -57,12 +63,13 @@ class Segment < ActiveRecord::Base
     begin
       Segment.transaction do
         self.timestamp = Time.now
     begin
       Segment.transaction do
         self.timestamp = Time.now

-        self.save
+        self.save!

         old_segment = OldSegment.from_segment(self)
         old_segment = OldSegment.from_segment(self)

-        old_segment.save
+        old_segment.save!

       end
       end

+

       return true
       return true

-    rescue Exception => ex
+    rescue

       return nil
     end
   end
       return nil
     end
   end


@@ -78,14 +85,18 @@ class Segment < ActiveRecord::Base
     el1['id'] = self.id.to_s
     el1['from'] = self.node_a.to_s
     el1['to'] = self.node_b.to_s
     el1['id'] = self.id.to_s
     el1['from'] = self.node_a.to_s
     el1['to'] = self.node_b.to_s

-    if user_display_name_cache and user_display_name_cache[self.user_id]
+
+    user_display_name_cache = {} if user_display_name_cache.nil?
+
+    if user_display_name_cache and user_display_name_cache.key?(self.user_id)

       # use the cache if available
       # use the cache if available

-    else
+    elsif self.user.data_public?

       user_display_name_cache[self.user_id] = self.user.display_name
       user_display_name_cache[self.user_id] = self.user.display_name

+    else
+      user_display_name_cache[self.user_id] = nil

     end
     end

-    
-    #el1['user'] = self.user.display_name if self.user.data_public?
-    el1['user'] = user_display_name_cache[self.user_id]
+
+    el1['user'] = user_display_name_cache[self.user_id] unless user_display_name_cache[self.user_id].nil?

 
     Segment.split_tags(el1, self.tags)
     el1['visible'] = self.visible.to_s
 
     Segment.split_tags(el1, self.tags)
     el1['visible'] = self.visible.to_s