+# The NodeController is the RESTful interface to Node objects
+
class NodeController < ApplicationController
require 'xml/libxml'
- before_filter :authorize
+ before_filter :authorize, :only => [:create, :update, :delete]
+ before_filter :require_allow_write_api, :only => [:create, :update, :delete]
+ before_filter :require_public_data, :only => [:create, :update, :delete]
+ before_filter :check_api_writable, :only => [:create, :update, :delete]
+ before_filter :check_api_readable, :except => [:create, :update, :delete]
+ after_filter :compress_output
+ around_filter :api_call_handle_error, :api_call_timeout
+ # Create a node from XML.
def create
- if request.put?
- node = Node.from_xml(request.raw_post, true)
+ assert_method :put
- if node
- node.user_id = @user.id
- if node.save_with_history
+ node = Node.from_xml(request.raw_post, true)
- render :text => node.id
- else
- render :nothing => true, :status => 500
- end
- return
+ # Assume that Node.from_xml has thrown an exception if there is an error parsing the xml
+ node.create_with_history @user
+ render :text => node.id.to_s, :content_type => "text/plain"
+ end
- else
- render :nothing => true, :status => 400 # if we got here the doc didnt parse
- return
- end
+ # Dump the details on a node given in params[:id]
+ def read
+ node = Node.find(params[:id])
+ if node.visible?
+ response.headers['Last-Modified'] = node.timestamp.rfc822
+ render :text => node.to_xml.to_s, :content_type => "text/xml"
+ else
+ render :text => "", :status => :gone
end
-
- render :nothing => true, :status => 500 # something went very wrong
end
-
- def rest
- unless Node.exists?(params[:id])
- render :nothing => true, :status => 400
- return
+
+ # Update a node from given XML
+ def update
+ node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
+
+ unless new_node and new_node.id == node.id
+ raise OSM::BadUserInput.new("The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})")
end
+ node.update_from(new_node, @user)
+ render :text => node.version.to_s, :content_type => "text/plain"
+ end
+ # Delete a node. Doesn't actually delete it, but retains its history
+ # in a wiki-like way. We therefore treat it like an update, so the delete
+ # method returns the new version number.
+ def delete
node = Node.find(params[:id])
+ new_node = Node.from_xml(request.raw_post)
+
+ unless new_node and new_node.id == node.id
+ raise OSM::BadUserInput.new("The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})")
+ end
+ node.delete_with_history!(new_node, @user)
+ render :text => node.version.to_s, :content_type => "text/plain"
+ end
- case request.method
-
- when :get
- render :text => node.to_xml.to_s
- return
-
- when :delete
- if node.visible
- node.visible = 0
- node.save_with_history
- render :nothing => true
- else
- render :nothing => true, :status => 410
- end
-
- when :put
- new_node = Node.from_xml(request.raw_post)
-
- node.timestamp = Time.now
- node.user_id = @user.id
+ # Dump the details on many nodes whose ids are given in the "nodes" parameter.
+ def nodes
+ ids = params['nodes'].split(',').collect { |n| n.to_i }
- node.latitude = new_node.latitude
- node.longitude = new_node.longitude
- node.tags = new_node.tags
+ if ids.length == 0
+ raise OSM::BadUserInput.new("No nodes were given to search for")
+ end
+ doc = OSM::API.new.get_xml_doc
- if node.id == new_node.id and node.save_with_history
- render :nothing => true, :status => 200
- else
- render :nothing => true, :status => 500
- end
- return
+ Node.find(ids).each do |node|
+ doc.root << node.to_xml_node
end
+ render :text => doc.to_s, :content_type => "text/xml"
end
end