attempt fix for anon users

[rails.git] / app / controllers / node_controller.rb

diff --git a/app/controllers/node_controller.rb b/app/controllers/node_controller.rb
index b104688d38a58632cbadf75779a14eb1a3208e96..d3f1ce7f65808dee854c4407b3fe4dc952739e1f 100644 (file)
--- a/app/controllers/node_controller.rb
+++ b/app/controllers/node_controller.rb
@@ -1,7 +1,11 @@
 class NodeController < ApplicationController
   require 'xml/libxml'
 
-  before_filter :authorize
+  session :off
+  before_filter :authorize, :only => [:create, :update, :delete]
+  before_filter :check_write_availability, :only => [:create, :update, :delete]
+  before_filter :check_read_availability, :except => [:create, :update, :delete]
+  after_filter :compress_output
 
   def create
     if request.put?
@@ -9,63 +13,91 @@ class NodeController < ApplicationController
 
       if node
         node.user_id = @user.id
-        if node.save_with_history
-
-          render :text => node.id
-        else
-          render :nothing => true, :status => 500
-        end
-        return
+        node.visible = true
+        node.save_with_history!
 
+        render :text => node.id.to_s, :content_type => "text/plain"
       else
-        render :nothing => true, :status => 400 # if we got here the doc didnt parse
-        return
+        render :nothing => true, :status => :bad_request
       end
+    else
+      render :nothing => true, :status => :method_not_allowed
     end
-
-    render :nothing => true, :status => 500 # something went very wrong
   end
 
-  def rest
-    unless Node.exists?(params[:id])
-      render :nothing => true, :status => 400
-      return
-    end
+  def read
+    begin
+      node = Node.find(params[:id])
 
-    node = Node.find(params[:id])
+      if node.visible
+        render :text => node.to_xml.to_s, :content_type => "text/xml"
+       else
+        render :text => "", :status => :gone
+      end
+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
+    end
+  end
 
-    case request.method
+  def update
+    begin
+      node = Node.find(params[:id])
+      new_node = Node.from_xml(request.raw_post)
 
-    when :get
-      render :text => node.to_xml.to_s
-      return
+      if new_node and new_node.id == node.id
+        node.user_id = @user.id
+        node.latitude = new_node.latitude 
+        node.longitude = new_node.longitude
+        node.tags = new_node.tags
+        node.visible = true
+        node.save_with_history!
 
-    when :delete
-      if node.visible
-        node.visible = 0
-        node.save_with_history
         render :nothing => true
       else
-        render :nothing => true, :status => 410
+        render :nothing => true, :status => :bad_request
       end
+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
+    end
+  end
 
-    when :put
-      new_node = Node.from_xml(request.raw_post)
-
-      node.timestamp = Time.now
-      node.user_id = @user.id
+  def delete
+    begin
+      node = Node.find(params[:id])
 
-      node.latitude = new_node.latitude 
-      node.longitude = new_node.longitude
-      node.tags = new_node.tags
+      if node.visible
+        if WayNode.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_nodes.id", :conditions => [ "current_ways.visible = 1 AND current_way_nodes.node_id = ?", node.id ])
+          render :text => "", :status => :precondition_failed
+        elsif RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", :conditions => [ "visible = 1 AND member_type='node' and member_id=?", params[:id]])
+          render :text => "", :status => :precondition_failed
+        else
+          node.user_id = @user.id
+          node.visible = 0
+          node.save_with_history!
 
-      if node.id == new_node.id and node.save_with_history
-        render :nothing => true, :status => 200
+          render :nothing => true
+        end
       else
-        render :nothing => true, :status => 500
+        render :text => "", :status => :gone
       end
-      return
+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
     end
+  end
+
+  def nodes
+    ids = params['nodes'].split(',').collect { |n| n.to_i }
 
+    if ids.length > 0
+      doc = OSM::API.new.get_xml_doc
+
+      Node.find(ids).each do |node|
+        doc.root << node.to_xml_node
+      end 
+
+      render :text => doc.to_s, :content_type => "text/xml"
+    else
+      render :nothing => true, :status => :bad_request
+    end
   end
 end