nodes and segments plural API calls

[rails.git] / app / controllers / api_controller.rb

diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb
index 9e3839697a5f099f74500f50cea76d367ec80115..aa84194146ac205d2155a211581f16f6d128a9fe 100644 (file)
--- a/app/controllers/api_controller.rb
+++ b/app/controllers/api_controller.rb
@@ -1,6 +1,8 @@
 class ApiController < ApplicationController
 
   def map
+    response.headers["Content-Type"] = 'application/xml'
+    # Figure out the bbox
     bbox = params['bbox']
     unless bbox and bbox.count(',') == 3
       render :nothing => true, :status => 400
@@ -9,36 +11,63 @@ class ApiController < ApplicationController
 
     bbox = bbox.split(',')
 
-    min_lat = bbox[0].to_f
-    min_lon = bbox[1].to_f
-    max_lat = bbox[2].to_f
-    max_lon = bbox[3].to_f
+    min_lon = bbox[0].to_f
+    min_lat = bbox[1].to_f
+    max_lon = bbox[2].to_f
+    max_lat = bbox[3].to_f
 
+    # get all the nodes
     nodes = Node.find(:all, :conditions => ['latitude > ? AND longitude > ? AND latitude < ? AND longitude < ? AND visible = 1', min_lat, min_lon, max_lat, max_lon])
 
-    node_ids = "(#{nodes.collect {|node| node.id }})"
+    node_ids = nodes.collect {|node| node.id }
+    segments = Array.new
+    if node_ids.length > 0
+      node_ids_sql = "(#{node_ids.join(',')})"
+      # get the referenced segments
+      segments = Segment.find_by_sql "select * from segments where node_a in #{node_ids_sql} or node_b in #{node_ids_sql}"
+    end
+    # see if we have nay missing nodes
+    segments_nodes = segments.collect {|segment| segment.node_a }
+    segments_nodes += segments.collect {|segment| segment.node_b }
+
+    segments_nodes.uniq!
+
+    missing_nodes = segments_nodes - node_ids
 
-    segments = Segment.find(:all, :condtions => ['node_a in ? or node_b in ?', node_ids, node_ids])
-    render :text => node_ids.join(',')
-    return
+    # get missing nodes if there are any
+    nodes += Node.find(missing_nodes) if missing_nodes.length > 0
 
     doc = XML::Document.new
     doc.encoding = 'UTF-8' 
     root = XML::Node.new 'osm'
-    root['version'] = '0.4'
+    root['version'] = API_VERSION
     root['generator'] = 'OpenStreetMap server'
     doc.root = root
 
+    # get ways
+    # find which ways are needed
+    segment_ids = segments.collect {|segment| segment.id }
+    ways = Array.new
+    if segment_ids.length > 0
+      way_segments = WaySegment.find_by_segment_id(segment_ids)
+      way_ids = way_segments.collect {|way_segment| way_segment.id }
+
+      ways = Way.find(segment_ids)
+    end
+
+    nodes.each do |node|
+      root << node.to_xml_node()
+    end
+
+    segments.each do |segment|
+      root << segment.to_xml_node()
+    end 
+
+    ways.each do |way|
+      root << way.to_xml_node()
+    end 
+
     render :text => doc.to_s
-    
-    #el1 = XML::Node.new 'node'
-    #el1['id'] = self.id.to_s
-    #el1['lat'] = self.latitude.to_s
-    #el1['lon'] = self.longitude.to_s
-    #Node.split_tags(el1, self.tags)
-    #el1['visible'] = self.visible.to_s
-    #el1['timestamp'] = self.timestamp.xmlschema
-    #root << el1
-  end
 
+  end
 end