Fix new rubocop warnings

[rails.git] / app / controllers / users_controller.rb

diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 4b949fe0735b3953f9f9d66bed922c834166190a..7f12720a6efeb8c3110f3bbde92be78efb03f0bf 100644 (file)
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -12,7 +12,7 @@ class UsersController < ApplicationController
   before_action :require_self, :only => [:account]
   before_action :check_database_writable, :only => [:new, :account, :confirm, :confirm_email, :lost_password, :reset_password, :go_public]
   before_action :require_cookies, :only => [:new, :login, :confirm]
   before_action :require_self, :only => [:account]
   before_action :check_database_writable, :only => [:new, :account, :confirm, :confirm_email, :lost_password, :reset_password, :go_public]
   before_action :require_cookies, :only => [:new, :login, :confirm]

-  before_action :lookup_user_by_name, :only => [:set_status, :delete]
+  before_action :lookup_user_by_name, :only => [:set_status, :destroy]

   before_action :allow_thirdparty_images, :only => [:show, :account]
 
   def terms
   before_action :allow_thirdparty_images, :only => [:show, :account]
 
   def terms


@@ -43,7 +43,7 @@ class UsersController < ApplicationController
         flash[:notice] = t("users.new.terms declined", :url => t("users.new.terms declined url")).html_safe if current_user.save
 
         if params[:referer]
         flash[:notice] = t("users.new.terms declined", :url => t("users.new.terms declined url")).html_safe if current_user.save
 
         if params[:referer]

-          redirect_to params[:referer]
+          redirect_to safe_referer(params[:referer])

         else
           redirect_to :action => :account, :display_name => current_user.display_name
         end
         else
           redirect_to :action => :account, :display_name => current_user.display_name
         end


@@ -63,7 +63,7 @@ class UsersController < ApplicationController
       end
 
       if params[:referer]
       end
 
       if params[:referer]

-        redirect_to params[:referer]
+        redirect_to safe_referer(params[:referer])

       else
         redirect_to :action => :account, :display_name => current_user.display_name
       end
       else
         redirect_to :action => :account, :display_name => current_user.display_name
       end


@@ -106,7 +106,7 @@ class UsersController < ApplicationController
             successful_login(current_user)
           else
             session[:token] = current_user.tokens.create.token
             successful_login(current_user)
           else
             session[:token] = current_user.tokens.create.token

-            Notifier.signup_confirm(current_user, current_user.tokens.create(:referer => referer)).deliver_later
+            UserMailer.signup_confirm(current_user, current_user.tokens.create(:referer => referer)).deliver_later

             redirect_to :action => "confirm", :display_name => current_user.display_name
           end
         else
             redirect_to :action => "confirm", :display_name => current_user.display_name
           end
         else


@@ -119,6 +119,10 @@ class UsersController < ApplicationController
   def account
     @tokens = current_user.oauth_tokens.authorized
 
   def account
     @tokens = current_user.oauth_tokens.authorized
 

+    append_content_security_policy_directives(
+      :form_action => %w[accounts.google.com *.facebook.com login.live.com github.com meta.wikimedia.org]
+    )
+

     if params[:user] && params[:user][:display_name] && params[:user][:description]
       if params[:user][:auth_provider].blank? ||
          (params[:user][:auth_provider] == current_user.auth_provider &&
     if params[:user] && params[:user][:display_name] && params[:user][:description]
       if params[:user][:auth_provider].blank? ||
          (params[:user][:auth_provider] == current_user.auth_provider &&


@@ -146,18 +150,18 @@ class UsersController < ApplicationController
   def lost_password
     @title = t "users.lost_password.title"
 
   def lost_password
     @title = t "users.lost_password.title"
 

-    if params[:user] && params[:user][:email]
-      user = User.visible.find_by(:email => params[:user][:email])
+    if params[:email]
+      user = User.visible.find_by(:email => params[:email])

 
       if user.nil?
 
       if user.nil?

-        users = User.visible.where("LOWER(email) = LOWER(?)", params[:user][:email])
+        users = User.visible.where("LOWER(email) = LOWER(?)", params[:email])

 
         user = users.first if users.count == 1
       end
 
       if user
         token = user.tokens.create
 
         user = users.first if users.count == 1
       end
 
       if user
         token = user.tokens.create

-        Notifier.lost_password(user, token).deliver_later
+        UserMailer.lost_password(user, token).deliver_later

         flash[:notice] = t "users.lost_password.notice email on way"
         redirect_to :action => "login"
       else
         flash[:notice] = t "users.lost_password.notice email on way"
         redirect_to :action => "login"
       else


@@ -183,6 +187,7 @@ class UsersController < ApplicationController
 
           if current_user.save
             token.destroy
 
           if current_user.save
             token.destroy

+            session[:fingerprint] = current_user.fingerprint

             flash[:notice] = t "users.reset_password.flash changed"
             successful_login(current_user)
           end
             flash[:notice] = t "users.reset_password.flash changed"
             successful_login(current_user)
           end


@@ -198,7 +203,11 @@ class UsersController < ApplicationController
 
   def new
     @title = t "users.new.title"
 
   def new
     @title = t "users.new.title"

-    @referer = params[:referer] || session[:referer]
+    @referer = if params[:referer]
+                 safe_referer(params[:referer])
+               else
+                 session[:referer]
+               end

 
     append_content_security_policy_directives(
       :form_action => %w[accounts.google.com *.facebook.com login.live.com github.com meta.wikimedia.org]
 
     append_content_security_policy_directives(
       :form_action => %w[accounts.google.com *.facebook.com login.live.com github.com meta.wikimedia.org]


@@ -231,7 +240,9 @@ class UsersController < ApplicationController
     self.current_user = User.new(user_params)
 
     if check_signup_allowed(current_user.email)
     self.current_user = User.new(user_params)
 
     if check_signup_allowed(current_user.email)

-      session[:referer] = params[:referer]
+      session[:referer] = safe_referer(params[:referer]) if params[:referer]
+
+      Rails.logger.info "create: #{session[:referer]}"

 
       current_user.status = "pending"
 
 
       current_user.status = "pending"
 


@@ -258,7 +269,7 @@ class UsersController < ApplicationController
   end
 
   def login
   end
 
   def login

-    session[:referer] = params[:referer] if params[:referer]
+    session[:referer] = safe_referer(params[:referer]) if params[:referer]

 
     if params[:username].present? && params[:password].present?
       session[:remember_me] ||= params[:remember_me]
 
     if params[:username].present? && params[:password].present?
       session[:remember_me] ||= params[:remember_me]


@@ -278,7 +289,7 @@ class UsersController < ApplicationController
       session.delete(:user)
       session_expires_automatically
       if params[:referer]
       session.delete(:user)
       session_expires_automatically
       if params[:referer]

-        redirect_to params[:referer]
+        redirect_to safe_referer(params[:referer])

       else
         redirect_to :controller => "site", :action => "index"
       end
       else
         redirect_to :controller => "site", :action => "index"
       end


@@ -300,7 +311,7 @@ class UsersController < ApplicationController
         user.email_valid = true
         flash[:notice] = gravatar_status_message(user) if gravatar_enable(user)
         user.save!
         user.email_valid = true
         flash[:notice] = gravatar_status_message(user) if gravatar_enable(user)
         user.save!

-        referer = token.referer
+        referer = safe_referer(token.referer) if token.referer

         token.destroy
 
         if session[:token]
         token.destroy
 
         if session[:token]


@@ -317,6 +328,7 @@ class UsersController < ApplicationController
           token.destroy
 
           session[:user] = user.id
           token.destroy
 
           session[:user] = user.id

+          session[:fingerprint] = user.fingerprint

 
           redirect_to referer || welcome_path
         end
 
           redirect_to referer || welcome_path
         end


@@ -335,8 +347,8 @@ class UsersController < ApplicationController
     if user.nil? || token.nil? || token.user != user
       flash[:error] = t "users.confirm_resend.failure", :name => params[:display_name]
     else
     if user.nil? || token.nil? || token.user != user
       flash[:error] = t "users.confirm_resend.failure", :name => params[:display_name]
     else

-      Notifier.signup_confirm(user, user.tokens.create).deliver_later
-      flash[:notice] = t("users.confirm_resend.success", :email => user.email, :sender => Settings.support_email).html_safe
+      UserMailer.signup_confirm(user, user.tokens.create).deliver_later
+      flash[:notice] = t "users.confirm_resend.success_html", :email => user.email, :sender => Settings.support_email

     end
 
     redirect_to :action => "login"
     end
 
     redirect_to :action => "login"


@@ -353,15 +365,16 @@ class UsersController < ApplicationController
         gravatar_enabled = gravatar_enable(current_user)
         if current_user.save
           flash[:notice] = if gravatar_enabled
         gravatar_enabled = gravatar_enable(current_user)
         if current_user.save
           flash[:notice] = if gravatar_enabled

-                             t("users.confirm_email.success") + " " + gravatar_status_message(current_user)
+                             "#{t('users.confirm_email.success')} #{gravatar_status_message(current_user)}"

                            else
                              t("users.confirm_email.success")
                            end
         else
           flash[:errors] = current_user.errors
         end
                            else
                              t("users.confirm_email.success")
                            end
         else
           flash[:errors] = current_user.errors
         end

-        token.destroy
+        current_user.tokens.delete_all

         session[:user] = current_user.id
         session[:user] = current_user.id

+        session[:fingerprint] = current_user.fingerprint

         redirect_to :action => "account", :display_name => current_user.display_name
       elsif token
         flash[:error] = t "users.confirm_email.failure"
         redirect_to :action => "account", :display_name => current_user.display_name
       elsif token
         flash[:error] = t "users.confirm_email.failure"


@@ -393,7 +406,7 @@ class UsersController < ApplicationController
 
   ##
   # delete a user, marking them as deleted and removing personal data
 
   ##
   # delete a user, marking them as deleted and removing personal data

-  def delete
+  def destroy

     @user.delete
     redirect_to user_path(:display_name => params[:display_name])
   end
     @user.delete
     redirect_to user_path(:display_name => params[:display_name])
   end


@@ -488,7 +501,7 @@ class UsersController < ApplicationController
   ##
   # omniauth failure callback
   def auth_failure
   ##
   # omniauth failure callback
   def auth_failure

-    flash[:error] = t("users.auth_failure." + params[:message])
+    flash[:error] = t("users.auth_failure.#{params[:message]}")

     redirect_to params[:origin] || login_url
   end
 
     redirect_to params[:origin] || login_url
   end
 


@@ -518,7 +531,7 @@ class UsersController < ApplicationController
     if referer.nil?
       params[:origin] = request.path
     else
     if referer.nil?
       params[:origin] = request.path
     else

-      params[:origin] = request.path + "?referer=" + CGI.escape(referer)
+      params[:origin] = "#{request.path}?referer=#{CGI.escape(referer)}"

       params[:referer] = referer
     end
 
       params[:referer] = referer
     end
 


@@ -546,6 +559,7 @@ class UsersController < ApplicationController
   # process a successful login
   def successful_login(user, referer = nil)
     session[:user] = user.id
   # process a successful login
   def successful_login(user, referer = nil)
     session[:user] = user.id

+    session[:fingerprint] = user.fingerprint

     session_expires_after 28.days if session[:remember_me]
 
     target = referer || session[:referer] || url_for(:controller => :site, :action => :index)
     session_expires_after 28.days if session[:remember_me]
 
     target = referer || session[:referer] || url_for(:controller => :site, :action => :index)


@@ -610,13 +624,13 @@ class UsersController < ApplicationController
     user.languages = params[:user][:languages].split(",")
 
     case params[:avatar_action]
     user.languages = params[:user][:languages].split(",")
 
     case params[:avatar_action]

-    when "new" then
+    when "new"

       user.avatar.attach(params[:user][:avatar])
       user.image_use_gravatar = false
       user.avatar.attach(params[:user][:avatar])
       user.image_use_gravatar = false

-    when "delete" then
+    when "delete"

       user.avatar.purge_later
       user.image_use_gravatar = false
       user.avatar.purge_later
       user.image_use_gravatar = false

-    when "gravatar" then
+    when "gravatar"

       user.avatar.purge_later
       user.image_use_gravatar = true
     end
       user.avatar.purge_later
       user.image_use_gravatar = true
     end


@@ -636,7 +650,9 @@ class UsersController < ApplicationController
     end
 
     if user.save
     end
 
     if user.save

-      set_locale(true)
+      session[:fingerprint] = user.fingerprint
+
+      set_locale(:reset => true)

 
       if user.new_email.blank? || user.new_email == user.email
         flash.now[:notice] = t "users.account.flash update success"
 
       if user.new_email.blank? || user.new_email == user.email
         flash.now[:notice] = t "users.account.flash update success"


@@ -647,7 +663,7 @@ class UsersController < ApplicationController
           flash.now[:notice] = t "users.account.flash update success confirm needed"
 
           begin
           flash.now[:notice] = t "users.account.flash update success confirm needed"
 
           begin

-            Notifier.email_confirm(user, user.tokens.create).deliver_later
+            UserMailer.email_confirm(user, user.tokens.create).deliver_later

           rescue StandardError
             # Ignore errors sending email
           end
           rescue StandardError
             # Ignore errors sending email
           end