Fix rubocop warning

[rails.git] / lib / rich_text.rb

diff --git a/lib/rich_text.rb b/lib/rich_text.rb
index f2a558e6af8dcc92aae9aa588ce8216edb0ab248..d0539b2b081293e12d68d80b8b1058286c8167d8 100644 (file)
--- a/lib/rich_text.rb
+++ b/lib/rich_text.rb
@@ -1,79 +1,110 @@
 module RichText
 module RichText

+  SPAMMY_PHRASES = [
+    "Business Description:", "Additional Keywords:"
+  ].freeze
+

   def self.new(format, text)
     case format
   def self.new(format, text)
     case format

-    when "html"; HTML.new(text || "")
-    when "markdown"; Markdown.new(text || "")
-    else; nil
+    when "html" then HTML.new(text || "")
+    when "markdown" then Markdown.new(text || "")
+    when "text" then Text.new(text || "")
+    end
+  end
+
+  class SimpleFormat
+    include ActionView::Helpers::TextHelper
+    include ActionView::Helpers::OutputSafetyHelper
+
+    def sanitize(text)
+      Sanitize.clean(text, Sanitize::Config::OSM).html_safe

     end
   end
 
   class Base < String
     end
   end
 
   class Base < String

+    include ActionView::Helpers::TagHelper
+

     def spam_score
       link_count = 0
       link_size = 0
 
       doc = Nokogiri::HTML(to_html)
 
     def spam_score
       link_count = 0
       link_size = 0
 
       doc = Nokogiri::HTML(to_html)
 

-      if doc.content.length > 0
+      if doc.content.empty?
+        link_proportion = 0
+      else

         doc.xpath("//a").each do |link|
           link_count += 1
           link_size += link.content.length
         end
 
         link_proportion = link_size.to_f / doc.content.length.to_f
         doc.xpath("//a").each do |link|
           link_count += 1
           link_size += link.content.length
         end
 
         link_proportion = link_size.to_f / doc.content.length.to_f

-      else
-        link_proportion = 0

       end
 
       end
 

-      return [link_proportion - 0.2, 0.0].max * 200 + link_count * 20
+      spammy_phrases = SPAMMY_PHRASES.count do |phrase|
+        doc.content.include?(phrase)
+      end
+
+      [link_proportion - 0.2, 0.0].max * 200 +
+        link_count * 40 +
+        spammy_phrases * 40
+    end
+
+    protected
+
+    def simple_format(text)
+      SimpleFormat.new.simple_format(text)
+    end
+
+    def linkify(text)
+      if text.html_safe?
+        Rinku.auto_link(text, :urls, tag_builder.tag_options(:rel => "nofollow")).html_safe
+      else
+        Rinku.auto_link(text, :urls, tag_builder.tag_options(:rel => "nofollow"))
+      end

     end
   end
 
   class HTML < Base
     end
   end
 
   class HTML < Base

-    include ActionView::Helpers::TextHelper
-    include ActionView::Helpers::TagHelper
-

     def to_html
       linkify(sanitize(simple_format(self)))
     end
 
     def to_text
     def to_html
       linkify(sanitize(simple_format(self)))
     end
 
     def to_text

-      self
+      to_s

     end
 
     end
 

-  private
+    private

 
     def sanitize(text)
       Sanitize.clean(text, Sanitize::Config::OSM).html_safe
     end
 
     def sanitize(text)
       Sanitize.clean(text, Sanitize::Config::OSM).html_safe
     end

-
-    def linkify(text)
-      if text.html_safe?
-        Rinku.auto_link(text, :urls, tag_options(:rel => "nofollow")).html_safe
-      else
-        Rinku.auto_link(text, :urls, tag_options(:rel => "nofollow"))
-      end
-    end

   end
 
   class Markdown < Base
     def to_html
   end
 
   class Markdown < Base
     def to_html

-      html_parser.render(self).html_safe
+      Markdown.html_parser.render(self).html_safe

     end
 
     def to_text
     end
 
     def to_text

-      self
+      to_s
+    end
+
+    def self.html_renderer
+      @html_renderer ||= Redcarpet::Render::XHTML.new(:filter_html => true, :safe_links_only => true, :link_attributes => { :rel => "nofollow" })
+    end
+
+    def self.html_parser
+      @html_parser ||= Redcarpet::Markdown.new(html_renderer, :no_intra_emphasis => true, :autolink => true, :space_after_headers => true)

     end
     end

+  end

 
 

-  private
+  class Text < Base
+    def to_html
+      linkify(simple_format(ERB::Util.html_escape(self)))
+    end

 
 

-    def html_parser
-      @@html_renderer ||= Redcarpet::Render::XHTML.new({
-        :filter_html => true, :safe_links_only => true
-      })
-      @@html_parser ||= Redcarpet::Markdown.new(@@html_renderer, {
-        :no_intra_emphasis => true, :autolink => true, :space_after_headers => true
-      })
+    def to_text
+      to_s

     end
   end
 end
     end
   end
 end