Use only_path instead of setting an explicit host

[rails.git] / test / controllers / user_controller_test.rb

diff --git a/test/controllers/user_controller_test.rb b/test/controllers/user_controller_test.rb
index a621316965f8dc246a9a75c682d89b121359a751..e309b1662b0d49073d23d552e0231cd937331c83 100644 (file)
--- a/test/controllers/user_controller_test.rb
+++ b/test/controllers/user_controller_test.rb
@@ -2,7 +2,10 @@ require "test_helper"
 
 class UserControllerTest < ActionController::TestCase
   api_fixtures
 
 class UserControllerTest < ActionController::TestCase
   api_fixtures

-  fixtures :messages, :friends
+
+  def setup
+    stub_hostip_requests
+  end

 
   ##
   # test all routes which lead to this controller
 
   ##
   # test all routes which lead to this controller


@@ -393,6 +396,7 @@ class UserControllerTest < ActionController::TestCase
 
   def test_confirm_success_no_token_no_referer
     user = users(:inactive_user)
 
   def test_confirm_success_no_token_no_referer
     user = users(:inactive_user)

+    stub_gravatar_request(user.email)

     confirm_string = user.tokens.create.token
 
     @request.cookies["_osm_session"] = user.display_name
     confirm_string = user.tokens.create.token
 
     @request.cookies["_osm_session"] = user.display_name


@@ -403,6 +407,7 @@ class UserControllerTest < ActionController::TestCase
 
   def test_confirm_success_good_token_no_referer
     user = users(:inactive_user)
 
   def test_confirm_success_good_token_no_referer
     user = users(:inactive_user)

+    stub_gravatar_request(user.email)

     confirm_string = user.tokens.create.token
     token = user.tokens.create.token
 
     confirm_string = user.tokens.create.token
     token = user.tokens.create.token
 


@@ -413,6 +418,7 @@ class UserControllerTest < ActionController::TestCase
 
   def test_confirm_success_bad_token_no_referer
     user = users(:inactive_user)
 
   def test_confirm_success_bad_token_no_referer
     user = users(:inactive_user)

+    stub_gravatar_request(user.email)

     confirm_string = user.tokens.create.token
     token = users(:normal_user).tokens.create.token
 
     confirm_string = user.tokens.create.token
     token = users(:normal_user).tokens.create.token
 


@@ -424,6 +430,7 @@ class UserControllerTest < ActionController::TestCase
 
   def test_confirm_success_no_token_with_referer
     user = users(:inactive_user)
 
   def test_confirm_success_no_token_with_referer
     user = users(:inactive_user)

+    stub_gravatar_request(user.email)

     confirm_string = user.tokens.create(:referer => diary_new_path).token
 
     @request.cookies["_osm_session"] = user.display_name
     confirm_string = user.tokens.create(:referer => diary_new_path).token
 
     @request.cookies["_osm_session"] = user.display_name


@@ -434,6 +441,7 @@ class UserControllerTest < ActionController::TestCase
 
   def test_confirm_success_good_token_with_referer
     user = users(:inactive_user)
 
   def test_confirm_success_good_token_with_referer
     user = users(:inactive_user)

+    stub_gravatar_request(user.email)

     confirm_string = user.tokens.create(:referer => diary_new_path).token
     token = user.tokens.create.token
 
     confirm_string = user.tokens.create(:referer => diary_new_path).token
     token = user.tokens.create.token
 


@@ -444,6 +452,7 @@ class UserControllerTest < ActionController::TestCase
 
   def test_confirm_success_bad_token_with_referer
     user = users(:inactive_user)
 
   def test_confirm_success_bad_token_with_referer
     user = users(:inactive_user)

+    stub_gravatar_request(user.email)

     confirm_string = user.tokens.create(:referer => diary_new_path).token
     token = users(:normal_user).tokens.create.token
 
     confirm_string = user.tokens.create(:referer => diary_new_path).token
     token = users(:normal_user).tokens.create.token
 


@@ -522,7 +531,9 @@ class UserControllerTest < ActionController::TestCase
 
   def test_confirm_email_success
     user = users(:second_public_user)
 
   def test_confirm_email_success
     user = users(:second_public_user)

+    stub_gravatar_request(user.new_email)

     confirm_string = user.tokens.create.token
     confirm_string = user.tokens.create.token

+

     post :confirm_email, :confirm_string => confirm_string
     assert_response :redirect
     assert_redirected_to :action => :account, :display_name => user.display_name
     post :confirm_email, :confirm_string => confirm_string
     assert_response :redirect
     assert_redirected_to :action => :account, :display_name => user.display_name


@@ -551,35 +562,33 @@ class UserControllerTest < ActionController::TestCase
   # this happens when the email is actually changed
   # which is triggered by the confirmation mail
   def test_gravatar_auto_enable
   # this happens when the email is actually changed
   # which is triggered by the confirmation mail
   def test_gravatar_auto_enable

-    with_http_stubs "gravatar" do
-      # switch to email that has a gravatar
-      user = users(:first_gravatar_user)
-      confirm_string = user.tokens.create.token
-      # precondition gravatar should be turned off
-      assert !user.image_use_gravatar
-      post :confirm_email, :confirm_string => confirm_string
-      assert_response :redirect
-      assert_redirected_to :action => :account, :display_name => user.display_name
-      assert_match /Confirmed your change of email address/, flash[:notice]
-      # gravatar use should now be enabled
-      assert User.find(users(:first_gravatar_user).id).image_use_gravatar
-    end
+    # switch to email that has a gravatar
+    user = users(:first_gravatar_user)
+    stub_gravatar_request(user.new_email, 200)
+    confirm_string = user.tokens.create.token
+    # precondition gravatar should be turned off
+    assert !user.image_use_gravatar
+    post :confirm_email, :confirm_string => confirm_string
+    assert_response :redirect
+    assert_redirected_to :action => :account, :display_name => user.display_name
+    assert_match /Confirmed your change of email address/, flash[:notice]
+    # gravatar use should now be enabled
+    assert User.find(users(:first_gravatar_user).id).image_use_gravatar

   end
 
   def test_gravatar_auto_disable
   end
 
   def test_gravatar_auto_disable

-    with_http_stubs "gravatar" do
-      # switch to email without a gravatar
-      user = users(:second_gravatar_user)
-      confirm_string = user.tokens.create.token
-      # precondition gravatar should be turned on
-      assert user.image_use_gravatar
-      post :confirm_email, :confirm_string => confirm_string
-      assert_response :redirect
-      assert_redirected_to :action => :account, :display_name => user.display_name
-      assert_match /Confirmed your change of email address/, flash[:notice]
-      # gravatar use should now be disabled
-      assert !User.find(users(:second_gravatar_user).id).image_use_gravatar
-    end
+    # switch to email without a gravatar
+    user = users(:second_gravatar_user)
+    stub_gravatar_request(user.new_email, 404)
+    confirm_string = user.tokens.create.token
+    # precondition gravatar should be turned on
+    assert user.image_use_gravatar
+    post :confirm_email, :confirm_string => confirm_string
+    assert_response :redirect
+    assert_redirected_to :action => :account, :display_name => user.display_name
+    assert_match /Confirmed your change of email address/, flash[:notice]
+    # gravatar use should now be disabled
+    assert !User.find(users(:second_gravatar_user).id).image_use_gravatar

   end
 
   def test_terms_new_user
   end
 
   def test_terms_new_user


@@ -923,6 +932,7 @@ class UserControllerTest < ActionController::TestCase
     end
 
     # Test a user who has been blocked
     end
 
     # Test a user who has been blocked

+    create(:user_block, :user => users(:blocked_user))

     get :view, :display_name => "blocked"
     assert_response :success
     assert_select "div#userinformation" do
     get :view, :display_name => "blocked"
     assert_response :success
     assert_select "div#userinformation" do


@@ -937,6 +947,7 @@ class UserControllerTest < ActionController::TestCase
     end
 
     # Test a moderator who has applied blocks
     end
 
     # Test a moderator who has applied blocks

+    create(:user_block, :creator => users(:moderator_user))

     get :view, :display_name => "moderator"
     assert_response :success
     assert_select "div#userinformation" do
     get :view, :display_name => "moderator"
     assert_response :success
     assert_select "div#userinformation" do


@@ -1033,6 +1044,8 @@ class UserControllerTest < ActionController::TestCase
   end
 
   def test_api_details
   end
 
   def test_api_details

+    create(:message, :read, :recipient => users(:normal_user))
+

     # check that nothing is returned when not logged in
     get :api_details
     assert_response :unauthorized
     # check that nothing is returned when not logged in
     get :api_details
     assert_response :unauthorized


@@ -1190,6 +1203,7 @@ class UserControllerTest < ActionController::TestCase
     # Get users to work with
     user = users(:normal_user)
     friend = users(:public_user)
     # Get users to work with
     user = users(:normal_user)
     friend = users(:public_user)

+    create(:friend, :befriender => user, :befriendee => friend)

 
     # Check that the users are friends
     assert Friend.where(:user_id => user.id, :friend_user_id => friend.id).first
 
     # Check that the users are friends
     assert Friend.where(:user_id => user.id, :friend_user_id => friend.id).first


@@ -1230,6 +1244,7 @@ class UserControllerTest < ActionController::TestCase
     # Get users to work with
     user = users(:normal_user)
     friend = users(:public_user)
     # Get users to work with
     user = users(:normal_user)
     friend = users(:public_user)

+    create(:friend, :user_id => user.id, :friend_user_id => friend.id)

 
     # Check that the users are friends
     assert Friend.where(:user_id => user.id, :friend_user_id => friend.id).first
 
     # Check that the users are friends
     assert Friend.where(:user_id => user.id, :friend_user_id => friend.id).first