Merge remote-tracking branch 'upstream/pull/4708'

[rails.git] / lib / rich_text.rb

diff --git a/lib/rich_text.rb b/lib/rich_text.rb
index 9c4a24fd54a11c18e7d50d3b65e8b137e768dc24..56d358bd8dcb2823afa64a7dcb56e62f5a40d589 100644 (file)
--- a/lib/rich_text.rb
+++ b/lib/rich_text.rb
@@ -1,94 +1,100 @@
 module RichText
+  SPAMMY_PHRASES = [
+    "Business Description:", "Additional Keywords:"
+  ].freeze
+
   def self.new(format, text)
     case format
-    when "html"; HTML.new(text || "")
-    when "markdown"; Markdown.new(text || "")
-    when "text"; Text.new(text || "")
-    else; nil
+    when "html" then HTML.new(text || "")
+    when "markdown" then Markdown.new(text || "")
+    when "text" then Text.new(text || "")
+    end
+  end
+
+  class SimpleFormat
+    include ActionView::Helpers::TextHelper
+    include ActionView::Helpers::OutputSafetyHelper
+
+    def sanitize(text, _options = {})
+      Sanitize.clean(text, Sanitize::Config::OSM).html_safe
     end
   end
 
   class Base < String
+    include ActionView::Helpers::TagHelper
+
     def spam_score
       link_count = 0
       link_size = 0
 
       doc = Nokogiri::HTML(to_html)
 
-      if doc.content.length > 0
+      if doc.content.empty?
+        link_proportion = 0
+      else
         doc.xpath("//a").each do |link|
           link_count += 1
           link_size += link.content.length
         end
 
-        link_proportion = link_size.to_f / doc.content.length.to_f
-      else
-        link_proportion = 0
+        link_proportion = link_size.to_f / doc.content.length
       end
 
-      return [link_proportion - 0.2, 0.0].max * 200 + link_count * 20
+      spammy_phrases = SPAMMY_PHRASES.count do |phrase|
+        doc.content.include?(phrase)
+      end
+
+      ([link_proportion - 0.2, 0.0].max * 200) +
+        (link_count * 40) +
+        (spammy_phrases * 40)
+    end
+
+    protected
+
+    def simple_format(text)
+      SimpleFormat.new.simple_format(text)
     end
 
-  protected
+    def sanitize(text)
+      Sanitize.clean(text, Sanitize::Config::OSM).html_safe
+    end
 
-    def linkify(text)
+    def linkify(text, mode = :urls)
       if text.html_safe?
-        Rinku.auto_link(text, :urls, tag_options(:rel => "nofollow")).html_safe
+        Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer")).html_safe
       else
-        Rinku.auto_link(text, :urls, tag_options(:rel => "nofollow"))
+        Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer"))
       end
     end
   end
 
   class HTML < Base
-    include ActionView::Helpers::TextHelper
-    include ActionView::Helpers::TagHelper
-
     def to_html
       linkify(sanitize(simple_format(self)))
     end
 
     def to_text
-      self
-    end
-
-  private
-
-    def sanitize(text)
-      Sanitize.clean(text, Sanitize::Config::OSM).html_safe
+      to_s
     end
   end
 
   class Markdown < Base
     def to_html
-      html_parser.render(self).html_safe
+      linkify(sanitize(Kramdown::Document.new(self).to_html), :all)
     end
 
     def to_text
-      self
-    end
-
-  private
-
-    def html_parser
-      @@html_renderer ||= Redcarpet::Render::XHTML.new({
-        :filter_html => true, :safe_links_only => true
-      })
-      @@html_parser ||= Redcarpet::Markdown.new(@@html_renderer, {
-        :no_intra_emphasis => true, :autolink => true, :space_after_headers => true
-      })
+      to_s
     end
   end
 
   class Text < Base
-    include ActionView::Helpers::TextHelper
-
     def to_html
       linkify(simple_format(ERB::Util.html_escape(self)))
     end
 
     def to_text
-      self
+      to_s
     end
   end
 end