fixtures :users, :gpx_files
set_fixture_class :gpx_files => 'Trace'
-
+ ##
+ # test all routes which lead to this controller
+ def test_routes
+ assert_routing(
+ { :path => "/api/0.6/gpx/create", :method => :post },
+ { :controller => "trace", :action => "api_create" }
+ )
+ assert_routing(
+ { :path => "/api/0.6/gpx/1", :method => :get },
+ { :controller => "trace", :action => "api_read", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/api/0.6/gpx/1", :method => :put },
+ { :controller => "trace", :action => "api_update", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/api/0.6/gpx/1", :method => :delete },
+ { :controller => "trace", :action => "api_delete", :id => "1" }
+ )
+ assert_recognizes(
+ { :controller => "trace", :action => "api_read", :id => "1" },
+ { :path => "/api/0.6/gpx/1/details", :method => :get }
+ )
+ assert_routing(
+ { :path => "/api/0.6/gpx/1/data", :method => :get },
+ { :controller => "trace", :action => "api_data", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/api/0.6/gpx/1/data.xml", :method => :get },
+ { :controller => "trace", :action => "api_data", :id => "1", :format => "xml" }
+ )
+
+ assert_routing(
+ { :path => "/traces", :method => :get },
+ { :controller => "trace", :action => "list" }
+ )
+ assert_routing(
+ { :path => "/traces/page/1", :method => :get },
+ { :controller => "trace", :action => "list", :page => "1" }
+ )
+ assert_routing(
+ { :path => "/traces/tag/tagname", :method => :get },
+ { :controller => "trace", :action => "list", :tag => "tagname" }
+ )
+ assert_routing(
+ { :path => "/traces/tag/tagname/page/1", :method => :get },
+ { :controller => "trace", :action => "list", :tag => "tagname", :page => "1" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces", :method => :get },
+ { :controller => "trace", :action => "list", :display_name => "username" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces/page/1", :method => :get },
+ { :controller => "trace", :action => "list", :display_name => "username", :page => "1" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces/tag/tagname", :method => :get },
+ { :controller => "trace", :action => "list", :display_name => "username", :tag => "tagname" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces/tag/tagname/page/1", :method => :get },
+ { :controller => "trace", :action => "list", :display_name => "username", :tag => "tagname", :page => "1" }
+ )
+
+ assert_routing(
+ { :path => "/traces/mine", :method => :get },
+ { :controller => "trace", :action => "mine" }
+ )
+ assert_routing(
+ { :path => "/traces/mine/page/1", :method => :get },
+ { :controller => "trace", :action => "mine", :page => "1" }
+ )
+ assert_routing(
+ { :path => "/traces/mine/tag/tagname", :method => :get },
+ { :controller => "trace", :action => "mine", :tag => "tagname" }
+ )
+ assert_routing(
+ { :path => "/traces/mine/tag/tagname/page/1", :method => :get },
+ { :controller => "trace", :action => "mine", :tag => "tagname", :page => "1" }
+ )
+
+ assert_routing(
+ { :path => "/traces/rss", :method => :get },
+ { :controller => "trace", :action => "georss" }
+ )
+ assert_routing(
+ { :path => "/traces/tag/tagname/rss", :method => :get },
+ { :controller => "trace", :action => "georss", :tag => "tagname" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces/rss", :method => :get },
+ { :controller => "trace", :action => "georss", :display_name => "username" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces/tag/tagname/rss", :method => :get },
+ { :controller => "trace", :action => "georss", :display_name => "username", :tag => "tagname" }
+ )
+
+ assert_routing(
+ { :path => "/user/username/traces/1", :method => :get },
+ { :controller => "trace", :action => "view", :display_name => "username", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces/1/picture", :method => :get },
+ { :controller => "trace", :action => "picture", :display_name => "username", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/user/username/traces/1/icon", :method => :get },
+ { :controller => "trace", :action => "icon", :display_name => "username", :id => "1" }
+ )
+
+ assert_routing(
+ { :path => "/trace/create", :method => :get },
+ { :controller => "trace", :action => "create" }
+ )
+ assert_routing(
+ { :path => "/trace/create", :method => :post },
+ { :controller => "trace", :action => "create" }
+ )
+ assert_routing(
+ { :path => "/trace/1/data", :method => :get },
+ { :controller => "trace", :action => "data", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/trace/1/data.xml", :method => :get },
+ { :controller => "trace", :action => "data", :id => "1", :format => "xml" }
+ )
+ assert_routing(
+ { :path => "/trace/1/edit", :method => :get },
+ { :controller => "trace", :action => "edit", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/trace/1/edit", :method => :post },
+ { :controller => "trace", :action => "edit", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/trace/1/edit", :method => :put },
+ { :controller => "trace", :action => "edit", :id => "1" }
+ )
+ assert_routing(
+ { :path => "/trace/1/delete", :method => :post },
+ { :controller => "trace", :action => "delete", :id => "1" }
+ )
+ end
+
# Check that the list of changesets is displayed
def test_list
get :list
assert_response :success
- assert_template 'list'
+ assert_template "list"
+ check_trace_list Trace.public
end
-
+
# Check that I can get mine
def test_list_mine
+ @request.cookies["_osm_username"] = users(:public_user).display_name
+
# First try to get it when not logged in
get :mine
assert_redirected_to :controller => 'user', :action => 'login', :referer => '/traces/mine'
-
+
# Now try when logged in
get :mine, {}, {:user => users(:public_user).id}
+ assert_redirected_to :controller => 'trace', :action => 'list', :display_name => users(:public_user).display_name
+
+ # Fetch the actual list
+ get :list, {:display_name => users(:public_user).display_name}, {:user => users(:public_user).id}
assert_response :success
- assert_template 'mine'
- # Should really test to see which files are shown to the user
+ assert_template "list"
+ check_trace_list users(:public_user).traces
end
-
+
+ # Check the list of changesets for a specific user
+ def test_list_user
+ # Test a user with no traces
+ get :list, :display_name => users(:second_public_user).display_name
+ assert_response :success
+ assert_template "list"
+ check_trace_list users(:second_public_user).traces.public
+
+ # Test a user with some traces - should see only public ones
+ get :list, :display_name => users(:public_user).display_name
+ assert_response :success
+ assert_template "list"
+ check_trace_list users(:public_user).traces.public
+
+ @request.cookies["_osm_username"] = users(:normal_user).display_name
+
+ # Should still see only public ones when authenticated as another user
+ get :list, {:display_name => users(:public_user).display_name}, {:user => users(:normal_user).id}
+ assert_response :success
+ assert_template "list"
+ check_trace_list users(:public_user).traces.public
+
+ @request.cookies["_osm_username"] = users(:public_user).display_name
+
+ # Should see all traces when authenticated as the target user
+ get :list, {:display_name => users(:public_user).display_name}, {:user => users(:public_user).id}
+ assert_response :success
+ assert_template "list"
+ check_trace_list users(:public_user).traces
+ end
+
# Check that the rss loads
def test_rss
get :georss
assert_rss_success
-
+
get :georss, :display_name => users(:normal_user).display_name
assert_rss_success
end
-
- def assert_rss_success
+
+ def assert_rss_success
assert_response :success
assert_template nil
assert_equal "application/rss+xml", @response.content_type
end
-
+
# Check getting a specific trace through the api
- def test_api_details
+ def test_api_read
# First with no auth
- get :api_details, :id => gpx_files(:public_trace_file).id
+ get :api_read, :id => gpx_files(:public_trace_file).id
assert_response :unauthorized
-
+
# Now with some other user, which should work since the trace is public
basic_authorization(users(:public_user).display_name, "test")
- get :api_details, :id => gpx_files(:public_trace_file).id
+ get :api_read, :id => gpx_files(:public_trace_file).id
assert_response :success
-
+
# And finally we should be able to do it with the owner of the trace
basic_authorization(users(:normal_user).display_name, "test")
- get :api_details, :id => gpx_files(:public_trace_file).id
+ get :api_read, :id => gpx_files(:public_trace_file).id
assert_response :success
end
-
+
# Check an anoymous trace can't be specifically fetched by another user
- def test_api_details_anon
+ def test_api_read_anon
# Furst with no auth
- get :api_details, :id => gpx_files(:anon_trace_file).id
+ get :api_read, :id => gpx_files(:anon_trace_file).id
assert_response :unauthorized
-
+
# Now try with another user, which shouldn't work since the trace is anon
basic_authorization(users(:normal_user).display_name, "test")
- get :api_details, :id => gpx_files(:anon_trace_file).id
+ get :api_read, :id => gpx_files(:anon_trace_file).id
assert_response :forbidden
-
+
# And finally we should be able to get the trace details with the trace owner
basic_authorization(users(:public_user).display_name, "test")
- get :api_details, :id => gpx_files(:anon_trace_file).id
+ get :api_read, :id => gpx_files(:anon_trace_file).id
assert_response :success
end
-
+
# Check the api details for a trace that doesn't exist
- def test_api_details_not_found
+ def test_api_read_not_found
# Try first with no auth, as it should requure it
- get :api_details, :id => 0
+ get :api_read, :id => 0
assert_response :unauthorized
-
+
# Login, and try again
basic_authorization(users(:public_user).display_name, "test")
- get :api_details, :id => 0
+ get :api_read, :id => 0
+ assert_response :not_found
+
+ # Now try a trace which did exist but has been deleted
+ basic_authorization(users(:public_user).display_name, "test")
+ get :api_read, :id => 5
assert_response :not_found
end
+
+ # Check updating a trace through the api
+ def test_api_update
+ # First with no auth
+ content gpx_files(:public_trace_file).to_xml
+ put :api_update, :id => gpx_files(:public_trace_file).id
+ assert_response :unauthorized
+
+ # Now with some other user, which should fail
+ basic_authorization(users(:public_user).display_name, "test")
+ content gpx_files(:public_trace_file).to_xml
+ put :api_update, :id => gpx_files(:public_trace_file).id
+ assert_response :forbidden
+
+ # Now with a trace which doesn't exist
+ basic_authorization(users(:public_user).display_name, "test")
+ content gpx_files(:public_trace_file).to_xml
+ put :api_update, :id => 0
+ assert_response :not_found
+
+ # Now with a trace which did exist but has been deleted
+ basic_authorization(users(:public_user).display_name, "test")
+ content gpx_files(:deleted_trace_file).to_xml
+ put :api_update, :id => gpx_files(:deleted_trace_file).id
+ assert_response :not_found
+
+ # Now try an update with the wrong ID
+ basic_authorization(users(:normal_user).display_name, "test")
+ content gpx_files(:anon_trace_file).to_xml
+ put :api_update, :id => gpx_files(:public_trace_file).id
+ assert_response :bad_request,
+ "should not be able to update a trace with a different ID from the XML"
+
+ # And finally try an update that should work
+ basic_authorization(users(:normal_user).display_name, "test")
+ t = gpx_files(:public_trace_file)
+ t.description = "Changed description"
+ t.visibility = "private"
+ content t.to_xml
+ put :api_update, :id => t.id
+ assert_response :success
+ nt = Trace.find(t.id)
+ assert_equal nt.description, t.description
+ assert_equal nt.visibility, t.visibility
+ end
+
+ # Check deleting a trace through the api
+ def test_api_delete
+ # First with no auth
+ delete :api_delete, :id => gpx_files(:public_trace_file).id
+ assert_response :unauthorized
+
+ # Now with some other user, which should fail
+ basic_authorization(users(:public_user).display_name, "test")
+ delete :api_delete, :id => gpx_files(:public_trace_file).id
+ assert_response :forbidden
+
+ # Now with a trace which doesn't exist
+ basic_authorization(users(:public_user).display_name, "test")
+ delete :api_delete, :id => 0
+ assert_response :not_found
+
+ # And finally we should be able to do it with the owner of the trace
+ basic_authorization(users(:normal_user).display_name, "test")
+ delete :api_delete, :id => gpx_files(:public_trace_file).id
+ assert_response :success
+
+ # Try it a second time, which should fail
+ basic_authorization(users(:normal_user).display_name, "test")
+ delete :api_delete, :id => gpx_files(:public_trace_file).id
+ assert_response :not_found
+ end
+
+private
+
+ def check_trace_list(traces)
+ traces = traces.visible.order("timestamp DESC")
+
+ if traces.count > 0
+ assert_select "table#trace_list tbody", :count => 1 do
+ assert_select "tr", :count => traces.count do |rows|
+ traces.zip(rows).each do |trace,row|
+ assert_select row, "span.trace_summary", Regexp.new(Regexp.escape("(#{trace.size} points)"))
+ assert_select row, "td", Regexp.new(Regexp.escape(trace.description))
+ assert_select row, "td", Regexp.new(Regexp.escape("by #{trace.user.display_name}"))
+ end
+ end
+ end
+ else
+ assert_select "h4", /Nothing here yet/
+ end
+ end
end