Merge remote-tracking branch 'upstream/pull/3124'

[rails.git] / test / integration / user_blocks_test.rb

diff --git a/test/integration/user_blocks_test.rb b/test/integration/user_blocks_test.rb
index 9425c690f38125804aafde1c2082af9bf2557158..ecadaad534f8a0d732114d860a73d1110a4fd2c5 100644 (file)
--- a/test/integration/user_blocks_test.rb
+++ b/test/integration/user_blocks_test.rb
@@ -1,35 +1,29 @@
 require "test_helper"
 
 class UserBlocksTest < ActionDispatch::IntegrationTest
 require "test_helper"
 
 class UserBlocksTest < ActionDispatch::IntegrationTest

-  fixtures :users, :user_roles
-
-  def auth_header(user, pass)
-    { "HTTP_AUTHORIZATION" => format("Basic %s", Base64.encode64("#{user}:#{pass}")) }
-  end
-

   def test_api_blocked
   def test_api_blocked

-    blocked_user = users(:public_user)
+    blocked_user = create(:user)

 
 

-    get "/api/#{API_VERSION}/user/details"
+    get "/api/#{Settings.api_version}/user/details"

     assert_response :unauthorized
 
     assert_response :unauthorized
 

-    get "/api/#{API_VERSION}/user/details", nil, auth_header(blocked_user.display_name, "test")
+    get "/api/#{Settings.api_version}/user/details", :headers => basic_authorization_header(blocked_user.display_name, "test")

     assert_response :success
 
     # now block the user
     UserBlock.create(
       :user_id => blocked_user.id,
     assert_response :success
 
     # now block the user
     UserBlock.create(
       :user_id => blocked_user.id,

-      :creator_id => users(:moderator_user).id,
+      :creator_id => create(:moderator_user).id,

       :reason => "testing",
       :ends_at => Time.now.getutc + 5.minutes
     )
       :reason => "testing",
       :ends_at => Time.now.getutc + 5.minutes
     )

-    get "/api/#{API_VERSION}/user/details", nil, auth_header(blocked_user.display_name, "test")
+    get "/api/#{Settings.api_version}/user/details", :headers => basic_authorization_header(blocked_user.display_name, "test")

     assert_response :forbidden
   end
 
   def test_api_revoke
     assert_response :forbidden
   end
 
   def test_api_revoke

-    blocked_user = users(:public_user)
-    moderator = users(:moderator_user)
+    blocked_user = create(:user)
+    moderator = create(:moderator_user)

 
     block = UserBlock.create(
       :user_id => blocked_user.id,
 
     block = UserBlock.create(
       :user_id => blocked_user.id,


@@ -37,18 +31,18 @@ class UserBlocksTest < ActionDispatch::IntegrationTest
       :reason => "testing",
       :ends_at => Time.now.getutc + 5.minutes
     )
       :reason => "testing",
       :ends_at => Time.now.getutc + 5.minutes
     )

-    get "/api/#{API_VERSION}/user/details", nil, auth_header(blocked_user.display_name, "test")
+    get "/api/#{Settings.api_version}/user/details", :headers => basic_authorization_header(blocked_user.display_name, "test")

     assert_response :forbidden
 
     # revoke the ban
     get "/login"
     assert_response :success
     assert_response :forbidden
 
     # revoke the ban
     get "/login"
     assert_response :success

-    post "/login", "username" => moderator.email, "password" => "test", :referer => "/blocks/#{block.id}/revoke"
+    post "/login", :params => { "username" => moderator.email, "password" => "test", :referer => "/blocks/#{block.id}/revoke" }

     assert_response :redirect
     follow_redirect!
     assert_response :success
     assert_template "user_blocks/revoke"
     assert_response :redirect
     follow_redirect!
     assert_response :success
     assert_template "user_blocks/revoke"

-    post "/blocks/#{block.id}/revoke", "confirm" => "yes"
+    post "/blocks/#{block.id}/revoke", :params => { "confirm" => "yes" }

     assert_response :redirect
     follow_redirect!
     assert_response :success
     assert_response :redirect
     follow_redirect!
     assert_response :success


@@ -56,7 +50,7 @@ class UserBlocksTest < ActionDispatch::IntegrationTest
     reset!
 
     # access the API again. this time it should work
     reset!
 
     # access the API again. this time it should work

-    get "/api/#{API_VERSION}/user/details", nil, auth_header(blocked_user.display_name, "test")
+    get "/api/#{Settings.api_version}/user/details", :headers => basic_authorization_header(blocked_user.display_name, "test")

     assert_response :success
   end
 end
     assert_response :success
   end
 end