minor changes

[rails.git] / app / controllers / node_controller.rb

diff --git a/app/controllers/node_controller.rb b/app/controllers/node_controller.rb
index fba41e3305dc16c59eec00561027f09441a9f983..edc3675e58382fce0b8b5801a2e7180ab280cec2 100644 (file)
--- a/app/controllers/node_controller.rb
+++ b/app/controllers/node_controller.rb
@@ -1,10 +1,15 @@
+# The NodeController is the RESTful interface to Node objects
+

 class NodeController < ApplicationController
   require 'xml/libxml'
 
 class NodeController < ApplicationController
   require 'xml/libxml'
 

+  session :off

   before_filter :authorize, :only => [:create, :update, :delete]
   before_filter :authorize, :only => [:create, :update, :delete]

-  before_filter :check_availability, :only => [:create, :update, :delete]
+  before_filter :check_write_availability, :only => [:create, :update, :delete]
+  before_filter :check_read_availability, :except => [:create, :update, :delete]

   after_filter :compress_output
 
   after_filter :compress_output
 

+  # Create a node from XML.

   def create
     if request.put?
       node = Node.from_xml(request.raw_post, true)
   def create
     if request.put?
       node = Node.from_xml(request.raw_post, true)


@@ -12,12 +17,9 @@ class NodeController < ApplicationController
       if node
         node.user_id = @user.id
         node.visible = true
       if node
         node.user_id = @user.id
         node.visible = true

+        node.save_with_history!

 
 

-        if node.save_with_history
-          render :text => node.id.to_s, :content_type => "text/plain"
-        else
-          render :nothing => true, :status => :internal_server_error
-        end
+        render :text => node.id.to_s, :content_type => "text/plain"

       else
         render :nothing => true, :status => :bad_request
       end
       else
         render :nothing => true, :status => :bad_request
       end


@@ -26,76 +28,71 @@ class NodeController < ApplicationController
     end
   end
 
     end
   end
 

+  # Dump the details on a node given in params[:id]

   def read
     begin
       node = Node.find(params[:id])
   def read
     begin
       node = Node.find(params[:id])

-

       if node.visible
       if node.visible

+        response.headers['Last-Modified'] = node.timestamp.rfc822

         render :text => node.to_xml.to_s, :content_type => "text/xml"
        else
         render :text => node.to_xml.to_s, :content_type => "text/xml"
        else

-        render :nothing => true, :status => :gone
+        render :text => "", :status => :gone

       end
     rescue ActiveRecord::RecordNotFound
       render :nothing => true, :status => :not_found
       end
     rescue ActiveRecord::RecordNotFound
       render :nothing => true, :status => :not_found

-    rescue
-      render :nothing => true, :status => :internal_server_error

     end
   end
 
     end
   end
 

+  # Update a node from given XML

   def update
     begin
       node = Node.find(params[:id])
   def update
     begin
       node = Node.find(params[:id])

+      new_node = Node.from_xml(request.raw_post)

 
 

-      if node.visible
-        new_node = Node.from_xml(request.raw_post)
+      if new_node and new_node.id == node.id
+        node.user_id = @user.id
+        node.latitude = new_node.latitude 
+        node.longitude = new_node.longitude
+        node.tags = new_node.tags
+        node.visible = true
+        node.save_with_history!

 
 

-        if new_node and new_node.id == node.id
-          node.user_id = @user.id
-          node.latitude = new_node.latitude 
-          node.longitude = new_node.longitude
-          node.tags = new_node.tags
-
-          if node.save_with_history
-            render :nothing => true
-          else
-            render :nothing => true, :status => :internal_server_error
-          end
-        else
-          render :nothing => true, :status => :bad_request
-        end
+        render :nothing => true

       else
       else

-        render :nothing => true, :status => :gone
+        render :nothing => true, :status => :bad_request

       end
     rescue ActiveRecord::RecordNotFound
       render :nothing => true, :status => :not_found
       end
     rescue ActiveRecord::RecordNotFound
       render :nothing => true, :status => :not_found

-    rescue
-      render :nothing => true, :status => :internal_server_error

     end
   end
 
     end
   end
 

+  # Delete a node. Doesn't actually delete it, but retains its history in a wiki-like way.
+  # FIXME remove all the fricking SQL

   def delete
     begin
       node = Node.find(params[:id])
 
       if node.visible
   def delete
     begin
       node = Node.find(params[:id])
 
       if node.visible

-        if Segment.find(:first, :conditions => [ "visible = 1 and (node_a = ? or node_b = ?)", node.id, node.id])
-          render :nothing => true, :status => :precondition_failed
+        if WayNode.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_nodes.id", :conditions => [ "current_ways.visible = 1 AND current_way_nodes.node_id = ?", node.id ])
+          render :text => "", :status => :precondition_failed
+        elsif RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", :conditions => [ "visible = 1 AND member_type='node' and member_id=?", params[:id]])
+          render :text => "", :status => :precondition_failed

         else
           node.user_id = @user.id
           node.visible = 0
         else
           node.user_id = @user.id
           node.visible = 0

-          node.save_with_history
+          node.save_with_history!
+

           render :nothing => true
         end
       else
           render :nothing => true
         end
       else

-        render :nothing => true, :status => :gone
+        render :text => "", :status => :gone

       end
     rescue ActiveRecord::RecordNotFound
       render :nothing => true, :status => :not_found
       end
     rescue ActiveRecord::RecordNotFound
       render :nothing => true, :status => :not_found

-    rescue
-      render :nothing => true, :status => :internal_server_error

     end
   end
 
     end
   end
 

+  # WTF does this do?

   def nodes
     ids = params['nodes'].split(',').collect { |n| n.to_i }
 
   def nodes
     ids = params['nodes'].split(',').collect { |n| n.to_i }