Remove nowrap on footer text, to accommodate narrow screens

[rails.git] / app / controllers / way_controller.rb

diff --git a/app/controllers/way_controller.rb b/app/controllers/way_controller.rb
index dd9b65fd87de89316119f6e0592a212342020bad..c988545c717a00c7258a06c049f6e14ad83379b9 100644 (file)
--- a/app/controllers/way_controller.rb
+++ b/app/controllers/way_controller.rb
@@ -14,12 +14,9 @@ class WayController < ApplicationController
 
     way = Way.from_xml(request.raw_post, true)
 
 
     way = Way.from_xml(request.raw_post, true)
 

-    if way
-      way.create_with_history @user
-      render :text => way.id.to_s, :content_type => "text/plain"
-    else
-      render :text => "", :status => :bad_request
-    end
+    # Assume that Way.from_xml has thrown an exception if there is an error parsing the xml
+    way.create_with_history @user
+    render :text => way.id.to_s, :content_type => "text/plain"

   end
 
   def read
   end
 
   def read


@@ -38,12 +35,12 @@ class WayController < ApplicationController
     way = Way.find(params[:id])
     new_way = Way.from_xml(request.raw_post)
 
     way = Way.find(params[:id])
     new_way = Way.from_xml(request.raw_post)
 

-    if new_way && new_way.id == way.id
-      way.update_from(new_way, @user)
-      render :text => way.version.to_s, :content_type => "text/plain"
-    else
-      render :text => "", :status => :bad_request
+    unless new_way && new_way.id == way.id
+      raise OSM::APIBadUserInput.new("The id in the url (#{way.id}) is not the same as provided in the xml (#{new_way.id})")

     end
     end

+
+    way.update_from(new_way, @user)
+    render :text => way.version.to_s, :content_type => "text/plain"

   end
 
   # This is the API call to delete a way
   end
 
   # This is the API call to delete a way


@@ -84,13 +81,13 @@ class WayController < ApplicationController
 
   def ways
     unless params["ways"]
 
   def ways
     unless params["ways"]

-      fail OSM::APIBadUserInput.new("The parameter ways is required, and must be of the form ways=id[,id[,id...]]")
+      raise OSM::APIBadUserInput.new("The parameter ways is required, and must be of the form ways=id[,id[,id...]]")

     end
 
     ids = params["ways"].split(",").collect(&:to_i)
 
     end
 
     ids = params["ways"].split(",").collect(&:to_i)
 

-    if ids.length == 0
-      fail OSM::APIBadUserInput.new("No ways were given to search for")
+    if ids.empty?
+      raise OSM::APIBadUserInput.new("No ways were given to search for")

     end
 
     doc = OSM::API.new.get_xml_doc
     end
 
     doc = OSM::API.new.get_xml_doc