Fully internationalise the issues and reports interfaces.

[rails.git] / test / controllers / issues_controller_test.rb

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index c57ee53a3aeba4c6718a73e213b8810ec9473f25..ff99b0cdcef37af48b6ab54ae8e13698efbda296 100644 (file)
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -21,143 +21,12 @@ class IssuesControllerTest < ActionController::TestCase
     # Access issues_path by admin
     session[:user] = create(:administrator_user).id
     get :index
     # Access issues_path by admin
     session[:user] = create(:administrator_user).id
     get :index

-    # this is redirected because there are no issues?!
-    assert_response :redirect
-    assert_redirected_to issues_path
+    assert_response :success

 
     # Access issues_path by moderator
     session[:user] = create(:moderator_user).id
     get :index
 
     # Access issues_path by moderator
     session[:user] = create(:moderator_user).id
     get :index

-    # this is redirected because there are no issues?!
-    assert_response :redirect
-    assert_redirected_to issues_path
-  end
-
-  def test_new_issue_without_login
-    # Test creation of a new issue and a new report without logging in
-    get :new, :params => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 1 }
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => new_issue_path(:reportable_id => 1, :reportable_type => "User", :reported_user_id => 1))
-  end
-
-  def test_new_issue_after_login
-    # Test creation of a new issue and a new report
-    target_user = create(:user)
-
-    # Login
-    session[:user] = create(:user).id
-
-    assert_equal Issue.count, 0
-
-    # Create an Issue and a report
-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-    assert_response :success
-    assert_difference "Issue.count", 1 do
-      details = "Details of a report"
-      post :create,
-           :params => {
-             :report => { :details => details },
-             :report_type => "[OFFENSIVE]",
-             :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-           }
-    end
-    assert_equal Issue.count, 1
-    assert_response :redirect
-    assert_redirected_to root_path
-  end
-
-  def test_new_report_with_incomplete_details
-    # Test creation of a new issue and a new report
-    target_user = create(:user)
-
-    # Login
-    session[:user] = create(:user).id
-
-    assert_equal Issue.count, 0
-
-    # Create an Issue and a report
-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-    assert_response :success
-    assert_difference "Issue.count", 1 do
-      details = "Details of a report"
-      post :create,
-           :params => {
-             :report => { :details => details },
-             :report_type => "[OFFENSIVE]",
-             :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-           }
-    end
-    assert_equal Issue.count, 1
-    assert_response :redirect
-    assert_redirected_to root_path
-
-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }

     assert_response :success
     assert_response :success

-
-    # Report without report_type
-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create,
-           :params => {
-             :report => { :details => details },
-             :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-           }
-    end
-    assert_response :redirect
-    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1
-
-    # Report without details
-    assert_no_difference "Issue.count" do
-      post :create,
-           :params => {
-             :report_type => "[OFFENSIVE]",
-             :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
-           }
-    end
-    assert_response :redirect
-    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1
-  end
-
-  def test_new_report_with_complete_details
-    # Test creation of a new issue and a new report
-    target_user = create(:user)
-
-    # Login
-    session[:user] = create(:user).id
-
-    assert_equal Issue.count, 0
-
-    # Create an Issue and a report
-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-    assert_response :success
-    assert_difference "Issue.count", 1 do
-      details = "Details of a report"
-      post :create,
-           :params => {
-             :report => { :details => details },
-             :report_type => "[OFFENSIVE]",
-             :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-           }
-    end
-    assert_equal Issue.count, 1
-    assert_response :redirect
-    assert_redirected_to root_path
-
-    # Create a report for an existing Issue
-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-    assert_response :success
-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create,
-           :params => {
-             :report => { :details => details },
-             :report_type => "[OFFENSIVE]",
-             :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
-           }
-    end
-    assert_response :redirect
-    report_count = Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count
-    assert_equal report_count, 2

   end
 
   def test_change_status_by_normal_user
   end
 
   def test_change_status_by_normal_user


@@ -167,7 +36,7 @@ class IssuesControllerTest < ActionController::TestCase
     # Login as normal user
     session[:user] = create(:user).id
 
     # Login as normal user
     session[:user] = create(:user).id
 

-    assert_equal Issue.count, 1
+    assert_equal 1, Issue.count

 
     get :resolve, :params => { :id => issue.id }
 
 
     get :resolve, :params => { :id => issue.id }
 


@@ -184,39 +53,17 @@ class IssuesControllerTest < ActionController::TestCase
 
     # Test 'Resolved'
     get :resolve, :params => { :id => issue.id }
 
     # Test 'Resolved'
     get :resolve, :params => { :id => issue.id }

-    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").resolved?, true
+    assert_equal true, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").resolved?

     assert_response :redirect
 
     # Test 'Reopen'
     get :reopen, :params => { :id => issue.id }
     assert_response :redirect
 
     # Test 'Reopen'
     get :reopen, :params => { :id => issue.id }

-    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").open?, true
+    assert_equal true, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").open?

     assert_response :redirect
 
     # Test 'Ignored'
     get :ignore, :params => { :id => issue.id }
     assert_response :redirect
 
     # Test 'Ignored'
     get :ignore, :params => { :id => issue.id }

-    assert_equal Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored?, true
+    assert_equal true, Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored?

     assert_response :redirect
   end
     assert_response :redirect
   end

-
-  def test_search_issues
-    good_user = create(:user)
-    bad_user = create(:user)
-    create(:issue, :reportable => bad_user, :reported_user => bad_user, :issue_type => "administrator")
-    # Login as administrator
-    session[:user] = create(:administrator_user).id
-
-    # No issues against the user
-    get :index, :params => { :search_by_user => good_user.display_name }
-    assert_response :redirect
-    assert_redirected_to issues_path
-
-    # User doesn't exist
-    get :index, :params => { :search_by_user => "test1000" }
-    assert_response :redirect
-    assert_redirected_to issues_path
-
-    # Find Issue against bad_user
-    get :index, :params => { :search_by_user => bad_user.display_name }
-    assert_response :success
-  end

 end
 end