Refactor the relation_for_nwr tests to use factories

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a83e74d27d34e0765b657e79c428bd528e2d84f1..5b6145de38155e394684f4ea44da11ad7b957123 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,120 +1,216 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-02-16 19:20:52 +0000 using RuboCop version 0.29.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-10-20 21:45:27 +0100 using RuboCop version 0.44.1.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 

-# Offense count: 13
+# Offense count: 34

 Lint/AmbiguousOperator:
 Lint/AmbiguousOperator:

-  Enabled: false
+  Exclude:
+    - 'test/controllers/amf_controller_test.rb'
+    - 'test/controllers/changeset_controller_test.rb'
+    - 'test/lib/bounding_box_test.rb'
+    - 'test/lib/country_test.rb'

 
 

-# Offense count: 110
+# Offense count: 117

 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 

-# Offense count: 29
+# Offense count: 30

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:

-  Enabled: false
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/geocoder_controller.rb'
+    - 'app/controllers/notes_controller.rb'
+    - 'app/controllers/trace_controller.rb'
+    - 'app/controllers/user_controller.rb'
+    - 'app/controllers/user_preference_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/browse_helper.rb'
+    - 'app/models/client_application.rb'
+    - 'app/models/notifier.rb'
+    - 'lib/nominatim.rb'
+    - 'lib/osm.rb'
+    - 'script/deliver-message'

 
 # Offense count: 5
 Lint/HandleExceptions:
 
 # Offense count: 5
 Lint/HandleExceptions:

-  Enabled: false
+  Exclude:
+    - 'app/controllers/amf_controller.rb'
+    - 'app/controllers/user_controller.rb'
+    - 'config/initializers/session.rb'

 
 

-# Offense count: 8
-Lint/ParenthesesAsGroupedExpression:
-  Enabled: false
+# Offense count: 2
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'app/views/changeset/list.atom.builder'

 
 

-# Offense count: 546
+# Offense count: 630

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 194
+  Max: 280
+
+# Offense count: 35
+# Configuration parameters: CountComments.
+Metrics/BlockLength:
+  Max: 295

 
 # Offense count: 12
 Metrics/BlockNesting:
   Max: 5
 
 
 # Offense count: 12
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 60
+# Offense count: 62

 # Configuration parameters: CountComments.
 Metrics/ClassLength:
 # Configuration parameters: CountComments.
 Metrics/ClassLength:

-  Max: 1515
+  Max: 1665

 
 

-# Offense count: 68
+# Offense count: 69

 Metrics/CyclomaticComplexity:
 Metrics/CyclomaticComplexity:

-  Max: 21
+  Max: 20

 
 

-# Offense count: 2112
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 2826
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives.
+# URISchemes: http, https

 Metrics/LineLength:
 Metrics/LineLength:

-  Max: 520
+  Max: 1072

 
 

-# Offense count: 520
+# Offense count: 612

 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 179
 
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 179
 

+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 147
+

 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 

-# Offense count: 70
+# Offense count: 71

 Metrics/PerceivedComplexity:
 Metrics/PerceivedComplexity:

-  Max: 24
+  Max: 23
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
+Rails/Exit:
+  Exclude:
+    - 'lib/**/*.rake'
+    - 'lib/daemons/gpx_import.rb'
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/HasAndBelongsToMany:
+  Exclude:
+    - 'app/models/changeset.rb'
+    - 'app/models/user.rb'

 
 # Offense count: 5
 
 # Offense count: 5

-Style/AccessorMethodName:
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/NotNullColumn:
+  Exclude:
+    - 'db/migrate/002_cleanup_osm_db.rb'
+    - 'db/migrate/020_populate_node_tags_and_remove.rb'
+    - 'db/migrate/021_move_to_innodb.rb'
+    - 'db/migrate/025_add_end_time_to_changesets.rb'
+    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+
+# Offense count: 17
+Rails/OutputSafety:
+  Exclude:
+    - 'app/controllers/user_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/changeset_helper.rb'
+    - 'app/helpers/geocoder_helper.rb'
+    - 'app/helpers/note_helper.rb'
+    - 'app/helpers/open_graph_helper.rb'
+    - 'app/helpers/user_blocks_helper.rb'
+    - 'app/helpers/user_roles_helper.rb'
+    - 'lib/rich_text.rb'
+    - 'test/helpers/application_helper_test.rb'
+
+# Offense count: 74
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:

   Enabled: false
 
   Enabled: false
 

+# Offense count: 5
+Style/AccessorMethodName:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/helpers/title_helper.rb'
+    - 'app/models/old_way.rb'
+    - 'lib/osm.rb'
+    - 'lib/potlatch.rb'
+

 # Offense count: 1
 Style/AsciiComments:
 # Offense count: 1
 Style/AsciiComments:

-  Enabled: false
+  Exclude:
+    - 'test/models/message_test.rb'

 
 

-# Offense count: 306
+# Offense count: 220

 Style/Documentation:
   Enabled: false
 
 Style/Documentation:
   Enabled: false
 

-# Offense count: 41
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'app/controllers/way_controller.rb'

 
 # Offense count: 60
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:
 
 # Offense count: 60
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:

-  Enabled: false
-
-# Offense count: 53
+  Exclude:
+    - 'db/migrate/008_remove_segments.rb'
+    - 'db/migrate/020_populate_node_tags_and_remove.rb'
+    - 'db/migrate/023_add_changesets.rb'
+    - 'lib/bounding_box.rb'
+    - 'lib/diff_reader.rb'
+    - 'lib/osm.rb'
+    - 'test/controllers/changeset_controller_test.rb'
+    - 'test/controllers/node_controller_test.rb'
+    - 'test/controllers/relation_controller_test.rb'
+    - 'test/controllers/way_controller_test.rb'
+
+# Offense count: 71

 # Cop supports --auto-correct.
 Style/NumericLiterals:
   MinDigits: 11
 
 # Cop supports --auto-correct.
 Style/NumericLiterals:
   MinDigits: 11
 

-# Offense count: 44
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Enabled: false
-

 # Offense count: 8
 # Offense count: 8

-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?

 Style/PredicateName:
 Style/PredicateName:

-  Enabled: false
-
-# Offense count: 95
+  Exclude:
+    - 'spec/**/*'
+    - 'app/models/changeset.rb'
+    - 'app/models/old_node.rb'
+    - 'app/models/old_relation.rb'
+    - 'app/models/old_way.rb'
+    - 'app/models/user.rb'
+    - 'lib/classic_pagination/pagination.rb'
+
+# Offense count: 97
+# Cop supports --auto-correct.

 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # Configuration parameters: EnforcedStyle, SupportedStyles.

+# SupportedStyles: compact, exploded

 Style/RaiseArgs:
   Enabled: false
 
 # Offense count: 2
 Style/RaiseArgs:
   Enabled: false
 
 # Offense count: 2

-Style/RescueModifier:
-  Enabled: false
-
-# Offense count: 8

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-
-# Offense count: 3
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false
+Style/RescueModifier:
+  Exclude:
+    - 'app/helpers/browse_helper.rb'