Tidy up the note controller

[rails.git] / app / views / browse / start.rjs

diff --git a/app/views/browse/start.rjs b/app/views/browse/start.rjs
index 70705452680be75283919966e5f718660f570423..b96e8c39c6ecd1d29859123264f4fd1d559bb898 100644 (file)
--- a/app/views/browse/start.rjs
+++ b/app/views/browse/start.rjs
@@ -2,7 +2,6 @@ page.replace_html :sidebar_title, t('browse.start_rjs.data_frame_title')
 page.replace_html :sidebar_content, :partial => 'start'
 page << <<EOJ
   var browseBoxControl;
 page.replace_html :sidebar_content, :partial => 'start'
 page << <<EOJ
   var browseBoxControl;

-  var browseActive;

   var browseMode = "auto";
   var browseBounds;
   var browseFeatureList;
   var browseMode = "auto";
   var browseBounds;
   var browseFeatureList;


@@ -10,12 +9,13 @@ page << <<EOJ
   var browseDataLayer;
   var browseSelectControl;
   var browseObjectList;
   var browseDataLayer;
   var browseSelectControl;
   var browseObjectList;

+  var areasHidden = false;

 
   OpenLayers.Feature.Vector.style['default'].strokeWidth = 3;
   OpenLayers.Feature.Vector.style['default'].cursor = "pointer";
     
   function startBrowse() {
 
   OpenLayers.Feature.Vector.style['default'].strokeWidth = 3;
   OpenLayers.Feature.Vector.style['default'].cursor = "pointer";
     
   function startBrowse() {

-    browseActive = true;
+    map.dataLayer.active = true;

 
     openSidebar({ onclose: stopBrowse });
 
 
     openSidebar({ onclose: stopBrowse });
 


@@ -26,20 +26,24 @@ page << <<EOJ
         sides: 4,
         snapAngle: 90,
         irregular: true,
         sides: 4,
         snapAngle: 90,
         irregular: true,

-        persist: true,
-        callbacks: { done: endDrag }
+        persist: true

       }
     });
       }
     });

+    browseBoxControl.handler.callbacks.done = endDrag;

     map.addControl(browseBoxControl);
 
     map.events.register("moveend", map, showData);
     map.events.triggerEvent("moveend");
     map.addControl(browseBoxControl);
 
     map.events.register("moveend", map, showData);
     map.events.triggerEvent("moveend");

+
+    $("browse_hide_areas_box").innerHTML = "#{I18n.t('browse.start_rjs.hide_areas')}";
+    $("browse_hide_areas_box").style.display = "inline";
+    $("browse_hide_areas_box").onclick = hideAreas;

   }
 
   function showData() {
     if (browseMode == "auto") {
       if (map.getZoom() >= 15) {
   }
 
   function showData() {
     if (browseMode == "auto") {
       if (map.getZoom() >= 15) {

-          useMap();
+          useMap(false);

       } else {
           setStatus("#{I18n.t('browse.start_rjs.zoom_or_select')}");
       }    
       } else {
           setStatus("#{I18n.t('browse.start_rjs.zoom_or_select')}");
       }    


@@ -47,8 +51,8 @@ page << <<EOJ
   }
 
   function stopBrowse() {
   }
 
   function stopBrowse() {

-    if (browseActive) {
-      browseActive = false;
+    if (map.dataLayer.active) {
+      map.dataLayer.active = false;

 
       if (browseSelectControl) {   
         browseSelectControl.destroy();  
 
       if (browseSelectControl) {   
         browseSelectControl.destroy();  


@@ -57,7 +61,7 @@ page << <<EOJ
 
       if (browseBoxControl) {
        browseBoxControl.destroy();
 
       if (browseBoxControl) {
        browseBoxControl.destroy();

-       browseBoxControl = null;
+        browseBoxControl = null;

       }                
 
       if (browseActiveFeature) {
       }                
 
       if (browseActiveFeature) {


@@ -85,7 +89,7 @@ page << <<EOJ
 
   $("browse_select_box").onclick = startDrag;
 
 
   $("browse_select_box").onclick = startDrag;
 

-  function useMap() {
+  function useMap(reload) {

     var bounds = map.getExtent();
     var projected = bounds.clone().transform(map.getProjectionObject(), epsg4326);
 
     var bounds = map.getExtent();
     var projected = bounds.clone().transform(map.getProjectionObject(), epsg4326);
 


@@ -99,7 +103,7 @@ page << <<EOJ
                                              center.lat + (tileHeight / 2));
 
       browseBounds = tileBounds;
                                              center.lat + (tileHeight / 2));
 
       browseBounds = tileBounds;

-      getData(tileBounds);
+      getData(tileBounds, reload);

 
       browseMode = "auto";
 
 
       browseMode = "auto";
 


@@ -109,6 +113,26 @@ page << <<EOJ
     return false;
   }
 
     return false;
   }
 

+  function hideAreas() {
+      $("browse_hide_areas_box").innerHTML = "#{I18n.t('browse.start_rjs.show_areas')}";
+      $("browse_hide_areas_box").style.display = "inline";
+      $("browse_hide_areas_box").onclick = showAreas;
+
+      areasHidden = true;
+
+      useMap(true);
+  }
+
+  function showAreas() {
+      $("browse_hide_areas_box").innerHTML = "#{I18n.t('browse.start_rjs.hide_areas')}";
+      $("browse_hide_areas_box").style.display = "inline";
+      $("browse_hide_areas_box").onclick = hideAreas;
+
+      areasHidden = false;
+
+      useMap(true);
+  }
+

   $("browse_select_view").onclick = useMap;
 
   function endDrag(bbox) {
   $("browse_select_view").onclick = useMap;
 
   function endDrag(bbox) {


@@ -154,7 +178,7 @@ page << <<EOJ
   }    
 
   function customDataLoader(request) {
   }    
 
   function customDataLoader(request) {

-    if (browseActive) {
+    if (this.map.dataLayer.active) {

       var doc = request.responseXML;
 
       if (!doc || !doc.documentElement) {
       var doc = request.responseXML;
 
       if (!doc || !doc.documentElement) {


@@ -182,22 +206,29 @@ page << <<EOJ
     }
   }
 
     }
   }
 

-  function getData(bounds) {
+  function getData(bounds, reload) {

     var projected = bounds.clone().transform(new OpenLayers.Projection("EPSG:900913"), new OpenLayers.Projection("EPSG:4326"));
     var size = projected.getWidth() * projected.getHeight();
 
     var projected = bounds.clone().transform(new OpenLayers.Projection("EPSG:900913"), new OpenLayers.Projection("EPSG:4326"));
     var size = projected.getWidth() * projected.getHeight();
 

-    if (size > #{APP_CONFIG['max_request_area']}) {
-      setStatus(i18n("#{I18n.t('browse.start_rjs.unable_to_load_size', :max_bbox_size => APP_CONFIG['max_request_area'])}", { bbox_size: size }));
+    if (size > #{MAX_REQUEST_AREA}) {
+      setStatus(i18n("#{I18n.t('browse.start_rjs.unable_to_load_size', :max_bbox_size => MAX_REQUEST_AREA)}", { bbox_size: size }));

     } else {
     } else {

-      loadGML("/api/#{API_VERSION}/map?bbox=" + projected.toBBOX());
+      loadGML("/api/#{API_VERSION}/map?bbox=" + projected.toBBOX(), reload);

     }
   }
 
     }
   }
 

-  function loadGML(url) {
+  function loadGML(url, reload) {

     setStatus("#{I18n.t('browse.start_rjs.loading')}");
     $("browse_content").innerHTML = "";
 
     setStatus("#{I18n.t('browse.start_rjs.loading')}");
     $("browse_content").innerHTML = "";
 

-    if (!browseDataLayer) {
+    var formatOptions = {
+      checkTags: true,
+      interestingTagsExclude: ['source','source_ref','source:ref','history','attribution','created_by','tiger:county','tiger:tlid','tiger:upload_uuid']
+    };
+
+    if (areasHidden) formatOptions.areaTags = [];
+
+    if (!browseDataLayer || reload) {

       var style = new OpenLayers.Style();
 
       style.addRules([new OpenLayers.Rule({
       var style = new OpenLayers.Style();
 
       style.addRules([new OpenLayers.Rule({


@@ -208,12 +239,11 @@ page << <<EOJ
         }
       })]);
 
         }
       })]);
 

+      if (browseDataLayer) browseDataLayer.destroyFeatures();
+

       browseDataLayer = new OpenLayers.Layer.GML("Data", url, {
         format: OpenLayers.Format.OSM,
       browseDataLayer = new OpenLayers.Layer.GML("Data", url, {
         format: OpenLayers.Format.OSM,

-        formatOptions: {
-          checkTags: true, 
-          interestingTagsExclude: ['source','source_ref','source:ref','history','attribution','created_by','tiger:county','tiger:tlid','tiger:upload_uuid']
-        },
+        formatOptions: formatOptions,

         maxFeatures: 100,
         requestSuccess: customDataLoader,
         displayInLayerSwitcher: false,
         maxFeatures: 100,
         requestSuccess: customDataLoader,
         displayInLayerSwitcher: false,


@@ -231,6 +261,8 @@ page << <<EOJ
       map.addControl(browseSelectControl);
       browseSelectControl.activate();
     } else {
       map.addControl(browseSelectControl);
       browseSelectControl.activate();
     } else {

+      browseDataLayer.destroyFeatures();
+      browseDataLayer.format(formatOptions);

       browseDataLayer.setUrl(url);
     }
 
       browseDataLayer.setUrl(url);
     }
 


@@ -238,9 +270,9 @@ page << <<EOJ
   }
 
   function dataLoaded() {
   }
 
   function dataLoaded() {

-    if (browseActive) {
+    if (this.map.dataLayer.active) {

       clearStatus();
       clearStatus();

-        
+

       browseObjectList = document.createElement("div")
 
       var heading = document.createElement("p");
       browseObjectList = document.createElement("div")
 
       var heading = document.createElement("p");


@@ -262,7 +294,7 @@ page << <<EOJ
         // Link, for viewing in the tab
         var link = document.createElement("a");
         link.href =  "/browse/" + type + "/" + feature.osm_id; 
         // Link, for viewing in the tab
         var link = document.createElement("a");
         link.href =  "/browse/" + type + "/" + feature.osm_id; 

-        var name = feature.attributes.name || feature.osm_id;
+        var name = featureName(feature);

         link.appendChild(document.createTextNode(name));
         link.feature = feature;
         link.onclick = OpenLayers.Function.bind(viewFeatureLink, link);   
         link.appendChild(document.createTextNode(name));
         link.feature = feature;
         link.onclick = OpenLayers.Function.bind(viewFeatureLink, link);   


@@ -466,8 +498,20 @@ page << <<EOJ
     }
   }
 
     }
   }
 

+  function featureName(feature) {
+    if (feature.attributes['name:#{I18n.locale}']) {
+      return feature.attributes['name:#{I18n.locale}'];
+    } else if (feature.attributes.name) {
+      return feature.attributes.name;
+    } else {
+      return feature.osm_id;
+    }
+  }
+

   function featureNameSelect(feature) {
   function featureNameSelect(feature) {

-    if (feature.attributes.name) {
+    if (feature.attributes['name:#{I18n.locale}']) {
+      return feature.attributes['name:#{I18n.locale}'];
+    } else if (feature.attributes.name) {

       return feature.attributes.name;
     } else if (featureType(feature) == "node") {
       return i18n("#{I18n.t('browse.start_rjs.object_list.selected.type.node')}", { id: feature.osm_id });
       return feature.attributes.name;
     } else if (featureType(feature) == "node") {
       return i18n("#{I18n.t('browse.start_rjs.object_list.selected.type.node')}", { id: feature.osm_id });


@@ -477,7 +521,9 @@ page << <<EOJ
   }
 
   function featureNameHistory(feature) {
   }
 
   function featureNameHistory(feature) {

-    if (feature.attributes.name) {
+    if (feature.attributes['name:#{I18n.locale}']) {
+      return feature.attributes['name:#{I18n.locale}'];
+    } else if (feature.attributes.name) {

       return feature.attributes.name;
     } else if (featureType(feature) == "node") {
       return i18n("#{I18n.t('browse.start_rjs.object_list.history.type.node')}", { id: feature.osm_id });
       return feature.attributes.name;
     } else if (featureType(feature) == "node") {
       return i18n("#{I18n.t('browse.start_rjs.object_list.history.type.node')}", { id: feature.osm_id });