Merge remote-tracking branch 'upstream/pull/4877'

[rails.git] / test / integration / client_applications_test.rb

diff --git a/test/integration/client_applications_test.rb b/test/integration/client_applications_test.rb
index 59f234c41bd84011a134a3da7c6cd8e9b5237125..e7e5b75759b2ab58b743f3562159196306d0ee90 100644 (file)
--- a/test/integration/client_applications_test.rb
+++ b/test/integration/client_applications_test.rb
@@ -8,22 +8,21 @@ class ClientApplicationsTest < ActionDispatch::IntegrationTest
     user = create(:user)
 
     get "/login"
     user = create(:user)
 
     get "/login"

-    assert_response :redirect
-    assert_redirected_to "controller" => "user", "action" => "login", "cookie_test" => "true"
+    assert_redirected_to login_path(:cookie_test => "true")

     follow_redirect!
     assert_response :success
     post "/login", :params => { "username" => user.email, "password" => "test", :referer => "/user/#{ERB::Util.u(user.display_name)}" }
     assert_response :redirect
     follow_redirect!
     assert_response :success
     follow_redirect!
     assert_response :success
     post "/login", :params => { "username" => user.email, "password" => "test", :referer => "/user/#{ERB::Util.u(user.display_name)}" }
     assert_response :redirect
     follow_redirect!
     assert_response :success

-    assert_template "user/view"
-    get "/user/#{ERB::Util.u(user.display_name)}/account"
+    assert_template "users/show"
+    get "/account/edit"

     assert_response :success
     assert_response :success

-    assert_template "user/account"
+    assert_template "accounts/edit"

 
     # check that the form to allow new client application creations exists
     assert_in_heading do
 
     # check that the form to allow new client application creations exists
     assert_in_heading do

-      assert_select "ul.secondary-actions li a[href='/user/#{ERB::Util.u(user.display_name)}/oauth_clients']"
+      assert_select "ul.nav.nav-tabs li.nav-item a[href='/user/#{ERB::Util.u(user.display_name)}/oauth_clients']"

     end
 
     # now we follow the link to the oauth client list
     end
 
     # now we follow the link to the oauth client list


@@ -65,7 +64,7 @@ class ClientApplicationsTest < ActionDispatch::IntegrationTest
     get "/user/#{ERB::Util.u(user.display_name)}/oauth_clients"
     assert_response :success
     assert_template "oauth_clients/index"
     get "/user/#{ERB::Util.u(user.display_name)}/oauth_clients"
     assert_response :success
     assert_template "oauth_clients/index"

-    assert_in_body { assert_select "div>a", "My New App" }
+    assert_in_body { assert_select "li>a", "My New App" }

   end
 
   ##
   end
 
   ##


@@ -76,19 +75,17 @@ class ClientApplicationsTest < ActionDispatch::IntegrationTest
     # tests, as its too tied into the HTTP headers and stuff that it signs.
   end
 
     # tests, as its too tied into the HTTP headers and stuff that it signs.
   end
 

+  private
+

   ##
   # utility method to make the HTML screening easier to read.
   ##
   # utility method to make the HTML screening easier to read.

-  def assert_in_heading
-    assert_select "div.content-heading" do
-      yield
-    end
+  def assert_in_heading(&block)
+    assert_select("div.content-heading", &block)

   end
 
   ##
   # utility method to make the HTML screening easier to read.
   end
 
   ##
   # utility method to make the HTML screening easier to read.

-  def assert_in_body
-    assert_select "div#content" do
-      yield
-    end
+  def assert_in_body(&block)
+    assert_select("div#content", &block)

   end
 end
   end
 end