Merge remote-tracking branch 'upstream/pull/4706'

[rails.git] / test / controllers / issues_controller_test.rb

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index ff99b0cdcef37af48b6ab54ae8e13698efbda296..a988fc909f7cc3a73ad3417db5ca43958d8c4b01 100644 (file)
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -1,69 +1,232 @@
 require "test_helper"
 
 require "test_helper"
 

-class IssuesControllerTest < ActionController::TestCase
-  teardown do
-    # cleanup any emails set off by the test
-    ActionMailer::Base.deliveries.clear
+class IssuesControllerTest < ActionDispatch::IntegrationTest
+  def test_index
+    # Access issues list without login
+    get issues_path
+    assert_redirected_to login_path(:referer => issues_path)
+
+    # Access issues list as normal user
+    session_for(create(:user))
+    get issues_path
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Access issues list as administrator
+    session_for(create(:administrator_user))
+    get issues_path
+    assert_response :success
+
+    # Access issues list as moderator
+    session_for(create(:moderator_user))
+    get issues_path
+    assert_response :success

   end
 
   end
 

-  def test_view_dashboard_without_auth
-    # Access issues_path without login
-    get :index
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => issues_path)
+  def test_show_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")

 
 

-    # Access issues_path as normal user
-    session[:user] = create(:user).id
-    get :index
-    assert_response :redirect
-    assert_redirected_to root_path
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))

 
 

-    # Access issues_path by admin
-    session[:user] = create(:administrator_user).id
-    get :index
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)

     assert_response :success
     assert_response :success

+  end

 
 

-    # Access issues_path by moderator
-    session[:user] = create(:moderator_user).id
-    get :index
+  def test_show_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))
+
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)

     assert_response :success
   end
 
     assert_response :success
   end
 

-  def test_change_status_by_normal_user
+  def test_resolve_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?
+
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
+    assert_response :redirect
+    assert_predicate issue.reload, :resolved?
+  end
+
+  def test_resolve_administrator

     target_user = create(:user)
     target_user = create(:user)

-    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")

 
 

-    # Login as normal user
-    session[:user] = create(:user).id
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden

 
 

-    assert_equal 1, Issue.count
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden

 
 

-    get :resolve, :params => { :id => issue.id }
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?

 
 

+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)

     assert_response :redirect
     assert_response :redirect

-    assert_redirected_to root_path
+    assert_predicate issue.reload, :resolved?

   end
 
   end
 

-  def test_change_status_by_admin
+  def test_ignore_moderator

     target_user = create(:user)
     target_user = create(:user)

-    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden

 
 

-    # Login as administrator
-    session[:user] = create(:administrator_user).id
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden

 
 

-    # Test 'Resolved'
-    get :resolve, :params => { :id => issue.id }
-    assert_equal true, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").resolved?
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
+
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)

     assert_response :redirect
     assert_response :redirect

+    assert_predicate issue.reload, :ignored?
+  end
+
+  def test_ignore_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden

 
 

-    # Test 'Reopen'
-    get :reopen, :params => { :id => issue.id }
-    assert_equal true, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").open?
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
+
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)

     assert_response :redirect
     assert_response :redirect

+    assert_predicate issue.reload, :ignored?
+  end
+
+  def test_reopen_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    issue.resolve!
+
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?
+
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
+    assert_response :redirect
+    assert_predicate issue.reload, :open?
+  end
+
+  def test_reopen_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    issue.resolve!
+
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?

 
 

-    # Test 'Ignored'
-    get :ignore, :params => { :id => issue.id }
-    assert_equal true, Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored?
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)

     assert_response :redirect
     assert_response :redirect

+    assert_predicate issue.reload, :open?

   end
 end
   end
 end