Fix some rubocop rails style issues

[rails.git] / app / controllers / user_controller.rb

diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index dbfc44a37ad7af34cb558658408366a1c00e6391..7c20c5111844d2038b07f4b92da50dde7fec9cba 100644 (file)
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -1,51 +1,51 @@
 class UserController < ApplicationController
 class UserController < ApplicationController

-  layout 'site', :except => [:api_details]
-
-  skip_before_filter :verify_authenticity_token, :only => [:api_read, :api_details, :api_gpx_files]
-  before_filter :disable_terms_redirect, :only => [:terms, :save, :logout, :api_details]
-  before_filter :authorize, :only => [:api_details, :api_gpx_files]
-  before_filter :authorize_web, :except => [:api_read, :api_details, :api_gpx_files]
-  before_filter :set_locale, :except => [:api_read, :api_details, :api_gpx_files]
-  before_filter :require_user, :only => [:account, :go_public, :make_friend, :remove_friend]
-  before_filter :require_self, :only => [:account]
-  before_filter :check_database_readable, :except => [:login, :api_read, :api_details, :api_gpx_files]
-  before_filter :check_database_writable, :only => [:new, :account, :confirm, :confirm_email, :lost_password, :reset_password, :go_public, :make_friend, :remove_friend]
-  before_filter :check_api_readable, :only => [:api_read, :api_details, :api_gpx_files]
-  before_filter :require_allow_read_prefs, :only => [:api_details]
-  before_filter :require_allow_read_gpx, :only => [:api_gpx_files]
-  before_filter :require_cookies, :only => [:new, :login, :confirm]
-  before_filter :require_administrator, :only => [:set_status, :delete, :list]
-  around_filter :api_call_handle_error, :only => [:api_read, :api_details, :api_gpx_files]
-  before_filter :lookup_user_by_id, :only => [:api_read]
-  before_filter :lookup_user_by_name, :only => [:set_status, :delete]
+  layout "site", :except => [:api_details]
+
+  skip_before_action :verify_authenticity_token, :only => [:api_read, :api_details, :api_gpx_files, :auth_success]
+  before_action :disable_terms_redirect, :only => [:terms, :save, :logout, :api_details]
+  before_action :authorize, :only => [:api_details, :api_gpx_files]
+  before_action :authorize_web, :except => [:api_read, :api_details, :api_gpx_files]
+  before_action :set_locale, :except => [:api_read, :api_details, :api_gpx_files]
+  before_action :require_user, :only => [:account, :go_public, :make_friend, :remove_friend]
+  before_action :require_self, :only => [:account]
+  before_action :check_database_readable, :except => [:login, :api_read, :api_details, :api_gpx_files]
+  before_action :check_database_writable, :only => [:new, :account, :confirm, :confirm_email, :lost_password, :reset_password, :go_public, :make_friend, :remove_friend]
+  before_action :check_api_readable, :only => [:api_read, :api_details, :api_gpx_files]
+  before_action :require_allow_read_prefs, :only => [:api_details]
+  before_action :require_allow_read_gpx, :only => [:api_gpx_files]
+  before_action :require_cookies, :only => [:new, :login, :confirm]
+  before_action :require_administrator, :only => [:set_status, :delete, :list]
+  around_action :api_call_handle_error, :only => [:api_read, :api_details, :api_gpx_files]
+  before_action :lookup_user_by_id, :only => [:api_read]
+  before_action :lookup_user_by_name, :only => [:set_status, :delete]

 
   def terms
 
   def terms

-    @legale = params[:legale] || OSM.IPToCountry(request.remote_ip) || DEFAULT_LEGALE
+    @legale = params[:legale] || OSM.ip_to_country(request.remote_ip) || DEFAULT_LEGALE

     @text = OSM.legal_text_for_country(@legale)
 
     if request.xhr?
       render :partial => "terms"
     else
     @text = OSM.legal_text_for_country(@legale)
 
     if request.xhr?
       render :partial => "terms"
     else

-      @title = t 'user.terms.title'
+      @title = t "user.terms.title"

 
 

-      if @user and @user.terms_agreed?
+      if @user && @user.terms_agreed?

         # Already agreed to terms, so just show settings
         redirect_to :action => :account, :display_name => @user.display_name
         # Already agreed to terms, so just show settings
         redirect_to :action => :account, :display_name => @user.display_name

-      elsif @user.nil? and session[:new_user].nil?
+      elsif @user.nil? && session[:new_user].nil?

         redirect_to :action => :login, :referer => request.fullpath
       end
     end
   end
 
   def save
         redirect_to :action => :login, :referer => request.fullpath
       end
     end
   end
 
   def save

-    @title = t 'user.new.title'
+    @title = t "user.new.title"

 
     if params[:decline]
       if @user
         @user.terms_seen = true
 
         if @user.save
 
     if params[:decline]
       if @user
         @user.terms_seen = true
 
         if @user.save

-          flash[:notice] = t 'user.new.terms declined', :url => t('user.new.terms declined url')
+          flash[:notice] = t "user.new.terms declined", :url => t("user.new.terms declined url")

         end
 
         if params[:referer]
         end
 
         if params[:referer]


@@ -54,16 +54,15 @@ class UserController < ApplicationController
           redirect_to :action => :account, :display_name => @user.display_name
         end
       else
           redirect_to :action => :account, :display_name => @user.display_name
         end
       else

-        redirect_to t('user.terms.declined')
+        redirect_to t("user.terms.declined")

       end
     elsif @user
       end
     elsif @user

-      if !@user.terms_agreed?
+      unless @user.terms_agreed?

         @user.consider_pd = params[:user][:consider_pd]
         @user.terms_agreed = Time.now.getutc
         @user.terms_seen = true
         @user.consider_pd = params[:user][:consider_pd]
         @user.terms_agreed = Time.now.getutc
         @user.terms_seen = true

-        if @user.save
-          flash[:notice] = t 'user.new.terms accepted'
-        end
+
+        flash[:notice] = t "user.new.terms accepted" if @user.save

       end
 
       if params[:referer]
       end
 
       if params[:referer]


@@ -81,7 +80,11 @@ class UserController < ApplicationController
         @user.languages = http_accept_language.user_preferred_languages
         @user.terms_agreed = Time.now.getutc
         @user.terms_seen = true
         @user.languages = http_accept_language.user_preferred_languages
         @user.terms_agreed = Time.now.getutc
         @user.terms_seen = true

-        @user.openid_url = nil if @user.openid_url and @user.openid_url.empty?
+
+        if @user.auth_uid.nil? || @user.auth_uid.empty?
+          @user.auth_provider = nil
+          @user.auth_uid = nil
+        end

 
         if @user.save
           flash[:piwik_goal] = PIWIK["goals"]["signup"] if defined?(PIWIK)
 
         if @user.save
           flash[:piwik_goal] = PIWIK["goals"]["signup"] if defined?(PIWIK)


@@ -90,11 +93,11 @@ class UserController < ApplicationController
 
           begin
             uri = URI(session[:referer])
 
           begin
             uri = URI(session[:referer])

-            /map=(.*)\/(.*)\/(.*)/.match(uri.fragment) do |m|
-              editor = Rack::Utils.parse_query(uri.query).slice('editor')
-              referer = welcome_path({'zoom' => m[1],
-                                      'lat' => m[2],
-                                      'lon' => m[3]}.merge(editor))
+            %r{map=(.*)/(.*)/(.*)}.match(uri.fragment) do |m|
+              editor = Rack::Utils.parse_query(uri.query).slice("editor")
+              referer = welcome_path({ "zoom" => m[1],
+                                       "lat" => m[2],
+                                       "lon" => m[3] }.merge(editor))

             end
           rescue
             # Use default
             end
           rescue
             # Use default


@@ -105,39 +108,28 @@ class UserController < ApplicationController
             successful_login(@user)
           else
             session[:token] = @user.tokens.create.token
             successful_login(@user)
           else
             session[:token] = @user.tokens.create.token

-            Notifier.signup_confirm(@user, @user.tokens.create(:referer => referer)).deliver
-            redirect_to :action => 'confirm', :display_name => @user.display_name
+            Notifier.signup_confirm(@user, @user.tokens.create(:referer => referer)).deliver_now
+            redirect_to :action => "confirm", :display_name => @user.display_name

           end
         else
           end
         else

-          render :action => 'new', :referer => params[:referer]
+          render :action => "new", :referer => params[:referer]

         end
       end
     end
   end
 
   def account
         end
       end
     end
   end
 
   def account

-    @title = t 'user.account.title'
+    @title = t "user.account.title"

     @tokens = @user.oauth_tokens.authorized
 
     @tokens = @user.oauth_tokens.authorized
 

-    if params[:user] and params[:user][:display_name] and params[:user][:description]
-      if params[:user][:openid_url] and
-         params[:user][:openid_url].length > 0 and
-         params[:user][:openid_url] != @user.openid_url
-        # If the OpenID has changed, we want to check that it is a
-        # valid OpenID and one the user has control over before saving
-        # it as a password equivalent for the user.
-        session[:new_user_settings] = params
-        openid_verify(params[:user][:openid_url], @user)
-      else
+    if params[:user] && params[:user][:display_name] && params[:user][:description]
+      if params[:user][:auth_provider].blank? ||
+         (params[:user][:auth_provider] == @user.auth_provider &&
+          params[:user][:auth_uid] == @user.auth_uid)

         update_user(@user, params)
         update_user(@user, params)

-      end
-    elsif using_open_id?
-      # The redirect from the OpenID provider reenters here
-      # again and we need to pass the parameters through to
-      # the open_id_authentication function
-      settings = session.delete(:new_user_settings)
-      openid_verify(nil, @user) do |user|
-        update_user(user, settings)
+      else
+        session[:new_user_settings] = params
+        redirect_to auth_url(params[:user][:auth_provider], params[:user][:auth_uid])

       end
     end
   end
       end
     end
   end


@@ -145,37 +137,35 @@ class UserController < ApplicationController
   def go_public
     @user.data_public = true
     @user.save
   def go_public
     @user.data_public = true
     @user.save

-    flash[:notice] = t 'user.go_public.flash success'
-    redirect_to :controller => 'user', :action => 'account', :display_name => @user.display_name
+    flash[:notice] = t "user.go_public.flash success"
+    redirect_to :controller => "user", :action => "account", :display_name => @user.display_name

   end
 
   def lost_password
   end
 
   def lost_password

-    @title = t 'user.lost_password.title'
+    @title = t "user.lost_password.title"

 
 

-    if params[:user] and params[:user][:email]
+    if params[:user] && params[:user][:email]

       user = User.visible.find_by_email(params[:user][:email])
 
       if user.nil?
         users = User.visible.where("LOWER(email) = LOWER(?)", params[:user][:email])
 
       user = User.visible.find_by_email(params[:user][:email])
 
       if user.nil?
         users = User.visible.where("LOWER(email) = LOWER(?)", params[:user][:email])
 

-        if users.count == 1
-          user = users.first
-        end
+        user = users.first if users.count == 1

       end
 
       if user
         token = user.tokens.create
       end
 
       if user
         token = user.tokens.create

-        Notifier.lost_password(user, token).deliver
-        flash[:notice] = t 'user.lost_password.notice email on way'
-        redirect_to :action => 'login'
+        Notifier.lost_password(user, token).deliver_now
+        flash[:notice] = t "user.lost_password.notice email on way"
+        redirect_to :action => "login"

       else
       else

-        flash.now[:error] = t 'user.lost_password.notice email cannot find'
+        flash.now[:error] = t "user.lost_password.notice email cannot find"

       end
     end
   end
 
   def reset_password
       end
     end
   end
 
   def reset_password

-    @title = t 'user.reset_password.title'
+    @title = t "user.reset_password.title"

 
     if params[:token]
       token = UserToken.find_by_token(params[:token])
 
     if params[:token]
       token = UserToken.find_by_token(params[:token])


@@ -191,13 +181,13 @@ class UserController < ApplicationController
 
           if @user.save
             token.destroy
 
           if @user.save
             token.destroy

-            flash[:notice] = t 'user.reset_password.flash changed'
-            redirect_to :action => 'login'
+            flash[:notice] = t "user.reset_password.flash changed"
+            redirect_to :action => "login"

           end
         end
       else
           end
         end
       else

-        flash[:error] = t 'user.reset_password.flash token bad'
-        redirect_to :action => 'lost_password'
+        flash[:error] = t "user.reset_password.flash token bad"
+        redirect_to :action => "lost_password"

       end
     else
       render :text => "", :status => :bad_request
       end
     else
       render :text => "", :status => :bad_request


@@ -205,40 +195,25 @@ class UserController < ApplicationController
   end
 
   def new
   end
 
   def new

-    @title = t 'user.new.title'
+    @title = t "user.new.title"

     @referer = params[:referer] || session[:referer]
 
     @referer = params[:referer] || session[:referer]
 

-    if using_open_id?
-      # The redirect from the OpenID provider reenters here
-      # again and we need to pass the parameters through to
-      # the open_id_authentication function
-      @user = session.delete(:new_user)
-
-      openid_verify(nil, @user) do |user, verified_email|
-        user.status = "active" if user.email == verified_email
-      end
-
-      if @user.openid_url.nil? or @user.invalid?
-        render :action => 'new'
-      else
-        session[:new_user] = @user
-        redirect_to :action => 'terms'
-      end
-    elsif @user
+    if @user

       # The user is logged in already, so don't show them the signup
       # page, instead send them to the home page
       if @referer
         redirect_to @referer
       else
       # The user is logged in already, so don't show them the signup
       # page, instead send them to the home page
       if @referer
         redirect_to @referer
       else

-        redirect_to :controller => 'site', :action => 'index'
+        redirect_to :controller => "site", :action => "index"

       end
       end

-    elsif params.key?(:openid)
+    elsif params.key?(:auth_provider) && params.key?(:auth_uid)

       @user = User.new(:email => params[:email],
                        :email_confirmation => params[:email],
                        :display_name => params[:nickname],
       @user = User.new(:email => params[:email],
                        :email_confirmation => params[:email],
                        :display_name => params[:nickname],

-                       :openid_url => params[:openid])
+                       :auth_provider => params[:auth_provider],
+                       :auth_uid => params[:auth_uid])

 
 

-      flash.now[:notice] = t 'user.new.openid association'
+      flash.now[:notice] = t "user.new.auth association"

     else
       check_signup_allowed
     end
     else
       check_signup_allowed
     end


@@ -252,9 +227,9 @@ class UserController < ApplicationController
 
       @user.status = "pending"
 
 
       @user.status = "pending"
 

-      if @user.openid_url.present? && @user.pass_crypt.empty?
-        # We are creating an account with OpenID and no password
-        # was specified so create a random one
+      if @user.auth_provider.present? && @user.auth_uid.present? && @user.pass_crypt.empty?
+        # We are creating an account with external authentication and
+        # no password was specified so create a random one

         @user.pass_crypt = SecureRandom.base64(16)
         @user.pass_crypt_confirmation = @user.pass_crypt
       end
         @user.pass_crypt = SecureRandom.base64(16)
         @user.pass_crypt_confirmation = @user.pass_crypt
       end


@@ -262,10 +237,10 @@ class UserController < ApplicationController
       if @user.invalid?
         # Something is wrong with a new user, so rerender the form
         render :action => "new"
       if @user.invalid?
         # Something is wrong with a new user, so rerender the form
         render :action => "new"

-      elsif @user.openid_url.present?
-        # Verify OpenID before moving on
+      elsif @user.auth_provider.present? && @user.auth_uid.present?
+        # Verify external authenticator before moving on

         session[:new_user] = @user
         session[:new_user] = @user

-        openid_verify(@user.openid_url, @user)
+        redirect_to auth_url(@user.auth_provider, @user.auth_uid)

       else
         # Save the user record
         session[:new_user] = @user
       else
         # Save the user record
         session[:new_user] = @user


@@ -275,27 +250,26 @@ class UserController < ApplicationController
   end
 
   def login
   end
 
   def login

-    if params[:username] or using_open_id?
-      session[:remember_me] ||= params[:remember_me]
+    if params[:username] || params[:openid_url]

       session[:referer] ||= params[:referer]
 
       session[:referer] ||= params[:referer]
 

-      if using_open_id?
-        openid_authentication(params[:openid_url])
+      if params[:openid_url].present?
+        session[:remember_me] ||= params[:remember_me_openid]
+        redirect_to auth_url("openid", params[:openid_url])

       else
       else

+        session[:remember_me] ||= params[:remember_me]

         password_authentication(params[:username], params[:password])
       end
     end
   end
 
   def logout
         password_authentication(params[:username], params[:password])
       end
     end
   end
 
   def logout

-    @title = t 'user.logout.title'
+    @title = t "user.logout.title"

 
     if params[:session] == request.session_options[:id]
       if session[:token]
         token = UserToken.find_by_token(session[:token])
 
     if params[:session] == request.session_options[:id]
       if session[:token]
         token = UserToken.find_by_token(session[:token])

-        if token
-          token.destroy
-        end
+        token.destroy if token

         session.delete(:token)
       end
       session.delete(:user)
         session.delete(:token)
       end
       session.delete(:user)


@@ -303,7 +277,7 @@ class UserController < ApplicationController
       if params[:referer]
         redirect_to params[:referer]
       else
       if params[:referer]
         redirect_to params[:referer]
       else

-        redirect_to :controller => 'site', :action => 'index'
+        redirect_to :controller => "site", :action => "index"

       end
     end
   end
       end
     end
   end


@@ -312,11 +286,11 @@ class UserController < ApplicationController
     if request.post?
       token = UserToken.find_by_token(params[:confirm_string])
       if token && token.user.active?
     if request.post?
       token = UserToken.find_by_token(params[:confirm_string])
       if token && token.user.active?

-        flash[:error] = t('user.confirm.already active')
-        redirect_to :action => 'login'
+        flash[:error] = t("user.confirm.already active")
+        redirect_to :action => "login"

       elsif !token || token.expired?
       elsif !token || token.expired?

-        flash[:error] = t('user.confirm.unknown token')
-        redirect_to :action => 'confirm'
+        flash[:error] = t("user.confirm.unknown token")
+        redirect_to :action => "confirm"

       else
         user = token.user
         user.status = "active"
       else
         user = token.user
         user.status = "active"


@@ -332,8 +306,8 @@ class UserController < ApplicationController
           token = nil
         end
 
           token = nil
         end
 

-        if token.nil? or token.user != user
-          flash[:notice] = t('user.confirm.success')
+        if token.nil? || token.user != user
+          flash[:notice] = t("user.confirm.success")

           redirect_to :action => :login, :referer => referer
         else
           token.destroy
           redirect_to :action => :login, :referer => referer
         else
           token.destroy


@@ -345,42 +319,41 @@ class UserController < ApplicationController
       end
     else
       user = User.find_by_display_name(params[:display_name])
       end
     else
       user = User.find_by_display_name(params[:display_name])

-      if !user || user.active?
-        redirect_to root_path
-      end
+
+      redirect_to root_path if !user || user.active?

     end
   end
 
   def confirm_resend
     if user = User.find_by_display_name(params[:display_name])
     end
   end
 
   def confirm_resend
     if user = User.find_by_display_name(params[:display_name])

-      Notifier.signup_confirm(user, user.tokens.create).deliver
-      flash[:notice] = t 'user.confirm_resend.success', :email => user.email
+      Notifier.signup_confirm(user, user.tokens.create).deliver_now
+      flash[:notice] = t "user.confirm_resend.success", :email => user.email

     else
     else

-      flash[:notice] = t 'user.confirm_resend.failure', :name => params[:display_name]
+      flash[:notice] = t "user.confirm_resend.failure", :name => params[:display_name]

     end
 
     end
 

-    redirect_to :action => 'login'
+    redirect_to :action => "login"

   end
 
   def confirm_email
     if request.post?
       token = UserToken.find_by_token(params[:confirm_string])
   end
 
   def confirm_email
     if request.post?
       token = UserToken.find_by_token(params[:confirm_string])

-      if token and token.user.new_email?
+      if token && token.user.new_email?

         @user = token.user
         @user.email = @user.new_email
         @user.new_email = nil
         @user.email_valid = true
         if @user.save
         @user = token.user
         @user.email = @user.new_email
         @user.new_email = nil
         @user.email_valid = true
         if @user.save

-          flash[:notice] = t 'user.confirm_email.success'
+          flash[:notice] = t "user.confirm_email.success"

         else
           flash[:errors] = @user.errors
         end
         token.destroy
         session[:user] = @user.id
         else
           flash[:errors] = @user.errors
         end
         token.destroy
         session[:user] = @user.id

-        redirect_to :action => 'account', :display_name => @user.display_name
+        redirect_to :action => "account", :display_name => @user.display_name

       else
       else

-        flash[:error] = t 'user.confirm_email.failure'
-        redirect_to :action => 'account', :display_name => @user.display_name
+        flash[:error] = t "user.confirm_email.failure"
+        redirect_to :action => "account", :display_name => @user.display_name

       end
     end
   end
       end
     end
   end


@@ -397,7 +370,7 @@ class UserController < ApplicationController
   def api_gpx_files
     doc = OSM::API.new.get_xml_doc
     @user.traces.each do |trace|
   def api_gpx_files
     doc = OSM::API.new.get_xml_doc
     @user.traces.each do |trace|

-      doc.root << trace.to_xml_node() if trace.public? or trace.user == @user
+      doc.root << trace.to_xml_node if trace.public? || trace.user == @user

     end
     render :text => doc.to_s, :content_type => "text/xml"
   end
     end
     render :text => doc.to_s, :content_type => "text/xml"
   end


@@ -405,8 +378,8 @@ class UserController < ApplicationController
   def view
     @this_user = User.find_by_display_name(params[:display_name])
 
   def view
     @this_user = User.find_by_display_name(params[:display_name])
 

-    if @this_user and
-       (@this_user.visible? or (@user and @user.administrator?))
+    if @this_user &&
+       (@this_user.visible? || (@user && @user.administrator?))

       @title = @this_user.display_name
     else
       render_unknown_user params[:display_name]
       @title = @this_user.display_name
     else
       render_unknown_user params[:display_name]


@@ -421,21 +394,21 @@ class UserController < ApplicationController
         friend = Friend.new
         friend.user_id = @user.id
         friend.friend_user_id = @new_friend.id
         friend = Friend.new
         friend.user_id = @user.id
         friend.friend_user_id = @new_friend.id

-        unless @user.is_friends_with?(@new_friend)
+        if @user.is_friends_with?(@new_friend)
+          flash[:warning] = t "user.make_friend.already_a_friend", :name => @new_friend.display_name
+        else

           if friend.save
           if friend.save

-            flash[:notice] = t 'user.make_friend.success', :name => @new_friend.display_name
-            Notifier.friend_notification(friend).deliver
+            flash[:notice] = t "user.make_friend.success", :name => @new_friend.display_name
+            Notifier.friend_notification(friend).deliver_now

           else
           else

-            friend.add_error(t('user.make_friend.failed', :name => @new_friend.display_name))
+            friend.add_error(t("user.make_friend.failed", :name => @new_friend.display_name))

           end
           end

-        else
-          flash[:warning] = t 'user.make_friend.already_a_friend', :name => @new_friend.display_name

         end
 
         if params[:referer]
           redirect_to params[:referer]
         else
         end
 
         if params[:referer]
           redirect_to params[:referer]
         else

-          redirect_to :controller => 'user', :action => 'view'
+          redirect_to :controller => "user", :action => "view"

         end
       end
     else
         end
       end
     else


@@ -450,15 +423,15 @@ class UserController < ApplicationController
       if request.post?
         if @user.is_friends_with?(@friend)
           Friend.delete_all "user_id = #{@user.id} AND friend_user_id = #{@friend.id}"
       if request.post?
         if @user.is_friends_with?(@friend)
           Friend.delete_all "user_id = #{@user.id} AND friend_user_id = #{@friend.id}"

-          flash[:notice] = t 'user.remove_friend.success', :name => @friend.display_name
+          flash[:notice] = t "user.remove_friend.success", :name => @friend.display_name

         else
         else

-          flash[:error] = t 'user.remove_friend.not_a_friend', :name => @friend.display_name
+          flash[:error] = t "user.remove_friend.not_a_friend", :name => @friend.display_name

         end
 
         if params[:referer]
           redirect_to params[:referer]
         else
         end
 
         if params[:referer]
           redirect_to params[:referer]
         else

-          redirect_to :controller => 'user', :action => 'view'
+          redirect_to :controller => "user", :action => "view"

         end
       end
     else
         end
       end
     else


@@ -471,28 +444,28 @@ class UserController < ApplicationController
   def set_status
     @this_user.status = params[:status]
     @this_user.save
   def set_status
     @this_user.status = params[:status]
     @this_user.save

-    redirect_to :controller => 'user', :action => 'view', :display_name => params[:display_name]
+    redirect_to :controller => "user", :action => "view", :display_name => params[:display_name]

   end
 
   ##
   # delete a user, marking them as deleted and removing personal data
   def delete
     @this_user.delete
   end
 
   ##
   # delete a user, marking them as deleted and removing personal data
   def delete
     @this_user.delete

-    redirect_to :controller => 'user', :action => 'view', :display_name => params[:display_name]
+    redirect_to :controller => "user", :action => "view", :display_name => params[:display_name]

   end
 
   ##
   # display a list of users matching specified criteria
   def list
     if request.post?
   end
 
   ##
   # display a list of users matching specified criteria
   def list
     if request.post?

-      ids = params[:user].keys.collect { |id| id.to_i }
+      ids = params[:user].keys.collect(&:to_i)

 
       User.update_all("status = 'confirmed'", :id => ids) if params[:confirm]
       User.update_all("status = 'deleted'", :id => ids) if params[:hide]
 
       redirect_to url_for(:status => params[:status], :ip => params[:ip], :page => params[:page])
     else
 
       User.update_all("status = 'confirmed'", :id => ids) if params[:confirm]
       User.update_all("status = 'deleted'", :id => ids) if params[:hide]
 
       redirect_to url_for(:status => params[:status], :ip => params[:ip], :page => params[:page])
     else

-      conditions = Hash.new
+      conditions = {}

       conditions[:status] = params[:status] if params[:status]
       conditions[:creation_ip] = params[:ip] if params[:ip]
 
       conditions[:status] = params[:status] if params[:status]
       conditions[:creation_ip] = params[:ip] if params[:ip]
 


@@ -503,7 +476,65 @@ class UserController < ApplicationController
     end
   end
 
     end
   end
 

-private
+  ##
+  # omniauth success callback
+  def auth_success
+    auth_info = env["omniauth.auth"]
+
+    provider = auth_info[:provider]
+    uid = auth_info[:uid]
+    name = auth_info[:info][:name]
+    email = auth_info[:info][:email]
+
+    case provider
+    when "openid"
+      email_verified = uid.match(%r{https://www.google.com/accounts/o8/id?(.*)}) ||
+                       uid.match(%r{https://me.yahoo.com/(.*)})
+    else
+      email_verified = false
+    end
+
+    if user = User.find_by_auth_provider_and_auth_uid(provider, uid)
+      case user.status
+      when "pending" then
+        unconfirmed_login(user)
+      when "active", "confirmed" then
+        successful_login(user)
+      when "suspended" then
+        failed_login t("user.login.account is suspended", :webmaster => "mailto:webmaster@openstreetmap.org")
+      else
+        failed_login t("user.login.auth failure")
+      end
+    elsif settings = session.delete(:new_user_settings)
+      @user.auth_provider = provider
+      @user.auth_uid = uid
+
+      update_user(@user, settings)
+
+      redirect_to :action => "account", :display_name => @user.display_name
+    elsif session[:new_user]
+      session[:new_user].auth_provider = provider
+      session[:new_user].auth_uid = uid
+
+      if email_verified && email == session[:new_user].email
+        session[:new_user].status = "active"
+      end
+
+      redirect_to :action => "terms"
+    else
+      redirect_to :action => "new", :nickname => name, :email => email,
+                  :auth_provider => provider, :auth_uid => uid
+    end
+  end
+
+  ##
+  # omniauth failure callback
+  def auth_failure
+    flash[:error] = t("user.auth_failure." + params[:message])
+    redirect_to params[:origin]
+  end
+
+  private

 
   ##
   # handle password authentication
 
   ##
   # handle password authentication


@@ -513,99 +544,19 @@ private
     elsif user = User.authenticate(:username => username, :password => password, :pending => true)
       unconfirmed_login(user)
     elsif User.authenticate(:username => username, :password => password, :suspended => true)
     elsif user = User.authenticate(:username => username, :password => password, :pending => true)
       unconfirmed_login(user)
     elsif User.authenticate(:username => username, :password => password, :suspended => true)

-      failed_login t('user.login.account is suspended', :webmaster => "mailto:webmaster@openstreetmap.org")
+      failed_login t("user.login.account is suspended", :webmaster => "mailto:webmaster@openstreetmap.org")

     else
     else

-      failed_login t('user.login.auth failure')
+      failed_login t("user.login.auth failure")

     end
   end
 
   ##
     end
   end
 
   ##

-  # handle OpenID authentication
-  def openid_authentication(openid_url)
-    # If we don't appear to have a user for this URL then ask the
-    # provider for some extra information to help with signup
-    if openid_url and User.find_by_openid_url(openid_url)
-      required = nil
+  # return the URL to use for authentication
+  def auth_url(provider, uid)
+    if provider == "openid"
+      auth_path(:provider => "openid", :openid_url => openid_expand_url(uid), :origin => request.path)

     else
     else

-      required = [:nickname, :email, "http://axschema.org/namePerson/friendly", "http://axschema.org/contact/email"]
-    end
-
-    # Start the authentication
-    authenticate_with_open_id(openid_expand_url(openid_url), :method => :get, :required => required) do |result, identity_url, sreg, ax|
-      if result.successful?
-        # We need to use the openid url passed back from the OpenID provider
-        # rather than the one supplied by the user, as these can be different.
-        #
-        # For example, you can simply enter yahoo.com in the login box rather
-        # than a user specific url. Only once it comes back from the provider
-        # provider do we know the unique address for the user.
-        if user = User.find_by_openid_url(identity_url)
-          case user.status
-            when "pending" then
-              unconfirmed_login(user)
-            when "active", "confirmed" then
-              successful_login(user)
-            when "suspended" then
-              failed_login t('user.login.account is suspended', :webmaster => "mailto:webmaster@openstreetmap.org")
-            else
-              failed_login t('user.login.auth failure')
-          end
-        else
-          # Guard against not getting any extension data
-          sreg = Hash.new if sreg.nil?
-          ax = Hash.new if ax.nil?
-
-          # We don't have a user registered to this OpenID, so redirect
-          # to the create account page with username and email filled
-          # in if they have been given by the OpenID provider through
-          # the simple registration protocol.
-          nickname = sreg["nickname"] || ax["http://axschema.org/namePerson/friendly"].first
-          email = sreg["email"] || ax["http://axschema.org/contact/email"].first
-
-          redirect_to :controller => 'user', :action => 'new', :nickname => nickname, :email => email, :openid => identity_url
-        end
-      elsif result.missing?
-        failed_login t('user.login.openid missing provider')
-      elsif result.invalid?
-        failed_login t('user.login.openid invalid')
-      else
-        failed_login t('user.login.auth failure')
-      end
-    end
-  end
-
-  ##
-  # verify an OpenID URL
-  def openid_verify(openid_url, user)
-    user.openid_url = openid_url
-
-    authenticate_with_open_id(openid_expand_url(openid_url), :method => :get, :required => [:email, "http://axschema.org/contact/email"]) do |result, identity_url, sreg, ax|
-      if result.successful?
-        # Do we trust the emails this provider returns?
-        if openid_email_verified(identity_url)
-          # Guard against not getting any extension data
-          sreg = Hash.new if sreg.nil?
-          ax = Hash.new if ax.nil?
-
-          # Get the verified email
-          verified_email = sreg["email"] || ax["http://axschema.org/contact/email"].first
-        end
-
-        # We need to use the openid url passed back from the OpenID provider
-        # rather than the one supplied by the user, as these can be different.
-        #
-        # For example, you can simply enter yahoo.com in the login box rather
-        # than a user specific url. Only once it comes back from the provider
-        # provider do we know the unique address for the user.
-        user.openid_url = identity_url
-        yield user, verified_email
-      elsif result.missing?
-        flash.now[:error] = t 'user.login.openid missing provider'
-      elsif result.invalid?
-        flash.now[:error] = t 'user.login.openid invalid'
-      else
-        flash.now[:error] = t 'user.login.auth failure'
-      end
+      auth_path(:provider => provider, :origin => request.path)

     end
   end
 
     end
   end
 


@@ -615,25 +566,17 @@ private
   def openid_expand_url(openid_url)
     if openid_url.nil?
       return nil
   def openid_expand_url(openid_url)
     if openid_url.nil?
       return nil

-    elsif openid_url.match(/(.*)gmail.com(\/?)$/) or openid_url.match(/(.*)googlemail.com(\/?)$/)
+    elsif openid_url.match(/(.*)gmail.com(\/?)$/) || openid_url.match(/(.*)googlemail.com(\/?)$/)

       # Special case gmail.com as it is potentially a popular OpenID
       # provider and, unlike yahoo.com, where it works automatically, Google
       # have hidden their OpenID endpoint somewhere obscure this making it
       # somewhat less user friendly.
       # Special case gmail.com as it is potentially a popular OpenID
       # provider and, unlike yahoo.com, where it works automatically, Google
       # have hidden their OpenID endpoint somewhere obscure this making it
       # somewhat less user friendly.

-      return 'https://www.google.com/accounts/o8/id'
+      return "https://www.google.com/accounts/o8/id"

     else
       return openid_url
     end
   end
 
     else
       return openid_url
     end
   end
 

-  ##
-  # check if we trust an OpenID provider to return a verified
-  # email, so that we can skpi verifying it ourselves
-  def openid_email_verified(openid_url)
-    openid_url.match(/https:\/\/www.google.com\/accounts\/o8\/id?(.*)/) or
-    openid_url.match(/https:\/\/me.yahoo.com\/(.*)/)
-  end
-

   ##
   # process a successful login
   def successful_login(user)
   ##
   # process a successful login
   def successful_login(user)


@@ -648,7 +591,7 @@ private
     # - If they have a block on them, show them that.
     # - If they were referred to the login, send them back there.
     # - Otherwise, send them to the home page.
     # - If they have a block on them, show them that.
     # - If they were referred to the login, send them back there.
     # - Otherwise, send them to the home page.

-    if REQUIRE_TERMS_SEEN and not user.terms_seen
+    if REQUIRE_TERMS_SEEN && !user.terms_seen

       redirect_to :controller => :user, :action => :terms, :referer => target
     elsif user.blocked_on_view
       redirect_to user.blocked_on_view, :referer => target
       redirect_to :controller => :user, :action => :terms, :referer => target
     elsif user.blocked_on_view
       redirect_to user.blocked_on_view, :referer => target


@@ -665,7 +608,7 @@ private
   def failed_login(message)
     flash[:error] = message
 
   def failed_login(message)
     flash[:error] = message
 

-    redirect_to :action => 'login', :referer =>  session[:referer]
+    redirect_to :action => "login", :referer =>  session[:referer]

 
     session.delete(:remember_me)
     session.delete(:referer)
 
     session.delete(:remember_me)
     session.delete(:referer)


@@ -674,7 +617,7 @@ private
   ##
   #
   def unconfirmed_login(user)
   ##
   #
   def unconfirmed_login(user)

-    redirect_to :action => 'confirm', :display_name => user.display_name
+    redirect_to :action => "confirm", :display_name => user.display_name

 
     session.delete(:remember_me)
     session.delete(:referer)
 
     session.delete(:remember_me)
     session.delete(:referer)


@@ -686,7 +629,7 @@ private
     user.display_name = params[:user][:display_name]
     user.new_email = params[:user][:new_email]
 
     user.display_name = params[:user][:display_name]
     user.new_email = params[:user][:new_email]
 

-    if params[:user][:pass_crypt].length > 0 or params[:user][:pass_crypt_confirmation].length > 0
+    if params[:user][:pass_crypt].length > 0 || params[:user][:pass_crypt_confirmation].length > 0

       user.pass_crypt = params[:user][:pass_crypt]
       user.pass_crypt_confirmation = params[:user][:pass_crypt_confirmation]
     end
       user.pass_crypt = params[:user][:pass_crypt]
       user.pass_crypt_confirmation = params[:user][:pass_crypt_confirmation]
     end


@@ -719,21 +662,25 @@ private
       user.preferred_editor = params[:user][:preferred_editor]
     end
 
       user.preferred_editor = params[:user][:preferred_editor]
     end
 

-    user.openid_url = nil if params[:user][:openid_url].blank?
+    if params[:user][:auth_provider].nil? || params[:user][:auth_provider].blank? ||
+       params[:user][:auth_uid].nil? || params[:user][:auth_uid].blank?
+      user.auth_provider = nil
+      user.auth_uid = nil
+    end

 
     if user.save
       set_locale
 
 
     if user.save
       set_locale
 

-      if user.new_email.blank? or user.new_email == user.email
-        flash.now[:notice] = t 'user.account.flash update success'
+      if user.new_email.blank? || user.new_email == user.email
+        flash.now[:notice] = t "user.account.flash update success"

       else
         user.email = user.new_email
 
         if user.valid?
       else
         user.email = user.new_email
 
         if user.valid?

-          flash.now[:notice] = t 'user.account.flash update success confirm needed'
+          flash.now[:notice] = t "user.account.flash update success confirm needed"

 
           begin
 
           begin

-            Notifier.email_confirm(user, user.tokens.create).deliver
+            Notifier.email_confirm(user, user.tokens.create).deliver_now

           rescue
             # Ignore errors sending email
           end
           rescue
             # Ignore errors sending email
           end


@@ -742,7 +689,7 @@ private
           @user.errors.set(:email, [])
         end
 
           @user.errors.set(:email, [])
         end
 

-        user.reset_email!
+        user.restore_email!

       end
     end
   end
       end
     end
   end


@@ -751,16 +698,16 @@ private
   # require that the user is a administrator, or fill out a helpful error message
   # and return them to the user page.
   def require_administrator
   # require that the user is a administrator, or fill out a helpful error message
   # and return them to the user page.
   def require_administrator

-    if @user and not @user.administrator?
-      flash[:error] = t('user.filter.not_an_administrator')
+    if @user && !@user.administrator?
+      flash[:error] = t("user.filter.not_an_administrator")

 
       if params[:display_name]
 
       if params[:display_name]

-        redirect_to :controller => 'user', :action => 'view', :display_name => params[:display_name]
+        redirect_to :controller => "user", :action => "view", :display_name => params[:display_name]

       else
       else

-        redirect_to :controller => 'user', :action => 'login', :referer => request.fullpath
+        redirect_to :controller => "user", :action => "login", :referer => request.fullpath

       end
       end

-    elsif not @user
-      redirect_to :controller => 'user', :action => 'login', :referer => request.fullpath
+    elsif !@user
+      redirect_to :controller => "user", :action => "login", :referer => request.fullpath

     end
   end
 
     end
   end
 


@@ -783,7 +730,7 @@ private
   def lookup_user_by_name
     @this_user = User.find_by_display_name(params[:display_name])
   rescue ActiveRecord::RecordNotFound
   def lookup_user_by_name
     @this_user = User.find_by_display_name(params[:display_name])
   rescue ActiveRecord::RecordNotFound

-    redirect_to :controller => 'user', :action => 'view', :display_name => params[:display_name] unless @this_user
+    redirect_to :controller => "user", :action => "view", :display_name => params[:display_name] unless @this_user

   end
 
   ##
   end
 
   ##


@@ -798,7 +745,9 @@ private
   ##
   # return permitted user parameters
   def user_params
   ##
   # return permitted user parameters
   def user_params

-    params.require(:user).permit(:email, :email_confirmation, :display_name, :openid_url, :pass_crypt, :pass_crypt_confirmation)
+    params.require(:user).permit(:email, :email_confirmation, :display_name,
+                                 :auth_provider, :auth_uid,
+                                 :pass_crypt, :pass_crypt_confirmation)

   end
 
   ##
   end
 
   ##


@@ -813,9 +762,9 @@ private
     if blocked = Acl.no_account_creation(request.remote_ip, domain)
       logger.info "Blocked signup from #{request.remote_ip} for #{email}"
 
     if blocked = Acl.no_account_creation(request.remote_ip, domain)
       logger.info "Blocked signup from #{request.remote_ip} for #{email}"
 

-      render :action => 'blocked'
+      render :action => "blocked"

     end
 
     end
 

-    not blocked
+    !blocked

   end
 end
   end
 end