Localisation updates from https://translatewiki.net.

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 2d638e1e144c35e27393fdf5e30873c1da1c5308..fdc7c35a5343242903305b93d5ec5ab9ff4b2ecf 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2020-09-02 06:16:56 UTC using RuboCop version 0.90.0.
+# on 2023-04-11 16:47:05 UTC using RuboCop version 1.50.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -12,18 +12,26 @@ require:
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails

+  - rubocop-rake

 
 

-# Offense count: 568
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 11
+# Configuration parameters: Include, MaxAmount
+FactoryBot/ExcessiveCreateList:
+  MaxAmount: 200
+
+# Offense count: 557
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.

 # URISchemes: http, https
 Layout/LineLength:
 # URISchemes: http, https
 Layout/LineLength:

-  Max: 370
+  Max: 248

 
 

-# Offense count: 36
+# Offense count: 29
+# This cop supports unsafe autocorrection (--autocorrect-all).

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:

+    - 'app/controllers/accounts_controller.rb'

     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'


@@ -33,96 +41,67 @@ Lint/AssignmentInCondition:
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/helpers/browse_tags_helper.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/helpers/browse_tags_helper.rb'

-    - 'app/mailers/notifier.rb'
+    - 'app/mailers/user_mailer.rb'

     - 'app/models/client_application.rb'
     - 'lib/nominatim.rb'
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'app/models/client_application.rb'
     - 'lib/nominatim.rb'
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 682
-# Configuration parameters: IgnoredMethods.
+# Offense count: 680
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 194
+  Max: 189

 
 

-# Offense count: 72
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
-# ExcludedMethods: refine
+# Offense count: 73
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+# AllowedMethods: refine

 Metrics/BlockLength:
   Max: 71
 
 Metrics/BlockLength:
   Max: 71
 

-# Offense count: 15
+# Offense count: 20

 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 25
+# Offense count: 26

 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:

-  Max: 643
+  Max: 314

 
 

-# Offense count: 68
-# Configuration parameters: IgnoredMethods.
+# Offense count: 59
+# Configuration parameters: AllowedMethods, AllowedPatterns.

 Metrics/CyclomaticComplexity:
 Metrics/CyclomaticComplexity:

-  Max: 26
+  Max: 29

 
 

-# Offense count: 735
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+# Offense count: 753
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.

 Metrics/MethodLength:
   Max: 179
 
 Metrics/MethodLength:
   Max: 179
 

-# Offense count: 4
-# Configuration parameters: CountKeywordArgs.
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.

 Metrics/ParameterLists:
 Metrics/ParameterLists:

-  Max: 9
+  Max: 6

 
 

-# Offense count: 69
-# Configuration parameters: IgnoredMethods.
+# Offense count: 56
+# Configuration parameters: AllowedMethods, AllowedPatterns.

 Metrics/PerceivedComplexity:
 Metrics/PerceivedComplexity:

-  Max: 26
+  Max: 30

 
 

-# Offense count: 540
-Minitest/MultipleAssertions:
-  Max: 81
+# Offense count: 2394
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/EmptyLineBeforeAssertionMethods:
+  Enabled: false

 
 

-# Offense count: 26
-# Cop supports --auto-correct.
-Minitest/TestMethodName:
-  Exclude:
-    - 'test/abilities/api_capability_test.rb'
-    - 'test/controllers/api/nodes_controller_test.rb'
-    - 'test/controllers/api/old_nodes_controller_test.rb'
-    - 'test/controllers/api/relations_controller_test.rb'
-    - 'test/controllers/api/ways_controller_test.rb'
-    - 'test/helpers/browse_helper_test.rb'
-    - 'test/integration/client_applications_test.rb'
-    - 'test/integration/short_links_test.rb'
-    - 'test/integration/user_blocks_test.rb'
-    - 'test/integration/user_creation_test.rb'
+# Offense count: 565
+Minitest/MultipleAssertions:
+  Max: 54

 
 

-# Offense count: 6
-Naming/AccessorMethodName:
-  Exclude:
-    - 'app/controllers/application_controller.rb'
-    - 'app/helpers/title_helper.rb'
-    - 'app/models/old_way.rb'
-    - 'lib/osm.rb'
-    - 'lib/potlatch.rb'
-
-# Offense count: 8
-# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
-# NamePrefix: is_, has_, have_
-# ForbiddenPrefixes: is_, has_, have_
-# AllowedMethods: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicateName:
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ActionControllerFlashBeforeRender:

   Exclude:
   Exclude:

-    - 'spec/**/*'
-    - 'app/models/changeset.rb'
-    - 'app/models/old_node.rb'
-    - 'app/models/old_relation.rb'
-    - 'app/models/old_way.rb'
-    - 'app/models/user.rb'
-    - 'lib/classic_pagination/pagination.rb'
+    - 'app/controllers/traces_controller.rb'

 
 # Offense count: 5
 # Configuration parameters: Database, Include.
 
 # Offense count: 5
 # Configuration parameters: Database, Include.


@@ -142,20 +121,33 @@ Rails/HasAndBelongsToMany:
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 

-# Offense count: 4
+# Offense count: 3

 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 

-# Offense count: 1
-# Cop supports --auto-correct.
+# Offense count: 16
+# Configuration parameters: IgnoreScopes, Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/changeset.rb'
+    - 'app/models/diary_entry.rb'
+    - 'app/models/friendship.rb'
+    - 'app/models/issue.rb'
+    - 'app/models/message.rb'
+    - 'app/models/note.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 2

 # Configuration parameters: Include.
 # Configuration parameters: Include.

-# Include: app/mailers/**/*.rb
-Rails/MailerName:
+# Include: app/controllers/**/*.rb, app/mailers/**/*.rb
+Rails/LexicallyScopedActionFilter:

   Exclude:
   Exclude:

-    - 'app/mailers/notifier.rb'
+    - 'app/controllers/oauth2_applications_controller.rb'
+    - 'app/controllers/oauth2_authorizations_controller.rb'

 
 # Offense count: 5
 # Configuration parameters: Include.
 
 # Offense count: 5
 # Configuration parameters: Include.


@@ -168,66 +160,42 @@ Rails/NotNullColumn:
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 

-# Offense count: 19
+# Offense count: 7

 Rails/OutputSafety:
   Exclude:
 Rails/OutputSafety:
   Exclude:

-    - 'app/controllers/users_controller.rb'

     - 'app/helpers/application_helper.rb'
     - 'app/helpers/application_helper.rb'

-    - 'app/helpers/changesets_helper.rb'
-    - 'app/helpers/geocoder_helper.rb'
-    - 'app/helpers/note_helper.rb'
-    - 'app/helpers/open_graph_helper.rb'
-    - 'app/helpers/user_blocks_helper.rb'

     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 

-# Offense count: 95
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
-  Enabled: false
+# Offense count: 16
+# Configuration parameters: Include.
+# Include: db/**/*.rb
+Rails/ThreeStateBooleanColumn:
+  Exclude:
+    - 'db/migrate/001_create_osm_db.rb'
+    - 'db/migrate/006_tile_nodes.rb'
+    - 'db/migrate/007_add_relations.rb'
+    - 'db/migrate/054_refactor_map_bug_tables.rb'
+    - 'db/migrate/20140507110937_create_changeset_comments.rb'
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+Rake/Desc:
+  Exclude:
+    - 'lib/tasks/auto_annotate_models.rake'
+    - 'lib/tasks/eslint.rake'
+    - 'lib/tasks/subscribe_diary_authors.rake'
+    - 'lib/tasks/subscribe_old_changesets.rake'

 
 

-# Offense count: 572
-# Cop supports --auto-correct.
+# Offense count: 632
+# This cop supports unsafe autocorrection (--autocorrect-all).

 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 

-# Offense count: 78
-# Cop supports --auto-correct.
-# Configuration parameters: Strict.
+# Offense count: 72
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.

 Style/NumericLiterals:
 Style/NumericLiterals:

-  MinDigits: 11
-
-# Offense count: 20
-Style/OptionalBooleanParameter:
-  Exclude:
-    - 'app/controllers/api/notes_controller.rb'
-    - 'app/controllers/application_controller.rb'
-    - 'app/helpers/browse_helper.rb'
-    - 'app/models/changeset.rb'
-    - 'app/models/node.rb'
-    - 'app/models/relation.rb'
-    - 'app/models/trace.rb'
-    - 'app/models/tracepoint.rb'
-    - 'app/models/way.rb'
-    - 'test/models/diary_entry_test.rb'
-    - 'test/models/trace_test.rb'
-    - 'test/models/tracetag_test.rb'
-
-# Offense count: 6
-# Configuration parameters: AllowModifier.
-Style/SoleNestedConditional:
-  Exclude:
-    - 'app/controllers/user_blocks_controller.rb'
-    - 'app/models/old_way.rb'
-    - 'app/validators/characters_validator.rb'
-    - 'app/validators/whitespace_validator.rb'
-    - 'lib/classic_pagination/pagination.rb'
-
-# Offense count: 28
-# Cop supports --auto-correct.
-Style/StringConcatenation:
-  Enabled: false
+  MinDigits: 15