Don't give an error when you access the login page when you are logged in. Instead...

[rails.git] / app / controllers / message_controller.rb

diff --git a/app/controllers/message_controller.rb b/app/controllers/message_controller.rb
index 9dc1d69229348291b9da97d5d9a7bd724c7ad210..d2fa9bd5fa54744d80749285fb9a137d77b0a734 100644 (file)
--- a/app/controllers/message_controller.rb
+++ b/app/controllers/message_controller.rb
@@ -4,11 +4,16 @@ class MessageController < ApplicationController
   before_filter :authorize_web
   before_filter :require_user
 
   before_filter :authorize_web
   before_filter :require_user
 

+  # Allow the user to write a new message to another user. This action also 
+  # deals with the sending of that message to the other user when the user
+  # clicks send.
+  # The user_id param is the id of the user that the message is being sent to.

   def new
     @title = 'send message'
   def new
     @title = 'send message'

+    @to_user = User.find(params[:user_id])

     if params[:message]
       @message = Message.new(params[:message])
     if params[:message]
       @message = Message.new(params[:message])

-      @message.to_user_id = params[:user_id]
+      @message.to_user_id = @to_user.id

       @message.from_user_id = @user.id
       @message.sent_on = Time.now
    
       @message.from_user_id = @user.id
       @message.sent_on = Time.now
    


@@ -17,26 +22,35 @@ class MessageController < ApplicationController
         Notifier::deliver_message_notification(@message)
         redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
       end
         Notifier::deliver_message_notification(@message)
         redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
       end

+    else
+      @title = params[:title]

     end
     end

+  rescue ActiveRecord::RecordNotFound
+    render :action => 'no_such_user', :status => :not_found

   end
 
   end
 

+  # Allow the user to reply to another message.

   def reply
     message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])
   def reply
     message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])

-    title = message.title.sub(/^Re:\s*/, "Re: ")
-    redirect_to :action => 'new', :user_id => message.from_user_id, :title => title
+    @body = "On #{message.sent_on} #{message.sender.display_name} wrote:\n\n#{message.body.gsub(/^/, '> ')}" 
+    @title = "Re: #{message.title.sub(/^Re:\s*/, '')}"
+    @user_id = message.from_user_id
+    render :action => 'new'

   rescue ActiveRecord::RecordNotFound
   rescue ActiveRecord::RecordNotFound

-    render :nothing => true, :status => :not_found
+    render :action => 'no_such_user', :status => :not_found

   end
 
   end
 

+  # Show a message

   def read
     @title = 'read message'
     @message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])
   def read
     @title = 'read message'
     @message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])

-    @message.message_read = 1 if @message.to_user_id == @user.id
+    @message.message_read = true if @message.to_user_id == @user.id

     @message.save
   rescue ActiveRecord::RecordNotFound
     @message.save
   rescue ActiveRecord::RecordNotFound

-    render :nothing => true, :status => :not_found
+    render :action => 'no_such_user', :status => :not_found

   end
 
   end
 

+  # Display the list of messages that have been sent to the user.

   def inbox
     @title = 'inbox'
     if @user and params[:display_name] == @user.display_name
   def inbox
     @title = 'inbox'
     if @user and params[:display_name] == @user.display_name


@@ -45,6 +59,7 @@ class MessageController < ApplicationController
     end
   end
 
     end
   end
 

+  # Display the list of messages that the user has sent to other users.

   def outbox
     @title = 'outbox'
     if @user and params[:display_name] == @user.display_name
   def outbox
     @title = 'outbox'
     if @user and params[:display_name] == @user.display_name


@@ -53,15 +68,16 @@ class MessageController < ApplicationController
     end
   end
 
     end
   end
 

+  # Set the message as being read or unread.

   def mark
     if params[:message_id]
       id = params[:message_id]
       message = Message.find_by_id(id)
       if params[:mark] == 'unread'
   def mark
     if params[:message_id]
       id = params[:message_id]
       message = Message.find_by_id(id)
       if params[:mark] == 'unread'

-        message_read = 0 
+        message_read = false 

         mark_type = 'unread'
       else
         mark_type = 'unread'
       else

-        message_read = 1
+        message_read = true

         mark_type = 'read'
       end
       message.message_read = message_read
         mark_type = 'read'
       end
       message.message_read = message_read


@@ -70,5 +86,7 @@ class MessageController < ApplicationController
         redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
       end
     end
         redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
       end
     end

+  rescue ActiveRecord::RecordNotFound
+    render :action => 'no_such_user', :status => :not_found

   end
 end
   end
 end