Merge remote-tracking branch 'upstream/pull/4425'

[rails.git] / test / models / redaction_test.rb

diff --git a/test/models/redaction_test.rb b/test/models/redaction_test.rb
index 7ea3e458d1138dc2d52dc66a591f383b0255dbf7..06159cb5d79540280f3a62d53fed1b1b0d74da9c 100644 (file)
--- a/test/models/redaction_test.rb
+++ b/test/models/redaction_test.rb
@@ -1,37 +1,36 @@
 require "test_helper"
 require "test_helper"

-require "osm"

 
 class RedactionTest < ActiveSupport::TestCase
   def test_cannot_redact_current
     n = create(:node)
     r = create(:redaction)
 
 class RedactionTest < ActiveSupport::TestCase
   def test_cannot_redact_current
     n = create(:node)
     r = create(:redaction)

-    assert_equal(false, n.redacted?, "Expected node to not be redacted already.")
+    assert_not(n.redacted?, "Expected node to not be redacted already.")

     assert_raise(OSM::APICannotRedactError) do
       n.redact!(r)
     end
   end
 
   def test_cannot_redact_current_via_old
     assert_raise(OSM::APICannotRedactError) do
       n.redact!(r)
     end
   end
 
   def test_cannot_redact_current_via_old

-    node = create(:node)
-    node_v1 = create(:old_node, :node_id => node.id)
+    node = create(:node, :with_history)
+    node_v1 = node.old_nodes.find_by(:version => 1)

     r = create(:redaction)
     r = create(:redaction)

-    assert_equal(false, node_v1.redacted?, "Expected node to not be redacted already.")
+    assert_not(node_v1.redacted?, "Expected node to not be redacted already.")

     assert_raise(OSM::APICannotRedactError) do
       node_v1.redact!(r)
     end
   end
 
   def test_can_redact_old
     assert_raise(OSM::APICannotRedactError) do
       node_v1.redact!(r)
     end
   end
 
   def test_can_redact_old

-    node = create(:node, :version => 2)
-    node_v1 = create(:old_node, :node_id => node.id)
-    node_v2 = create(:old_node, :node_id => node.id, :version => 2)
+    node = create(:node, :with_history, :version => 2)
+    node_v1 = node.old_nodes.find_by(:version => 1)
+    node_v2 = node.old_nodes.find_by(:version => 2)

     r = create(:redaction)
 
     r = create(:redaction)
 

-    assert_equal(false, node_v1.redacted?, "Expected node to not be redacted already.")
-    assert_nothing_raised(OSM::APICannotRedactError) do
+    assert_not(node_v1.redacted?, "Expected node to not be redacted already.")
+    assert_nothing_raised do

       node_v1.redact!(r)
     end
       node_v1.redact!(r)
     end

-    assert_equal(true, node_v1.redacted?, "Expected node version 1 to be redacted after redact! call.")
-    assert_equal(false, node_v2.redacted?, "Expected node version 2 to not be redacted after redact! call.")
+    assert_predicate(node_v1, :redacted?, "Expected node version 1 to be redacted after redact! call.")
+    assert_not(node_v2.redacted?, "Expected node version 2 to not be redacted after redact! call.")

   end
 end
   end
 end