Fix new rubocop warnings

[rails.git] / app / models / acl.rb

diff --git a/app/models/acl.rb b/app/models/acl.rb
index 8bb4ae4b9dd8ebf294419aa141ebeaea5f4d7994..a65c3a35ad68977fe1a1da5f6296c280006145a0 100644 (file)
--- a/app/models/acl.rb
+++ b/app/models/acl.rb
@@ -1,21 +1,51 @@
-class Acl < ActiveRecord::Base
-  def self.match(address, domain = nil)
-    if domain
-      Acl.where("address >>= ? OR domain = ?", address, domain)
-    else
-      Acl.where("address >>= ?", address)
+# == Schema Information
+#
+# Table name: acls
+#
+#  id      :bigint(8)        not null, primary key
+#  address :inet
+#  k       :string           not null
+#  v       :string
+#  domain  :string
+#  mx      :string
+#
+# Indexes
+#
+#  acls_k_idx             (k)
+#  index_acls_on_address  (address) USING gist
+#  index_acls_on_domain   (domain)
+#  index_acls_on_mx       (mx)
+#
+
+class Acl < ApplicationRecord
+  validates :k, :presence => true
+
+  def self.match(address, options = {})
+    acls = Acl.where("address >>= ?", address)
+
+    if options[:domain]
+      labels = options[:domain].split(".")
+
+      until labels.empty?
+        acls = acls.or(Acl.where(:domain => labels.join(".")))
+        labels.shift
+      end

     end
     end

+
+    acls = acls.or(Acl.where(:mx => options[:mx])) if options[:mx]
+
+    acls

   end
 
   end
 

-  def self.no_account_creation(address, domain = nil)
-    match(address, domain).where(:k => "no_account_creation").exists?
+  def self.no_account_creation(address, options = {})
+    match(address, options).exists?(:k => "no_account_creation")

   end
 
   def self.no_note_comment(address, domain = nil)
   end
 
   def self.no_note_comment(address, domain = nil)

-    match(address, domain).where(:k => "no_note_comment").exists?
+    match(address, :domain => domain).exists?(:k => "no_note_comment")

   end
 
   def self.no_trace_download(address, domain = nil)
   end
 
   def self.no_trace_download(address, domain = nil)

-    match(address, domain).where(:k => "no_trace_download").exists?
+    match(address, :domain => domain).exists?(:k => "no_trace_download")

   end
 end
   end
 end