Merge pull request #5070 from tomhughes/rails72

[rails.git] / app / helpers / geocoder_helper.rb

diff --git a/app/helpers/geocoder_helper.rb b/app/helpers/geocoder_helper.rb
index ce6c7eafa71f68065872e116fd1906827726437f..882f2c8354eb73e2415371b54a8871d0b1359386 100644 (file)
--- a/app/helpers/geocoder_helper.rb
+++ b/app/helpers/geocoder_helper.rb
@@ -1,25 +1,26 @@
 module GeocoderHelper
   def result_to_html(result)
 module GeocoderHelper
   def result_to_html(result)

-    html_options = { :class => "set_position", :data => {} }
+    html_options = { :class => "set_position stretched-link", :data => {} }

 
 

-    if result[:type] and result[:id]
-      url = url_for(:controller => :browse, :action => result[:type], :id => result[:id])
-    elsif result[:min_lon] and result[:min_lat] and result[:max_lon] and result[:max_lat]
-      url = "?minlon=#{result[:min_lon]}&minlat=#{result[:min_lat]}&maxlon=#{result[:max_lon]}&maxlat=#{result[:max_lat]}"
-    else
-      url = "?mlat=#{result[:lat]}&mlon=#{result[:lon]}&zoom=#{result[:zoom]}"
-    end
+    url = if result[:type] && result[:id]
+            url_for(:controller => result[:type].pluralize, :action => :show, :id => result[:id])
+          elsif result[:min_lon] && result[:min_lat] && result[:max_lon] && result[:max_lat]
+            "/?bbox=#{result[:min_lon]},#{result[:min_lat]},#{result[:max_lon]},#{result[:max_lat]}"
+          else
+            "/#map=#{result[:zoom]}/#{result[:lat]}/#{result[:lon]}"
+          end

 
 

-    result.each do |key,value|
-      html_options[:data][key.to_s.tr('_', '-')] = value
+    result.each do |key, value|
+      html_options[:data][key.to_s.tr("_", "-")] = value

     end
 
     end
 

-    html = ""
+    html = []

     html << result[:prefix] if result[:prefix]
     html << result[:prefix] if result[:prefix]

-    html << " " if result[:prefix] and result[:name]
+    html << " " if result[:prefix] && result[:name]

     html << link_to(result[:name], url, html_options) if result[:name]
     html << link_to(result[:name], url, html_options) if result[:name]

+    html << " " if result[:suffix] && result[:name]

     html << result[:suffix] if result[:suffix]
     html << result[:suffix] if result[:suffix]

-    html.html_safe
+    safe_join(html)

   end
 
   def describe_location(lat, lon, zoom = nil, language = nil)
   end
 
   def describe_location(lat, lon, zoom = nil, language = nil)