Fix 2402 PR lint errors

[rails.git] / db / migrate / 021_move_to_innodb.rb

diff --git a/db/migrate/021_move_to_innodb.rb b/db/migrate/021_move_to_innodb.rb
index da0488ca5f7a3d6bb40f6ccc7717ceb34487096e..47ebecc835aa16d6ef0ed088d075dffbe0584fed 100644 (file)
--- a/db/migrate/021_move_to_innodb.rb
+++ b/db/migrate/021_move_to_innodb.rb
@@ -1,45 +1,39 @@
-class MoveToInnodb < ActiveRecord::Migration
-  @@conv_tables = ['nodes', 'ways', 'way_tags', 'way_nodes',
-    'current_way_tags', 'relation_members',
-    'relations', 'relation_tags', 'current_relation_tags']
+require "migrate"
 
-  @@ver_tbl = ['nodes', 'ways', 'relations']
+class MoveToInnodb < ActiveRecord::Migration[4.2]
+  @conv_tables = %w[nodes ways way_tags way_nodes current_way_tags relation_members relations relation_tags current_relation_tags]
 
-  def self.up
-    remove_index :current_way_tags, :name=> :current_way_tags_v_idx
-    remove_index :current_relation_tags, :name=> :current_relation_tags_v_idx
+  @ver_tbl = %w[nodes ways relations]
 
-    @@ver_tbl.each { |tbl|
-      change_column tbl, "version", :bigint, :limit => 20, :null => false
-    }
+  def self.up
+    remove_index :current_way_tags, :name => :current_way_tags_v_idx
+    remove_index :current_relation_tags, :name => :current_relation_tags_v_idx
 
-    @@conv_tables.each { |tbl|
-      change_engine (tbl, "InnoDB")
-    }
+    @ver_tbl.each do |tbl|
+      change_column tbl, "version", :bigint, :null => false
+    end
 
-    @@ver_tbl.each { |tbl|
-      add_column "current_#{tbl}", "version", :bigint, :limit => 20, :null => false
-      # As the initial version of all nodes, ways and relations is 0, we set the 
-      # current version to something less so that we can update the version in 
+    @ver_tbl.each do |tbl|
+      add_column "current_#{tbl}", "version", :bigint, :null => false
+      # As the initial version of all nodes, ways and relations is 0, we set the
+      # current version to something less so that we can update the version in
       # batches of 10000
-      tbl.classify.constantize.update_all("version=-1")
-      while tbl.classify.constantize.count(:conditions => {:version => -1}) > 0
-        tbl.classify.constantize.update_all("version=(SELECT max(version) FROM #{tbl} WHERE #{tbl}.id = current_#{tbl}.id)", {:version => -1}, :limit => 10000)
-      end
-     # execute "UPDATE current_#{tbl} SET version = " +
+      tbl.classify.constantize.update_all(:version => -1)
+      tbl.classify.constantize.update_all("version=(SELECT max(version) FROM #{tbl} WHERE #{tbl}.id = current_#{tbl}.id)", { :version => -1 }, { :limit => 10000 }) while tbl.classify.constantize.where(:version => -1).count.positive?
+      # execute "UPDATE current_#{tbl} SET version = " +
       #  "(SELECT max(version) FROM #{tbl} WHERE #{tbl}.id = current_#{tbl}.id)"
-        # The above update causes a MySQL error:
-        # -- add_column("current_nodes", "version", :bigint, {:null=>false, :limit=>20})
-        # -> 1410.9152s
-        # -- execute("UPDATE current_nodes SET version = (SELECT max(version) FROM nodes WHERE nodes.id = current_nodes.id)")
-        # rake aborted!
-        # Mysql::Error: The total number of locks exceeds the lock table size: UPDATE current_nodes SET version = (SELECT max(version) FROM nodes WHERE nodes.id = current_nodes.id)
+      # The above update causes a MySQL error:
+      # -- add_column("current_nodes", "version", :bigint, {:null=>false, :limit=>20})
+      # -> 1410.9152s
+      # -- execute("UPDATE current_nodes SET version = (SELECT max(version) FROM nodes WHERE nodes.id = current_nodes.id)")
+      # rake aborted!
+      # Mysql::Error: The total number of locks exceeds the lock table size: UPDATE current_nodes SET version = (SELECT max(version) FROM nodes WHERE nodes.id = current_nodes.id)
 
-        # The above rails version will take longer, however will no run out of locks
-    }
+      # The above rails version will take longer, however will no run out of locks
+    end
   end
 
   def self.down
-    raise IrreversibleMigration.new
+    raise ActiveRecord::IrreversibleMigration
   end
 end