Added a consistency check that both ids are valid and match. Fixed diff upload code...

[rails.git] / lib / osm.rb

diff --git a/lib/osm.rb b/lib/osm.rb
index 223e351f4c60a0e4790a6d45ee89f36541ede7f9..a392b88a825f54b5b0963b3c97437c8aaf16221b 100644 (file)
--- a/lib/osm.rb
+++ b/lib/osm.rb
@@ -11,46 +11,77 @@ module OSM
   # The base class for API Errors.
   class APIError < RuntimeError
     def render_opts
   # The base class for API Errors.
   class APIError < RuntimeError
     def render_opts

-      { :text => "", :status => :internal_server_error }
+      { :text => "Generic API Error", :status => :internal_server_error, :content_type => "text/plain" }
+    end
+
+    def to_s
+      "Generic API Error"

     end
   end
 
   # Raised when an API object is not found.
   class APINotFoundError < APIError
     end
   end
 
   # Raised when an API object is not found.
   class APINotFoundError < APIError

+    def render_opts
+      { :text => "The API wasn't found", :status => :not_found, :content_type => "text/plain" }
+    end

   end
 
   # Raised when a precondition to an API action fails sanity check.
   class APIPreconditionFailedError < APIError
   end
 
   # Raised when a precondition to an API action fails sanity check.
   class APIPreconditionFailedError < APIError

+    def initialize(message = "")
+      @message = message
+    end
+    

     def render_opts
     def render_opts

-      { :text => "", :status => :precondition_failed }
+      { :text => "Precondition failed: #{@message}", :status => :precondition_failed, :content_type => "text/plain" }
+    end
+
+    def to_s
+      "Precondition failed: #{@message}"

     end
   end
 
   # Raised when to delete an already-deleted object.
   class APIAlreadyDeletedError < APIError
     end
   end
 
   # Raised when to delete an already-deleted object.
   class APIAlreadyDeletedError < APIError

+    def initialize(object = "object", object_id = "")
+      @object, @object_id = object, object_id
+    end
+    
+    attr_reader :object, :object_id
+    

     def render_opts
     def render_opts

-      { :text => "", :status => :gone }
+      { :text => "The #{object} with the id #{object_id} has already been deleted", :status => :gone, :content_type => "text/plain" }

     end
   end
 
   # Raised when the user logged in isn't the same as the changeset
   class APIUserChangesetMismatchError < APIError
     def render_opts
     end
   end
 
   # Raised when the user logged in isn't the same as the changeset
   class APIUserChangesetMismatchError < APIError
     def render_opts

-      { :text => "The user doesn't own that changeset", :status => :conflict }
+      { :text => "The user doesn't own that changeset", :status => :conflict, :content_type => "text/plain" }

     end
   end
 
   # Raised when the changeset provided is already closed
   class APIChangesetAlreadyClosedError < APIError
     end
   end
 
   # Raised when the changeset provided is already closed
   class APIChangesetAlreadyClosedError < APIError

+    def initialize(changeset)
+      @changeset = changeset
+    end
+
+    attr_reader :changeset
+    

     def render_opts
     def render_opts

-      { :text => "The supplied changeset has already been closed", :status => :conflict }
+      { :text => "The changeset #{@changeset.id} was closed at #{@changeset.closed_at}.", :status => :conflict, :content_type => "text/plain" }

     end
   end
   
   # Raised when a change is expecting a changeset, but the changeset doesn't exist
   class APIChangesetMissingError < APIError
     def render_opts
     end
   end
   
   # Raised when a change is expecting a changeset, but the changeset doesn't exist
   class APIChangesetMissingError < APIError
     def render_opts

-      { :text => "You need to supply a changeset to be able to make a change", :status => :conflict }
+      { :text => "You need to supply a changeset to be able to make a change", :status => :conflict, :content_type => "text/plain" }
+    end
+    
+    def to_s
+       "You need to supply a changeset to be able to make a change"

     end
   end
 
     end
   end
 


@@ -63,7 +94,7 @@ module OSM
     
     def render_opts
       { :text => "Changeset mismatch: Provided #{@provided} but only " +
     
     def render_opts
       { :text => "Changeset mismatch: Provided #{@provided} but only " +

-        "#{@allowed} is allowed.", :status => :conflict }
+      "#{@allowed} is allowed.", :status => :conflict, :content_type => "text/plain" }

     end
   end
   
     end
   end
   


@@ -76,34 +107,39 @@ module OSM
     
     def render_opts
       { :text => "Unknown action #{@provided}, choices are create, modify, delete.",
     
     def render_opts
       { :text => "Unknown action #{@provided}, choices are create, modify, delete.",

-      :status => :bad_request }
+      :status => :bad_request, :content_type => "text/plain" }

     end
   end
 
   # Raised when bad XML is encountered which stops things parsing as
   # they should.
   class APIBadXMLError < APIError
     end
   end
 
   # Raised when bad XML is encountered which stops things parsing as
   # they should.
   class APIBadXMLError < APIError

-    def initialize(model, xml)
-      @model, @xml = model, xml
+    def initialize(model, xml, message="")
+      @model, @xml, @message = model, xml, message

     end
 
     def render_opts
     end
 
     def render_opts

-      { :text => "Cannot parse valid #{@model} from xml string #{@xml}",
-        :status => :bad_request }
+      { :text => "Cannot parse valid #{@model} from xml string #{@xml}. #{@message}",
+      :status => :bad_request, :content_type => "text/plain" }

     end
   end
 
   # Raised when the provided version is not equal to the latest in the db.
   class APIVersionMismatchError < APIError
     end
   end
 
   # Raised when the provided version is not equal to the latest in the db.
   class APIVersionMismatchError < APIError

-    def initialize(provided, latest)
-      @provided, @latest = provided, latest
+    def initialize(id, type, provided, latest)
+      @id, @type, @provided, @latest = id, type, provided, latest

     end
 
     end
 

-    attr_reader :provided, :latest
+    attr_reader :provided, :latest, :id, :type

 
     def render_opts
       { :text => "Version mismatch: Provided " + provided.to_s +
 
     def render_opts
       { :text => "Version mismatch: Provided " + provided.to_s +

-      ", server had: " + latest.to_s, :status => :conflict }
+        ", server had: " + latest.to_s + " of " + type + " " + id.to_s, 
+        :status => :conflict, :content_type => "text/plain" }
+    end
+    
+    def to_s
+       "Version mismatch: Provided " + provided.to_s + ", server had: " + latest.to_s + " of " + type + " " + id.to_s

     end
   end
 
     end
   end
 


@@ -118,7 +154,7 @@ module OSM
 
     def render_opts
       { :text => "Element #{@type}/#{@id} has duplicate tags with key #{@tag_key}.",
 
     def render_opts
       { :text => "Element #{@type}/#{@id} has duplicate tags with key #{@tag_key}.",

-        :status => :bad_request }
+        :status => :bad_request, :content_type => "text/plain" }

     end
   end
   
     end
   end
   


@@ -133,7 +169,19 @@ module OSM
     
     def render_opts
       { :text => "You tried to add #{provided} nodes to the way, however only #{max} are allowed",
     
     def render_opts
       { :text => "You tried to add #{provided} nodes to the way, however only #{max} are allowed",

-      :status => :bad_request }
+        :status => :bad_request, :content_type => "text/plain" }
+    end
+  end
+
+  ##
+  # raised when user input couldn't be parsed
+  class APIBadUserInput < APIError
+    def initialize(message)
+      @message = message
+    end
+
+    def render_opts
+      { :text => @message, :content_type => "text/plain", :status => :bad_request }

     end
   end
 
     end
   end
 


@@ -214,7 +262,7 @@ module OSM
   class GeoRSS
     def initialize(feed_title='OpenStreetMap GPS Traces', feed_description='OpenStreetMap GPS Traces', feed_url='http://www.openstreetmap.org/traces/')
       @doc = XML::Document.new
   class GeoRSS
     def initialize(feed_title='OpenStreetMap GPS Traces', feed_description='OpenStreetMap GPS Traces', feed_url='http://www.openstreetmap.org/traces/')
       @doc = XML::Document.new

-      @doc.encoding = 'UTF-8' 
+      @doc.encoding = XML::Encoding::UTF_8

 
       rss = XML::Node.new 'rss'
       @doc.root = rss
 
       rss = XML::Node.new 'rss'
       @doc.root = rss


@@ -300,7 +348,7 @@ module OSM
   class API
     def get_xml_doc
       doc = XML::Document.new
   class API
     def get_xml_doc
       doc = XML::Document.new

-      doc.encoding = 'UTF-8' 
+      doc.encoding = XML::Encoding::UTF_8

       root = XML::Node.new 'osm'
       root['version'] = API_VERSION
       root['generator'] = GENERATOR
       root = XML::Node.new 'osm'
       root['version'] = API_VERSION
       root['generator'] = GENERATOR


@@ -314,16 +362,8 @@ module OSM
       Net::HTTP.start('api.hostip.info') do |http|
         country = http.get("/country.php?ip=#{ip_address}").body
         country = "GB" if country == "UK"
       Net::HTTP.start('api.hostip.info') do |http|
         country = http.get("/country.php?ip=#{ip_address}").body
         country = "GB" if country == "UK"

-        Net::HTTP.start('ws.geonames.org') do |http|
-          xml = REXML::Document.new(http.get("/countryInfo?country=#{country}").body)
-          xml.elements.each("geonames/country") do |ele|
-            minlon = ele.get_text("bBoxWest").to_s
-            minlat = ele.get_text("bBoxSouth").to_s
-            maxlon = ele.get_text("bBoxEast").to_s
-            maxlat = ele.get_text("bBoxNorth").to_s
-            return { :minlon => minlon, :minlat => minlat, :maxlon => maxlon, :maxlat => maxlat }
-          end
-        end
+        country = Country.find_by_code(country)
+        return { :minlon => country.min_lon, :minlat => country.min_lat, :maxlon => country.max_lon, :maxlat => country.max_lat }

       end
     end
 
       end
     end