Cope with results from the OSM Namefinder that have no name.

[rails.git] / app / controllers / geocoder_controller.rb

diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb
index 7d434f19a3b2ec4e9332b0374479d1edbf36c796..69c35e0e3c23e2fc36ba254946d69bb2dbb79f8d 100644 (file)
--- a/app/controllers/geocoder_controller.rb
+++ b/app/controllers/geocoder_controller.rb
@@ -1,49 +1,165 @@
 class GeocoderController < ApplicationController
 class GeocoderController < ApplicationController

-  layout 'site'
-
+  require 'uri'

   require 'net/http'
   require 'rexml/document'
 
   def search
   require 'net/http'
   require 'rexml/document'
 
   def search

-    res_hash = {}
-    @postcode_arr = []
-    @res_ary = []
-
-    if params[:query][:postcode] 
-      postcode = params[:query][:postcode]
-      if postcode.match(/(^\d{5}$)|(^\d{5}-\d{4}$)/)
-        #its a zip code - do something
+    @query = params[:query]
+    @results = Array.new
+
+    if @query.match(/^\d{5}(-\d{4})?$/)
+      @results.push search_us_postcode(@query)
+    elsif @query.match(/(GIR 0AA|[A-PR-UWYZ]([0-9]{1,2}|([A-HK-Y][0-9]|[A-HK-Y][0-9]([0-9]|[ABEHMNPRV-Y]))|[0-9][A-HJKS-UW])\s*[0-9][ABD-HJLNP-UW-Z]{2})/i)
+      @results.push search_uk_postcode(@query)
+    elsif @query.match(/[A-Z]\d[A-Z]\s*\d[A-Z]\d/i)
+      @results.push search_ca_postcode(@query)
+    else
+      @results.push search_osm_namefinder(@query)
+      @results.push search_geonames(@query)
+    end
+  end
+
+private
+
+  def search_us_postcode(query)
+    results = Array.new
+
+    # ask geocoder.us (they have a non-commercial use api)
+    response = fetch_text("http://rpc.geocoder.us/service/csv?zip=#{URI.escape(query)}")
+
+    # parse the response
+    unless response.match(/couldn't find this zip/)
+      data = response.split(/\s*,\s+/) # lat,long,town,state,zip
+      results.push({:lat => data[0], :lon => data[1], :zoom => 12,
+                    :prefix => "#{data[2]}, #{data[3]}, ",
+                    :name => data[4]})
+    end
+
+    return { :source => "Geocoder.us", :url => "http://geocoder.us/", :results => results }
+  rescue Exception => ex
+    return { :source => "Geocoder.us", :url => "http://geocoder.us/", :error => "Error contacting rpc.geocoder.us: #{ex.to_s}" }
+  end
+
+  def search_uk_postcode(query)
+    results = Array.new
+
+    # ask npemap.org.uk to do a combined npemap + freethepostcode search
+    response = fetch_text("http://www.npemap.org.uk/cgi/geocoder.fcgi?format=text&postcode=#{URI.escape(query)}")
+
+    # parse the response
+    unless response.match(/Error/)
+      dataline = response.split(/\n/)[1]
+      data = dataline.split(/,/) # easting,northing,postcode,lat,long
+      results.push({:lat => data[3], :lon => data[4], :zoom => 12,
+                    :name => data[2].gsub(/'/, "")})
+    end
+
+    return { :source => "NPEMap / FreeThePostcode", :url => "http://www.npemap.org.uk/", :results => results }
+  rescue Exception => ex
+    return { :source => "NPEMap / FreeThePostcode", :url => "http://www.npemap.org.uk/", :error => "Error contacting www.npemap.org.uk: #{ex.to_s}" }
+  end
+
+  def search_ca_postcode(query)
+    results = Array.new
+
+    # ask geocoder.ca (note - they have a per-day limit)
+    response = fetch_xml("http://geocoder.ca/?geoit=XML&postal=#{URI.escape(query)}")
+
+    # parse the response
+    unless response.get_elements("geodata/error")
+      results.push({:lat => response.get_text("geodata/latt").to_s,
+                    :lon => response.get_text("geodata/longt").to_s,
+                    :zoom => 12,
+                    :name => query.upcase})
+    end
+
+    return { :source => "Geocoder.CA", :url => "http://geocoder.ca/", :results => results }
+  rescue Exception => ex
+    return { :source => "Geocoder.CA", :url => "http://geocoder.ca/", :error => "Error contacting geocoder.ca: #{ex.to_s}" }
+  end
+
+  def search_osm_namefinder(query)
+    results = Array.new
+
+    # ask OSM namefinder
+    response = fetch_xml("http://www.frankieandshadow.com/osm/search.xml?find=#{URI.escape(query)}")
+
+    # parse the response
+    response.elements.each("searchresults/named") do |named|
+      lat = named.attributes["lat"].to_s
+      lon = named.attributes["lon"].to_s
+      zoom = named.attributes["zoom"].to_s
+      place = named.elements["place/named"] || named.elements["nearestplaces/named"]
+      type = named.attributes["info"].to_s.capitalize
+      name = named.attributes["name"].to_s
+      description = named.elements["description"].to_s
+      if name.empty?
+        prefix = ""
+        name = type

       else
       else

-        Net::HTTP.start('www.freethepostcode.org') do |http|
-          resp = http.get("/geocode?postcode=#{postcode}")
-          lat = resp.body.scan(/[4-6][0-9]\.?[0-9]+/)
-          lon = resp.body.scan(/[-+][0-9]\.?[0-9]+/)
-          @postcode_array = [lat, lon]
-          redirect_to "/index.html?lat=#{@postcode_array[0]}&lon=#{@postcode_array[1]}&zoom=14"
-        end
+        prefix = "#{type} "

       end
       end

-    else
-      if params[:query][:place_name] != nil or "" 
-        place_name = params[:query][:place_name]
-        Net::HTTP.start('ws.geonames.org') do |http|
-          res = http.get("/search?q=#{place_name}&maxRows=10")
-          xml = REXML::Document.new(res.body)
-          xml.elements.each("geonames/geoname") do |ele|
-            res_hash = {}
-            ele.elements.each("name"){ |n| res_hash['name'] = n.text }
-            ele.elements.each("countryCode"){ |n| res_hash['country_code'] = n.text }
-            ele.elements.each("countryNode"){ |n| res_hash['country_name'] = n.text }
-            ele.elements.each("lat"){ |n| res_hash['lat'] = n.text }
-            ele.elements.each("lng"){ |n| res_hash['lon']= n.text }
-            @res_ary << res_hash
-          end 
-        end
+      if place
+        distance = format_distance(place.attributes["approxdistance"].to_i)
+        direction = format_direction(place.attributes["direction"].to_i)
+        placename = place.attributes["name"].to_s
+        suffix = ", #{distance} #{direction} of #{placename}"
+      else
+        suffix = ""

       end
       end

-      redirect_to :controller => 'geocoder', :action => 'results', :params => @res_ary
+      results.push({:lat => lat, :lon => lon, :zoom => zoom,
+                    :prefix => prefix, :name => name, :suffix => suffix,
+                    :description => description})

     end
     end

+
+    return { :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :results => results }
+  rescue Exception => ex
+    return { :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :error => "Error contacting www.frankieandshadow.com: #{ex.to_s}" }
+  end
+
+  def search_geonames(query)
+    results = Array.new
+
+    # ask geonames.org
+    response = fetch_xml("http://ws.geonames.org/search?q=#{URI.escape(query)}&maxRows=20")
+
+    # parse the response
+    response.elements.each("geonames/geoname") do |geoname|
+      lat = geoname.get_text("lat").to_s
+      lon = geoname.get_text("lng").to_s
+      name = geoname.get_text("name").to_s
+      country = geoname.get_text("countryName").to_s
+      results.push({:lat => lat, :lon => lon, :zoom => 12,
+                    :name => name,
+                    :suffix => ", #{country}"})
+    end
+
+    return { :source => "GeoNames", :url => "http://www.geonames.org/", :results => results }
+  rescue Exception => ex
+    return { :source => "GeoNames", :url => "http://www.geonames.org/", :error => "Error contacting ws.geonames.org: #{ex.to_s}" }
+  end
+
+  def fetch_text(url)
+    return Net::HTTP.get(URI.parse(url))
+  end
+
+  def fetch_xml(url)
+    return REXML::Document.new(fetch_text(url))
+  end
+
+  def format_distance(distance)
+    return "less than 1km" if distance == 0
+    return "about #{distance}km"

   end
 
   end
 

-  def result
-    @res = :params[@res_ary]
+  def format_direction(bearing)
+    return "south-west" if bearing >= 22.5 and bearing < 67.5
+    return "south" if bearing >= 67.5 and bearing < 112.5
+    return "south-east" if bearing >= 112.5 and bearing < 157.5
+    return "east" if bearing >= 157.5 and bearing < 202.5
+    return "north-east" if bearing >= 202.5 and bearing < 247.5
+    return "north" if bearing >= 247.5 and bearing < 292.5
+    return "north-west" if bearing >= 292.5 and bearing < 337.5
+    return "west"

   end
 end
   end
 end