Remove no longer needed rubocop exemptions

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 809cde374d470abfb57c755a369189dc1b73d34a..06a9c76f07b2ac4dcf2752113aa2cfee8dc5f45b 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,12 +1,25 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2019-06-05 09:04:25 +0100 using RuboCop version 0.71.0.
+# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 

-# Offense count: 33
+# Work around erblint issues.
+# https://github.com/openstreetmap/openstreetmap-website/issues/2472
+require:
+  - rubocop-performance
+  - rubocop-rails
+
+# Offense count: 3338
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 260
+
+# Offense count: 35

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:


@@ -27,16 +40,17 @@ Lint/AssignmentInCondition:
 
 # Offense count: 4
 # Configuration parameters: AllowComments.
 
 # Offense count: 4
 # Configuration parameters: AllowComments.

-Lint/HandleExceptions:
+Lint/SuppressedException:

   Exclude:
     - 'app/controllers/api/amf_controller.rb'
     - 'app/controllers/users_controller.rb'
   Exclude:
     - 'app/controllers/api/amf_controller.rb'
     - 'app/controllers/users_controller.rb'

+    - 'app/controllers/site_controller.rb'

 
 

-# Offense count: 703
+# Offense count: 701

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 279
+  Max: 189

 
 

-# Offense count: 40
+# Offense count: 39

 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:


@@ -47,31 +61,31 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 5
 
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 68
+# Offense count: 25

 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 645
 
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 645
 

-# Offense count: 73
+# Offense count: 74

 Metrics/CyclomaticComplexity:
   Max: 22
 
 Metrics/CyclomaticComplexity:
   Max: 22
 

-# Offense count: 714
+# Offense count: 722

 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 179
 
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 179
 

-# Offense count: 1
+# Offense count: 2

 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:

-  Max: 107
+  Max: 117

 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 
 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 

-# Offense count: 71
+# Offense count: 72

 Metrics/PerceivedComplexity:
   Max: 25
 
 Metrics/PerceivedComplexity:
   Max: 25
 


@@ -100,6 +114,14 @@ Naming/PredicateName:
     - 'app/models/user.rb'
     - 'lib/classic_pagination/pagination.rb'
 
     - 'app/models/user.rb'
     - 'lib/classic_pagination/pagination.rb'
 

+# Offense count: 5
+# Cop supports --auto-correct.
+Performance/RegexpMatch:
+  Exclude:
+    - 'app/helpers/browse_tags_helper.rb'
+    - 'app/validators/characters_validator.rb'
+    - 'app/validators/whitespace_validator.rb'
+

 # Offense count: 6
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql
 # Offense count: 6
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql


@@ -165,11 +187,20 @@ Style/AsciiComments:
   Exclude:
     - 'test/models/message_test.rb'
 
   Exclude:
     - 'test/models/message_test.rb'
 

-# Offense count: 255
-Style/Documentation:
-  Enabled: false
-
-# Offense count: 503
+# Offense count: 27
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  Exclude:
+    - 'app/models/concerns/geo_record.rb'
+    - 'app/views/api/map/_bounds.xml.builder'
+    - 'lib/bounding_box.rb'
+    - 'test/controllers/api/map_controller_test.rb'
+    - 'test/controllers/api/relations_controller_test.rb'
+    - 'test/controllers/api/ways_controller_test.rb'
+    - 'test/lib/bounding_box_test.rb'
+
+# Offense count: 539

 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, never
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, never


@@ -182,15 +213,8 @@ Style/IfUnlessModifier:
   Exclude:
     - 'app/controllers/api/ways_controller.rb'
 
   Exclude:
     - 'app/controllers/api/ways_controller.rb'
 

-# Offense count: 74
+# Offense count: 70

 # Cop supports --auto-correct.
 # Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 11
 # Cop supports --auto-correct.
 # Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 11

-
-# Offense count: 3320
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 307