Revert changes where the user is a query parameter

[rails.git] / test / controllers / site_controller_test.rb

diff --git a/test/controllers/site_controller_test.rb b/test/controllers/site_controller_test.rb
index 70eacb3aa9bbb6868b57e8528658fa7201e97874..37f4575233e68c34007f3634d5d3cbdcf0963acb 100644 (file)
--- a/test/controllers/site_controller_test.rb
+++ b/test/controllers/site_controller_test.rb
@@ -6,8 +6,10 @@ class SiteControllerTest < ActionController::TestCase
   ##
   # setup oauth keys
   def setup
   ##
   # setup oauth keys
   def setup

-    Object.const_set("ID_KEY", client_applications(:oauth_web_app).key)
-    Object.const_set("POTLATCH2_KEY", client_applications(:oauth_web_app).key)
+    Object.const_set("ID_KEY", create(:client_application).key)
+    Object.const_set("POTLATCH2_KEY", create(:client_application).key)
+
+    stub_hostip_requests

   end
 
   ##
   end
 
   ##


@@ -170,7 +172,7 @@ class SiteControllerTest < ActionController::TestCase
 
   # Test the right editor gets used when the user hasn't set a preference
   def test_edit_without_preference
 
   # Test the right editor gets used when the user hasn't set a preference
   def test_edit_without_preference

-    get :edit, nil, :user => users(:public_user).id
+    get :edit, nil, :user => users(:public_user)

     assert_response :success
     assert_template "edit"
     assert_template :partial => "_#{DEFAULT_EDITOR}", :count => 1
     assert_response :success
     assert_template "edit"
     assert_template :partial => "_#{DEFAULT_EDITOR}", :count => 1


@@ -182,7 +184,7 @@ class SiteControllerTest < ActionController::TestCase
     user.preferred_editor = "id"
     user.save!
 
     user.preferred_editor = "id"
     user.save!
 

-    get :edit, nil, :user => user.id
+    get :edit, nil, :user => user

     assert_response :success
     assert_template "edit"
     assert_template :partial => "_id", :count => 1
     assert_response :success
     assert_template "edit"
     assert_template :partial => "_id", :count => 1


@@ -191,7 +193,7 @@ class SiteControllerTest < ActionController::TestCase
     user.preferred_editor = "potlatch2"
     user.save!
 
     user.preferred_editor = "potlatch2"
     user.save!
 

-    get :edit, nil, :user => user.id
+    get :edit, nil, :user => user

     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch2", :count => 1
     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch2", :count => 1


@@ -200,7 +202,7 @@ class SiteControllerTest < ActionController::TestCase
     user.preferred_editor = "potlatch"
     user.save!
 
     user.preferred_editor = "potlatch"
     user.save!
 

-    get :edit, nil, :user => user.id
+    get :edit, nil, :user => user

     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch", :count => 1
     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch", :count => 1


@@ -209,29 +211,29 @@ class SiteControllerTest < ActionController::TestCase
     user.preferred_editor = "remote"
     user.save!
 
     user.preferred_editor = "remote"
     user.save!
 

-    get :edit, nil, :user => user.id
+    get :edit, nil, :user => user

     assert_response :success
     assert_template "index"
   end
 
   # Test the right editor gets used when the URL has an override
   def test_edit_with_override
     assert_response :success
     assert_template "index"
   end
 
   # Test the right editor gets used when the URL has an override
   def test_edit_with_override

-    get :edit, { :editor => "id" }, { :user => users(:public_user).id }
+    get :edit, { :editor => "id" }, { :user => users(:public_user) }

     assert_response :success
     assert_template "edit"
     assert_template :partial => "_id", :count => 1
 
     assert_response :success
     assert_template "edit"
     assert_template :partial => "_id", :count => 1
 

-    get :edit, { :editor => "potlatch2" }, { :user => users(:public_user).id }
+    get :edit, { :editor => "potlatch2" }, { :user => users(:public_user) }

     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch2", :count => 1
 
     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch2", :count => 1
 

-    get :edit, { :editor => "potlatch" }, { :user => users(:public_user).id }
+    get :edit, { :editor => "potlatch" }, { :user => users(:public_user) }

     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch", :count => 1
 
     assert_response :success
     assert_template "edit"
     assert_template :partial => "_potlatch", :count => 1
 

-    get :edit, { :editor => "remote" }, { :user => users(:public_user).id }
+    get :edit, { :editor => "remote" }, { :user => users(:public_user) }

     assert_response :success
     assert_template "index"
   end
     assert_response :success
     assert_template "index"
   end


@@ -241,7 +243,7 @@ class SiteControllerTest < ActionController::TestCase
     user = users(:public_user)
     node = current_nodes(:visible_node)
 
     user = users(:public_user)
     node = current_nodes(:visible_node)
 

-    get :edit, { :node => node.id }, { :user => user.id }
+    get :edit, { :node => node.id }, { :user => user }

     assert_response :success
     assert_template "edit"
     assert_equal 1.0, assigns(:lat)
     assert_response :success
     assert_template "edit"
     assert_equal 1.0, assigns(:lat)


@@ -254,7 +256,7 @@ class SiteControllerTest < ActionController::TestCase
     user = users(:public_user)
     way  = current_ways(:visible_way)
 
     user = users(:public_user)
     way  = current_ways(:visible_way)
 

-    get :edit, { :way => way.id }, { :user => user.id }
+    get :edit, { :way => way.id }, { :user => user }

     assert_response :success
     assert_template "edit"
     assert_equal 3.0, assigns(:lat)
     assert_response :success
     assert_template "edit"
     assert_equal 3.0, assigns(:lat)


@@ -269,7 +271,7 @@ class SiteControllerTest < ActionController::TestCase
       n.comments.create(:author_id => user.id)
     end
 
       n.comments.create(:author_id => user.id)
     end
 

-    get :edit, { :note => note.id }, { :user => user.id }
+    get :edit, { :note => note.id }, { :user => user }

     assert_response :success
     assert_template "edit"
     assert_equal 1.0, assigns(:lat)
     assert_response :success
     assert_template "edit"
     assert_equal 1.0, assigns(:lat)


@@ -280,9 +282,9 @@ class SiteControllerTest < ActionController::TestCase
   # Test editing a specific GPX trace
   def test_edit_with_gpx
     user = users(:public_user)
   # Test editing a specific GPX trace
   def test_edit_with_gpx
     user = users(:public_user)

-    gpx  = gpx_files(:public_trace_file)
+    gpx  = create(:trace, :latitude => 1, :longitude => 1)

 
 

-    get :edit, { :gpx => gpx.id }, { :user => user.id }
+    get :edit, { :gpx => gpx.id }, { :user => user }

     assert_response :success
     assert_template "edit"
     assert_equal 1.0, assigns(:lat)
     assert_response :success
     assert_template "edit"
     assert_equal 1.0, assigns(:lat)


@@ -315,7 +317,7 @@ class SiteControllerTest < ActionController::TestCase
     assert_response :redirect
     assert_redirected_to :controller => :user, :action => :login, :referer => "/welcome"
 
     assert_response :redirect
     assert_redirected_to :controller => :user, :action => :login, :referer => "/welcome"
 

-    get :welcome, nil, :user => users(:public_user).id
+    get :welcome, nil, :user => users(:public_user)

     assert_response :success
     assert_template "welcome"
   end
     assert_response :success
     assert_template "welcome"
   end


@@ -375,7 +377,7 @@ class SiteControllerTest < ActionController::TestCase
 
   # Test the id frame
   def test_id
 
   # Test the id frame
   def test_id

-    get :id, nil, :user => users(:public_user).id
+    get :id, nil, :user => users(:public_user)

     assert_response :success
     assert_template "id"
     assert_template :layout => false
     assert_response :success
     assert_template "id"
     assert_template :layout => false