Use BETWEEN for the node selection in the map API call as MySQL seems to

[rails.git] / app / controllers / segment_controller.rb

diff --git a/app/controllers/segment_controller.rb b/app/controllers/segment_controller.rb
index 7e77609f303a2908a14c14cebcac73cf6661ab60..b99f7460f729ed229eca3f4bd9ef9a5d8e6671f9 100644 (file)
--- a/app/controllers/segment_controller.rb
+++ b/app/controllers/segment_controller.rb
@@ -1,99 +1,134 @@
 class SegmentController < ApplicationController
   require 'xml/libxml'
 
-  before_filter :authorize
+  session :off
+  before_filter :authorize, :only => [:create, :update, :delete]
+  before_filter :check_availability, :only => [:create, :update, :delete]
   after_filter :compress_output
 
   def create
-    response.headers["Content-Type"] = 'application/xml'
     if request.put?
       segment = Segment.from_xml(request.raw_post, true)
 
       if segment
-        
-        segment.user_id = @user.id
-
-        a = Node.find(segment.node_a.to_i)
-        b = Node.find(segment.node_b.to_i)
-        
-        unless a and a.visible and b and b.visible  
-          render :nothing => true, :status => 400
-        end
-
-        if segment.save_with_history
-          render :text => segment.id
+        if segment.node_a == segment.node_b
+          render :nothing => true, :status => :expectation_failed
+        elsif !segment.preconditions_ok?
+          render :nothing => true, :status => :precondition_failed
         else
-          render :nothing => true, :status => 500
-        end
-        return
+          segment.user_id = @user.id
+          segment.from_node = Node.find(segment.node_a.to_i)
+          segment.to_node = Node.find(segment.node_b.to_i)
+          segment.save_with_history!
 
+          render :text => segment.id.to_s, :content_type => "text/plain"
+        end
       else
-        render :nothing => true, :status => 400 # if we got here the doc didnt parse
-        return
+        render :nothing => true, :status => :bad_request
       end
+    else
+      render :nothing => true, :status => :method_not_allowed
     end
-
-    render :nothing => true, :status => 500 # something went very wrong
   end
 
-  def rest
-    response.headers["Content-Type"] = 'application/xml'
-    unless Segment.exists?(params[:id])
-      render :nothing => true, :status => 404
-      return
-    end
-
-    segment = Segment.find(params[:id])
+  def read
+    begin
+      segment = Segment.find(params[:id])
 
-    case request.method
+      if segment.visible
+        render :text => segment.to_xml.to_s, :content_type => "text/xml"
+      else
+        render :nothing => true, :status => :gone
+      end
+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
+    end
+  end
 
-    when :get
-      render :text => segment.to_xml.to_s
-      return
+  def update
+    begin
+      segment = Segment.find(params[:id])
 
-    when :delete
       if segment.visible
-        segment.visible = 0
-        segment.save_with_history
-        render :nothing => true
+        new_segment = Segment.from_xml(request.raw_post)
+
+        if new_segment and new_segment.id == segment.id
+          if new_segment.node_a == new_segment.node_b
+            render :nothing => true, :status => :expectation_failed
+          elsif !new_segment.preconditions_ok?
+            render :nothing => true, :status => :precondition_failed
+          else
+            segment.user_id = @user.id
+            segment.node_a = new_segment.node_a
+            segment.node_b = new_segment.node_b
+            segment.tags = new_segment.tags
+            segment.visible = new_segment.visible
+            segment.save_with_history!
+
+            render :nothing => true
+          end
+        else
+          render :nothing => true, :status => :bad_request
+        end
       else
-        render :nothing => true, :status => 410
+        render :nothing => true, :status => :gone
       end
+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
+    end
+  end
 
-    when :put
-      new_segment = Segment.from_xml(request.raw_post)
-
-      segment.timestamp = Time.now
-      segment.user_id = @user.id
+  def delete
+    begin
+      segment = Segment.find(params[:id])
 
-      segment.node_a = new_segment.node_a
-      segment.node_b = new_segment.node_b
-      segment.tags = new_segment.tags
-      segment.visible = new_segment.visible
+      if segment.visible
+        if WaySegment.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_segments.id", :conditions => [ "current_ways.visible = 1 AND current_way_segments.segment_id = ?", segment.id ])
+          render :nothing => true, :status => :precondition_failed
+        else
+          segment.user_id = @user.id
+          segment.visible = 0
+          segment.save_with_history!
 
-      if segment.id == new_segment.id and segment.save_with_history
-        render :nothing => true, :status => 200
+          render :nothing => true
+        end
       else
-        render :nothing => true, :status => 500
+        render :nothing => true, :status => :gone
       end
-      return
+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
     end
-
   end
 
   def segments
-    response.headers["Content-Type"] = 'application/xml'
-    ids = params['segments'].split(',').collect {|s| s.to_i }
+    ids = params['segments'].split(',').collect { |s| s.to_i }
+
     if ids.length > 0
-      segmentlist = Segment.find(ids)
-      doc = get_xml_doc
-      segmentlist.each do |segment|
+      doc = OSM::API.new.get_xml_doc
+
+      Segment.find(ids).each do |segment|
         doc.root << segment.to_xml_node
       end 
-      render :text => doc.to_s
+
+      render :text => doc.to_s, :content_type => "text/xml"
     else
-      render :nothing => true, :status => 400
+      render :nothing => true, :status => :bad_request
     end
   end
 
+  def segments_for_node
+    segmentids = Segment.find(:all, :conditions => ['node_a = ? OR node_b = ?', params[:id], params[:id]]).collect { |s| s.id }.uniq
+
+    if segmentids.length > 0
+      doc = OSM::API.new.get_xml_doc
+
+      Segment.find(segmentids).each do |segment|
+        doc.root << segment.to_xml_node
+      end
+
+      render :text => doc.to_s, :content_type => "text/xml"
+    else
+      render :nothing => true, :status => :bad_request
+    end
+  end
 end