Merge remote-tracking branch 'upstream/pull/1659'

[rails.git] / lib / potlatch.rb

diff --git a/lib/potlatch.rb b/lib/potlatch.rb
index 717622762e9a383402ed7135fdfd540f0395bd85..76944e3940de39e27ec8cd9ffe3845afae56a9d3 100644 (file)
--- a/lib/potlatch.rb
+++ b/lib/potlatch.rb
@@ -70,31 +70,31 @@ module Potlatch
 
     # Pack variables as AMF
     def self.encodevalue(n)
 
     # Pack variables as AMF
     def self.encodevalue(n)

-      case n.class.to_s
-      when "Array"
+      case n
+      when Array

         a = 10.chr + encodelong(n.length)
         n.each do |b|
           a += encodevalue(b)
         end
         a
         a = 10.chr + encodelong(n.length)
         n.each do |b|
           a += encodevalue(b)
         end
         a

-      when "Hash"
+      when Hash

         a = 3.chr
         n.each do |k, v|
           a += encodestring(k.to_s) + encodevalue(v)
         end
         a + 0.chr + 0.chr + 9.chr
         a = 3.chr
         n.each do |k, v|
           a += encodestring(k.to_s) + encodevalue(v)
         end
         a + 0.chr + 0.chr + 9.chr

-      when "String"
+      when String

         2.chr + encodestring(n)
         2.chr + encodestring(n)

-      when "Bignum", "Fixnum", "Float"
+      when Numeric, GeoRecord::Coord

         0.chr + encodedouble(n)
         0.chr + encodedouble(n)

-      when "NilClass"
+      when NilClass

         5.chr
         5.chr

-      when "TrueClass"
+      when TrueClass

         0.chr + encodedouble(1)
         0.chr + encodedouble(1)

-      when "FalseClass"
+      when FalseClass

         0.chr + encodedouble(0)
       else
         0.chr + encodedouble(0)
       else

-        Rails.logger.error("Unexpected Ruby type for AMF conversion: " + n.class.to_s)
+        raise "Unexpected Ruby type for AMF conversion: #{n.class.name}"

       end
     end
 
       end
     end
 


@@ -107,7 +107,7 @@ module Potlatch
 
     # Encode number as eight-byte double precision float
     def self.encodedouble(n)
 
     # Encode number as eight-byte double precision float
     def self.encodedouble(n)

-      [n].pack("G")
+      [n.to_f].pack("G")

     end
 
     # Encode number as four-byte long
     end
 
     # Encode number as four-byte long