Remove inline javascript from page header

[rails.git] / app / views / layouts / notifier.html.erb
diff --git a/app/views/layouts/notifier.html.erb b/app/views/layouts/notifier.html.erb

index 3b8ce6657b43ef6a806b7a52f5652d3f3783ee9d..883f1b385acaeaa73fab4a3bebcd8723ebe16532 100644 (file)
--- a/app/views/layouts/notifier.html.erb
+++ b/app/views/layouts/notifier.html.erb
@@ -1,22 +1,25 @@
  <html>
    <head>
  <html>
    <head>
-    <title></title>
      <meta charset="UTF-8"></meta>
    </head>
    <body style="padding: 0; margin: 0; font-size: 14px; font-family: 'Helvetica Neue', Arial, sans-serif; color: #222">
      <table style="background-color: #eee; width: 100%">
        <tr>
      <meta charset="UTF-8"></meta>
    </head>
    <body style="padding: 0; margin: 0; font-size: 14px; font-family: 'Helvetica Neue', Arial, sans-serif; color: #222">
      <table style="background-color: #eee; width: 100%">
        <tr>
-        <td style="text-align: center">
-          <table style="width: 600px; color: #222; margin-left: auto; margin-right: auto">
+        <%# having width=100% on the table and then only a fixed width on the middle cell gives us a max-width that works in Outlook %>
+        <td rowspan="2"></td>
+        <td width="600" style="text-align: center; padding: 0px 7px">
+          <table style="width: 100%; color: #222; margin-left: auto; margin-right: auto">
              <tr>
              <tr>
-              <td style="width: 30px; padding: 10px">
+              <td style="width: 30px; padding: 10px 10px 10px 0px">
                  <a href="<%= @root_url %>" target="_blank">
                  <a href="<%= @root_url %>" target="_blank">
-                  <%= image_tag attachments["logo.png"].url, alt: "OpenStreetMap logo", title: "OpenStreetMap", height: "30", width: "30", border: "0" %>
+                  <%= image_tag attachments["logo.png"].url, alt: "OpenStreetMap", title: "OpenStreetMap", height: "30", width: "30", border: "0" %>
                  </a>
                </td>
                  </a>
                </td>
-              <td style="padding: 10px 0px">
+              <%# the "width: 100%" here looks wrong, but I couldn't find a better way of making Outlook give this cell full width %>
+              <td style="width: 100%; padding: 0px; text-align: left">
+                <%# NB we need "text-decoration: none" twice: GMail only honours it on the <a> but Outlook only on the <strong> %>
                  <a href="<%= @root_url %>" target="_blank" style="text-decoration: none; color: #000">
                  <a href="<%= @root_url %>" target="_blank" style="text-decoration: none; color: #000">
-                  <h1 style="font-size: 18px; font-weight: 600; margin: 0; text-align: left">OpenStreetMap</h1>
+                  <strong style="text-decoration: none; font-size: 18px; font-weight: 600; margin: 0; text-align: left; font-family: 'Helvetica Neue', Arial, sans-serif">OpenStreetMap</strong>
                  </a>
                </td>
              </tr>
                  </a>
                </td>
              </tr>
@@ -24,8 +27,8 @@
                <td colspan="2">
                  <table style="background-color: #fff; color: #222; border: solid 1px #ccc; border-collapse: separate">
                    <tr>
                <td colspan="2">
                  <table style="background-color: #fff; color: #222; border: solid 1px #ccc; border-collapse: separate">
                    <tr>
-                    <td style="text-align: left; padding: 15px 15px 5px 15px">
-                      <%= yield %>
+                    <td style="text-align: left; padding: 0px 15px 5px 15px">
+                      <%= raw style_message(yield) %>
                      </td>
                    </tr>
                  </table>
                      </td>
                    </tr>
                  </table>
@@ -33,9 +36,10 @@
              </tr>
            </table>
          </td>
              </tr>
            </table>
          </td>
+        <td rowspan="2"></td>
        </tr>
        <tr>
        </tr>
        <tr>
-        <td style="text-align: center; font-size: 11px">
+        <td style="text-align: center; font-size: 11px; font-family: 'Helvetica Neue', Arial, sans-serif">
            <%= yield :footer %>
            <p style="margin-bottom: 10px">
              <a href="<%= @root_url %>" target="_blank" style="color: #222">OpenStreetMap</a>
            <%= yield :footer %>
            <p style="margin-bottom: 10px">
              <a href="<%= @root_url %>" target="_blank" style="color: #222">OpenStreetMap</a>