Merge remote-tracking branch 'openstreetmap/pull/1521'

[rails.git] / test / integration / oauth_test.rb

diff --git a/test/integration/oauth_test.rb b/test/integration/oauth_test.rb
index 32314703021ccafac736f9e0f60d0f1e0842247e..9eedd1ff49b2df3782b6da68d6d131a9a664112f 100644 (file)
--- a/test/integration/oauth_test.rb
+++ b/test/integration/oauth_test.rb
@@ -1,24 +1,25 @@
 require "test_helper"
 
 class OAuthTest < ActionDispatch::IntegrationTest
 require "test_helper"
 
 class OAuthTest < ActionDispatch::IntegrationTest

-  fixtures :users, :client_applications, :gpx_files
-  set_fixture_class :gpx_files => Trace
-

   include OAuth::Helper
 
   include OAuth::Helper
 

+  def setup
+    stub_hostip_requests
+  end
+

   def test_oauth10_web_app
   def test_oauth10_web_app

-    client = client_applications(:oauth_web_app)
+    client = create(:client_application, :callback_url => "http://some.web.app.example.org/callback", :allow_read_prefs => true, :allow_write_api => true, :allow_read_gpx => true)

 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success
 
     oauth10_without_callback(client)
 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success
 
     oauth10_without_callback(client)

-    oauth10_with_callback(client, "http://another.web.app.org/callback")
+    oauth10_with_callback(client, "http://another.web.app.example.org/callback")

     oauth10_refused(client)
   end
 
   def test_oauth10_desktop_app
     oauth10_refused(client)
   end
 
   def test_oauth10_desktop_app

-    client = client_applications(:oauth_desktop_app)
+    client = create(:client_application, :allow_read_prefs => true, :allow_write_api => true, :allow_read_gpx => true)

 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success
 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success


@@ -28,18 +29,18 @@ class OAuthTest < ActionDispatch::IntegrationTest
   end
 
   def test_oauth10a_web_app
   end
 
   def test_oauth10a_web_app

-    client = client_applications(:oauth_web_app)
+    client = create(:client_application, :callback_url => "http://some.web.app.example.org/callback", :allow_read_prefs => true, :allow_write_api => true, :allow_read_gpx => true)

 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success
 
     oauth10a_without_callback(client)
 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success
 
     oauth10a_without_callback(client)

-    oauth10a_with_callback(client, "http://another.web.app.org/callback")
+    oauth10a_with_callback(client, "http://another.web.app.example.org/callback")

     oauth10a_refused(client)
   end
 
   def test_oauth10a_desktop_app
     oauth10a_refused(client)
   end
 
   def test_oauth10a_desktop_app

-    client = client_applications(:oauth_desktop_app)
+    client = create(:client_application, :allow_read_prefs => true, :allow_write_api => true, :allow_read_gpx => true)

 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success
 
     post_via_redirect "/login", :username => client.user.email, :password => "test"
     assert_response :success


@@ -94,7 +95,7 @@ class OAuthTest < ActionDispatch::IntegrationTest
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)

-    token = OauthToken.find_by_token(token.token)
+    token = OauthToken.find_by(:token => token.token)

     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/user/preferences", :consumer => client, :token => token
     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/user/preferences", :consumer => client, :token => token


@@ -164,7 +165,8 @@ class OAuthTest < ActionDispatch::IntegrationTest
     assert_nil token.invalidated_at
     assert_allowed token, [:allow_write_api, :allow_read_gpx]
 
     assert_nil token.invalidated_at
     assert_allowed token, [:allow_write_api, :allow_read_gpx]
 

-    signed_get "/api/0.6/gpx/2", :consumer => client, :token => token
+    trace = create(:trace, :user => client.user)
+    signed_get "/api/0.6/gpx/#{trace.id}", :consumer => client, :token => token

     assert_response :success
 
     signed_get "/api/0.6/user/details", :consumer => client, :token => token
     assert_response :success
 
     signed_get "/api/0.6/user/details", :consumer => client, :token => token


@@ -172,7 +174,7 @@ class OAuthTest < ActionDispatch::IntegrationTest
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)

-    token = OauthToken.find_by_token(token.token)
+    token = OauthToken.find_by(:token => token.token)

     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/gpx/2", :consumer => client, :token => token
     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/gpx/2", :consumer => client, :token => token


@@ -192,7 +194,7 @@ class OAuthTest < ActionDispatch::IntegrationTest
     if client.callback_url
       assert_response :redirect
       verifier = parse_verifier(response)
     if client.callback_url
       assert_response :redirect
       verifier = parse_verifier(response)

-      assert_redirected_to "http://some.web.app.org/callback?oauth_token=#{token.token}&oauth_verifier=#{verifier}"
+      assert_redirected_to "http://some.web.app.example.org/callback?oauth_token=#{token.token}&oauth_verifier=#{verifier}"

     else
       assert_response :success
       assert_template :authorize_success
     else
       assert_response :success
       assert_template :authorize_success


@@ -226,12 +228,13 @@ class OAuthTest < ActionDispatch::IntegrationTest
     signed_get "/api/0.6/user/preferences", :consumer => client, :token => token
     assert_response :success
 
     signed_get "/api/0.6/user/preferences", :consumer => client, :token => token
     assert_response :success
 

-    signed_get "/api/0.6/gpx/2", :consumer => client, :token => token
+    trace = create(:trace, :user => client.user)
+    signed_get "/api/0.6/gpx/#{trace.id}", :consumer => client, :token => token

     assert_response :forbidden
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)
     assert_response :forbidden
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)

-    token = OauthToken.find_by_token(token.token)
+    token = OauthToken.find_by(:token => token.token)

     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/user/preferences", :consumer => client, :token => token
     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/user/preferences", :consumer => client, :token => token


@@ -274,7 +277,8 @@ class OAuthTest < ActionDispatch::IntegrationTest
     assert_nil token.invalidated_at
     assert_allowed token, [:allow_write_api, :allow_read_gpx]
 
     assert_nil token.invalidated_at
     assert_allowed token, [:allow_write_api, :allow_read_gpx]
 

-    signed_get "/api/0.6/gpx/2", :consumer => client, :token => token
+    trace = create(:trace, :user => client.user)
+    signed_get "/api/0.6/gpx/#{trace.id}", :consumer => client, :token => token

     assert_response :success
 
     signed_get "/api/0.6/user/details", :consumer => client, :token => token
     assert_response :success
 
     signed_get "/api/0.6/user/details", :consumer => client, :token => token


@@ -282,7 +286,7 @@ class OAuthTest < ActionDispatch::IntegrationTest
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)
 
     post "/oauth/revoke", :token => token.token
     assert_redirected_to oauth_clients_url(token.user.display_name)

-    token = OauthToken.find_by_token(token.token)
+    token = OauthToken.find_by(:token => token.token)

     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/gpx/2", :consumer => client, :token => token
     assert_not_nil token.invalidated_at
 
     signed_get "/api/0.6/gpx/2", :consumer => client, :token => token


@@ -329,7 +333,7 @@ class OAuthTest < ActionDispatch::IntegrationTest
     assert_not_nil token.created_at
     assert_nil token.authorized_at
     assert_nil token.invalidated_at
     assert_not_nil token.created_at
     assert_nil token.authorized_at
     assert_nil token.invalidated_at

-    assert_equal options[:oauth_callback], token.callback_url
+    assert_equal_allowing_nil options[:oauth_callback], token.callback_url

     assert_allowed token, client.permissions
 
     token
     assert_allowed token, client.permissions
 
     token


@@ -356,7 +360,7 @@ class OAuthTest < ActionDispatch::IntegrationTest
   def parse_token(response)
     params = CGI.parse(response.body)
 
   def parse_token(response)
     params = CGI.parse(response.body)
 

-    token = OauthToken.find_by_token(params["oauth_token"].first)
+    token = OauthToken.find_by(:token => params["oauth_token"].first)

     assert_equal token.secret, params["oauth_token_secret"].first
 
     token
     assert_equal token.secret, params["oauth_token_secret"].first
 
     token