Fix the Redirect warnings from Brakeman

[rails.git] / app / models / acl.rb

diff --git a/app/models/acl.rb b/app/models/acl.rb
index 095bad89b942d07e62ee74b18e999100905c456b..06f754c2274ad801fe34fc6e7369867d56e4397c 100644 (file)
--- a/app/models/acl.rb
+++ b/app/models/acl.rb
@@ -2,37 +2,42 @@
 #
 # Table name: acls
 #
 #
 # Table name: acls
 #

-#  id      :integer          not null, primary key
+#  id      :bigint(8)        not null, primary key

 #  address :inet
 #  k       :string           not null
 #  v       :string
 #  domain  :string
 #  address :inet
 #  k       :string           not null
 #  v       :string
 #  domain  :string

+#  mx      :string

 #
 # Indexes
 #
 #
 # Indexes
 #

-#  acls_k_idx  (k)
+#  acls_k_idx             (k)
+#  index_acls_on_address  (address) USING gist
+#  index_acls_on_domain   (domain)
+#  index_acls_on_mx       (mx)

 #
 
 #
 

-class Acl < ActiveRecord::Base
+class Acl < ApplicationRecord

   validates :k, :presence => true
 
   validates :k, :presence => true
 

-  def self.match(address, domain = nil)
-    if domain
-      Acl.where("address >>= ? OR domain = ?", address, domain)
-    else
-      Acl.where("address >>= ?", address)
-    end
+  def self.match(address, options = {})
+    acls = Acl.where("address >>= ?", address)
+
+    acls = acls.or(Acl.where(:domain => options[:domain])) if options[:domain]
+    acls = acls.or(Acl.where(:mx => options[:mx])) if options[:mx]
+
+    acls

   end
 
   end
 

-  def self.no_account_creation(address, domain = nil)
-    match(address, domain).where(:k => "no_account_creation").exists?
+  def self.no_account_creation(address, options = {})
+    match(address, options).where(:k => "no_account_creation").exists?

   end
 
   def self.no_note_comment(address, domain = nil)
   end
 
   def self.no_note_comment(address, domain = nil)

-    match(address, domain).where(:k => "no_note_comment").exists?
+    match(address, :domain => domain).where(:k => "no_note_comment").exists?

   end
 
   def self.no_trace_download(address, domain = nil)
   end
 
   def self.no_trace_download(address, domain = nil)

-    match(address, domain).where(:k => "no_trace_download").exists?
+    match(address, :domain => domain).where(:k => "no_trace_download").exists?

   end
 end
   end
 end