Convert various moderator? tests to use cancancan permissions checks

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 26b5aa64b8402baec153a5c6358fe5b37c596b3c..57f876bd9cd53924d75faebf1f29c58d98002f52 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2019-06-05 09:04:25 +0100 using RuboCop version 0.71.0.
+# on 2019-10-07 20:37:25 +0100 using RuboCop version 0.75.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 

-# Offense count: 33
+# Offense count: 34

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:


@@ -32,11 +32,11 @@ Lint/HandleExceptions:
     - 'app/controllers/api/amf_controller.rb'
     - 'app/controllers/users_controller.rb'
 
     - 'app/controllers/api/amf_controller.rb'
     - 'app/controllers/users_controller.rb'
 

-# Offense count: 703
+# Offense count: 700

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 279
+  Max: 189

 
 

-# Offense count: 40
+# Offense count: 39

 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:


@@ -47,21 +47,21 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 5
 
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 68
+# Offense count: 25

 # Configuration parameters: CountComments.
 Metrics/ClassLength:
 # Configuration parameters: CountComments.
 Metrics/ClassLength:

-  Max: 1397
+  Max: 645

 
 # Offense count: 73
 Metrics/CyclomaticComplexity:
   Max: 22
 
 
 # Offense count: 73
 Metrics/CyclomaticComplexity:
   Max: 22
 

-# Offense count: 714
+# Offense count: 721

 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 179
 
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 179
 

-# Offense count: 1
+# Offense count: 2

 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 107
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 107


@@ -100,6 +100,14 @@ Naming/PredicateName:
     - 'app/models/user.rb'
     - 'lib/classic_pagination/pagination.rb'
 
     - 'app/models/user.rb'
     - 'lib/classic_pagination/pagination.rb'
 

+# Offense count: 5
+# Cop supports --auto-correct.
+Performance/RegexpMatch:
+  Exclude:
+    - 'app/helpers/browse_tags_helper.rb'
+    - 'app/validators/characters_validator.rb'
+    - 'app/validators/whitespace_validator.rb'
+

 # Offense count: 6
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql
 # Offense count: 6
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql


@@ -165,11 +173,24 @@ Style/AsciiComments:
   Exclude:
     - 'test/models/message_test.rb'
 
   Exclude:
     - 'test/models/message_test.rb'
 

-# Offense count: 255
+# Offense count: 263

 Style/Documentation:
   Enabled: false
 
 Style/Documentation:
   Enabled: false
 

-# Offense count: 503
+# Offense count: 27
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  Exclude:
+    - 'app/models/concerns/geo_record.rb'
+    - 'app/views/api/map/_bounds.xml.builder'
+    - 'lib/bounding_box.rb'
+    - 'test/controllers/api/map_controller_test.rb'
+    - 'test/controllers/api/relations_controller_test.rb'
+    - 'test/controllers/api/ways_controller_test.rb'
+    - 'test/lib/bounding_box_test.rb'
+
+# Offense count: 539

 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, never
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, never


@@ -182,15 +203,15 @@ Style/IfUnlessModifier:
   Exclude:
     - 'app/controllers/api/ways_controller.rb'
 
   Exclude:
     - 'app/controllers/api/ways_controller.rb'
 

-# Offense count: 74
+# Offense count: 70

 # Cop supports --auto-correct.
 # Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 11
 
 # Cop supports --auto-correct.
 # Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 11
 

-# Offense count: 3320
+# Offense count: 3330

 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:

-  Max: 1073
+  Max: 307