Use the message title as the subject of notification mails

[rails.git] / app / models / notifier.rb

diff --git a/app/models/notifier.rb b/app/models/notifier.rb
index 9eff2fb92eb24cbf488be67240830c3e7ad6b9a8..de0ad21d688a1a8fe67e7e6e34479c6c0fedd03e 100644 (file)
--- a/app/models/notifier.rb
+++ b/app/models/notifier.rb
@@ -1,52 +1,112 @@
 class Notifier < ActionMailer::Base
-
-  def signup_confirm( user, token )
-    @recipients = user.email
-    @from = 'abuse@openstreetmap.org'
-    @subject = '[OpenStreetMap] Confirm your email address'
-    @body['url'] = "http://#{SERVER_URL}/user/confirm?confirm_string=#{token.token}"
+  def signup_confirm(user, token)
+    common_headers user
+    subject I18n.t('notifier.signup_confirm.subject')
+    body :url => url_for(:host => SERVER_URL,
+                         :controller => "user", :action => "confirm",
+                         :confirm_string => token.token)
   end
 
-  def lost_password( user, token )
-    @recipients = user.email
-    @from = 'abuse@openstreetmap.org'
-    @subject = '[OpenStreetMap] Password reset request'
-    @body['url'] = "http://#{SERVER_URL}/user/reset_password?email=#{user.email}&token=#{token.token}"
+  def email_confirm(user, token)
+    common_headers user
+    recipients user.new_email
+    subject I18n.t('notifier.email_confirm.subject')
+    body :address => user.new_email,
+         :url => url_for(:host => SERVER_URL,
+                         :controller => "user", :action => "confirm_email",
+                         :confirm_string => token.token)
   end
 
-  def reset_password(user, pass)
-    @recipients = user.email
-    @from = 'abuse@openstreetmap.org'
-    @subject = '[OpenStreetMap] Password reset'
-    @body['pass'] = pass
+  def lost_password(user, token)
+    common_headers user
+    subject I18n.t('notifier.lost_password.subject')
+    body :url => url_for(:host => SERVER_URL,
+                         :controller => "user", :action => "reset_password",
+                         :token => token.token)
   end
 
   def gpx_success(trace, possible_points)
-    @recipients = trace.user.email
-    @from = 'abuse@openstreetmap.org'
-    @subject = '[OpenStreetMap] GPX Import success'
-    @body['trace_name'] = trace.name
-    @body['trace_points'] = trace.size
-    @body['possible_points'] = possible_points
+    common_headers trace.user
+    subject I18n.t('notifier.gpx_notification.success.subject')
+    body :trace_name => trace.name,
+         :trace_points => trace.size,
+         :trace_description => trace.description,
+         :trace_tags => trace.tags,
+         :possible_points => possible_points
   end
 
   def gpx_failure(trace, error)
-    @recipients = trace.user.email
-    @from = 'abuse@openstreetmap.org'
-    @subject = '[OpenStreetMap] GPX Import failure'
-    @body['trace_name'] = trace.name
-    @body['error'] = error
+    common_headers trace.user
+    from "webmaster@openstreetmap.org"
+    subject I18n.t('notifier.gpx_notification.failure.subject')
+    body :trace_name => trace.name,
+         :trace_description => trace.description,
+         :trace_tags => trace.tags,
+         :error => error
   end
   
   def message_notification(message)
-    @recipients = message.recipient.email
-    @from = 'abuse@openstreetmap.org'
-    @subject = "[OpenStreetMap] #{message.sender.display_name} sent you a new message"
-    @body['to_user'] = message.recipient.display_name
-    @body['from_user'] = message.sender.display_name
-    @body['body'] = message.body
-    @body['subject'] = message.title
-    @body['readurl'] = "http://#{SERVER_URL}/message/read/#{message.id}"
-    @body['replyurl'] = "http://#{SERVER_URL}/message/new/#{message.from_user_id}"
+    common_headers message.recipient
+    from_header message.sender.display_name, "m", message.id, message.digest
+    subject message.title
+    body :to_user => message.recipient.display_name,
+         :from_user => message.sender.display_name,
+         :body => message.body,
+         :title => message.title,
+         :readurl => url_for(:host => SERVER_URL,
+                             :controller => "message", :action => "read",
+                             :message_id => message.id),
+         :replyurl => url_for(:host => SERVER_URL,
+                              :controller => "message", :action => "reply",
+                              :message_id => message.id)
+  end
+
+  def diary_comment_notification(comment)
+    common_headers comment.diary_entry.user
+    from_header comment.user.display_name, "c", comment.id, comment.digest
+    subject I18n.t('notifier.diary_comment_notification.subject', :user => comment.user.display_name, :locale => locale)
+    body :to_user => comment.diary_entry.user.display_name,
+         :from_user => comment.user.display_name,
+         :body => comment.body,
+         :title => comment.diary_entry.title,
+         :readurl => url_for(:host => SERVER_URL,
+                             :controller => "diary_entry",
+                             :action => "view",
+                             :display_name => comment.diary_entry.user.display_name,
+                             :id => comment.diary_entry.id,
+                             :anchor => "comment#{comment.id}"),
+         :commenturl => url_for(:host => SERVER_URL,
+                                :controller => "diary_entry",
+                                :action => "view",
+                                :display_name => comment.diary_entry.user.display_name,
+                                :id => comment.diary_entry.id,
+                                :anchor => "newcomment"),
+         :replyurl => url_for(:host => SERVER_URL,
+                              :controller => "message",
+                              :action => "new",
+                              :display_name => comment.user.display_name,
+                              :title => "Re: #{comment.diary_entry.title}")
+  end
+
+  def friend_notification(friend)
+    common_headers friend.befriendee
+    subject I18n.t('notifier.friend_notification.subject', :user => friend.befriender.display_name, :locale => locale)
+    body :friend => friend
+  end
+
+private
+
+  def common_headers(recipient)
+    recipients recipient.email
+    locale recipient.preferred_language_from(I18n.available_locales)
+    from EMAIL_FROM
+    headers "return-path" => EMAIL_RETURN_PATH,
+            "Auto-Submitted" => "auto-generated"
+  end
+
+  def from_header(name, type, id, digest)
+    if domain = APP_CONFIG['messages_domain']
+      from quote_address_if_necessary("#{name} <#{type}-#{id}-#{digest[0,6]}@#{domain}>", "utf-8")
+    end
   end
 end