Use the message title as the subject of notification mails

[rails.git] / app / models / notifier.rb

diff --git a/app/models/notifier.rb b/app/models/notifier.rb
index b291c2b57de027d6dbc3d89b5b5f06f24df5bf3a..de0ad21d688a1a8fe67e7e6e34479c6c0fedd03e 100644 (file)
--- a/app/models/notifier.rb
+++ b/app/models/notifier.rb
@@ -1,7 +1,7 @@
 class Notifier < ActionMailer::Base
   def signup_confirm(user, token)
     common_headers user
-    subject "[OpenStreetMap] Confirm your email address"
+    subject I18n.t('notifier.signup_confirm.subject')
     body :url => url_for(:host => SERVER_URL,
                          :controller => "user", :action => "confirm",
                          :confirm_string => token.token)
@@ -10,7 +10,7 @@ class Notifier < ActionMailer::Base
   def email_confirm(user, token)
     common_headers user
     recipients user.new_email
-    subject "[OpenStreetMap] Confirm your email address"
+    subject I18n.t('notifier.email_confirm.subject')
     body :address => user.new_email,
          :url => url_for(:host => SERVER_URL,
                          :controller => "user", :action => "confirm_email",
@@ -19,21 +19,15 @@ class Notifier < ActionMailer::Base
 
   def lost_password(user, token)
     common_headers user
-    subject "[OpenStreetMap] Password reset request"
+    subject I18n.t('notifier.lost_password.subject')
     body :url => url_for(:host => SERVER_URL,
                          :controller => "user", :action => "reset_password",
-                         :email => user.email, :token => token.token)
-  end
-
-  def reset_password(user, pass)
-    common_headers user
-    subject "[OpenStreetMap] Password reset"
-    body :pass => pass
+                         :token => token.token)
   end
 
   def gpx_success(trace, possible_points)
     common_headers trace.user
-    subject "[OpenStreetMap] GPX Import success"
+    subject I18n.t('notifier.gpx_notification.success.subject')
     body :trace_name => trace.name,
          :trace_points => trace.size,
          :trace_description => trace.description,
@@ -44,7 +38,7 @@ class Notifier < ActionMailer::Base
   def gpx_failure(trace, error)
     common_headers trace.user
     from "webmaster@openstreetmap.org"
-    subject "[OpenStreetMap] GPX Import failure"
+    subject I18n.t('notifier.gpx_notification.failure.subject')
     body :trace_name => trace.name,
          :trace_description => trace.description,
          :trace_tags => trace.tags,
@@ -53,11 +47,12 @@ class Notifier < ActionMailer::Base
   
   def message_notification(message)
     common_headers message.recipient
-    subject "[OpenStreetMap] #{message.sender.display_name} sent you a new message"
+    from_header message.sender.display_name, "m", message.id, message.digest
+    subject message.title
     body :to_user => message.recipient.display_name,
          :from_user => message.sender.display_name,
          :body => message.body,
-         :subject => message.title,
+         :title => message.title,
          :readurl => url_for(:host => SERVER_URL,
                              :controller => "message", :action => "read",
                              :message_id => message.id),
@@ -68,11 +63,12 @@ class Notifier < ActionMailer::Base
 
   def diary_comment_notification(comment)
     common_headers comment.diary_entry.user
-    subject "[OpenStreetMap] #{comment.user.display_name} commented on your diary entry"
+    from_header comment.user.display_name, "c", comment.id, comment.digest
+    subject I18n.t('notifier.diary_comment_notification.subject', :user => comment.user.display_name, :locale => locale)
     body :to_user => comment.diary_entry.user.display_name,
          :from_user => comment.user.display_name,
          :body => comment.body,
-         :subject => comment.diary_entry.title,
+         :title => comment.diary_entry.title,
          :readurl => url_for(:host => SERVER_URL,
                              :controller => "diary_entry",
                              :action => "view",
@@ -88,20 +84,14 @@ class Notifier < ActionMailer::Base
          :replyurl => url_for(:host => SERVER_URL,
                               :controller => "message",
                               :action => "new",
-                              :user_id => comment.user.id,
+                              :display_name => comment.user.display_name,
                               :title => "Re: #{comment.diary_entry.title}")
   end
 
   def friend_notification(friend)
-    befriender = User.find_by_id(friend.user_id)
-    befriendee = User.find_by_id(friend.friend_user_id)
-
-    common_headers befriendee
-    subject "[OpenStreetMap] #{befriender.display_name} added you as a friend"
-    body :user => befriender.display_name,
-         :userurl => url_for(:host => SERVER_URL,
-                             :controller => "user", :action => "view",
-                             :display_name => befriender.display_name)
+    common_headers friend.befriendee
+    subject I18n.t('notifier.friend_notification.subject', :user => friend.befriender.display_name, :locale => locale)
+    body :friend => friend
   end
 
 private
@@ -109,8 +99,14 @@ private
   def common_headers(recipient)
     recipients recipient.email
     locale recipient.preferred_language_from(I18n.available_locales)
-    from "webmaster@openstreetmap.org"
-    headers "return-path" => "bounces@openstreetmap.org",
+    from EMAIL_FROM
+    headers "return-path" => EMAIL_RETURN_PATH,
             "Auto-Submitted" => "auto-generated"
   end
+
+  def from_header(name, type, id, digest)
+    if domain = APP_CONFIG['messages_domain']
+      from quote_address_if_necessary("#{name} <#{type}-#{id}-#{digest[0,6]}@#{domain}>", "utf-8")
+    end
+  end
 end