Refactor reportable_url to just return the url

[rails.git] / app / helpers / issues_helper.rb

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index b063935ea3c851649b066269de5408013d28c652..36837d228ced3e365b5188c1eb60210545691d2f 100644 (file)
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -1,25 +1,31 @@
 module IssuesHelper
+  def reportable_url(reportable)
+    case reportable
+    when DiaryEntry
+      url_for(:controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.user.display_name, :id => reportable.id)
+    when User
+      url_for(:controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.display_name)
+    when DiaryComment
+      url_for(:controller => reportable.diary_entry.class.name.underscore, :action => :view, :display_name => reportable.diary_entry.user.display_name, :id => reportable.diary_entry.id, :anchor => "comment#{reportable.id}")
+    when Changeset
+      url_for(:controller => :browse, :action => :changeset, :id => reportable.id)
+    when Note
+      url_for(:controller => :browse, :action => :note, :id => reportable.id)
+    end
+  end
 
-       def reportable_url(reportable)
-               class_name = reportable.class.name
-               case class_name
-               when "DiaryEntry"
-                       link_to reportable.title,       :controller => reportable.class.name.underscore,
-                                                                                                                               :action => :view,
-                                                                                                                               :display_name => reportable.user.display_name,
-                                                                                                                               :id => reportable.id
-               when "User"
-                       link_to reportable.display_name.to_s,   :controller => reportable.class.name.underscore,
-                                                                                                                                                               :action => "view",
-                                                                                                                                                               :display_name => reportable.display_name
-               when "DiaryComment"
-                       link_to "#{reportable.diary_entry.title}, Comment id ##{reportable.id}",        :controller => reportable.diary_entry.class.name.underscore,
-                                                                                                               :action => :view,
-                                                                                                               :display_name => reportable.diary_entry.user.display_name,
-                                                                                                               :id => reportable.id
-
-               else
-                       nil
-               end
-       end
+  def reportable_title(reportable)
+    case reportable
+    when DiaryEntry
+      reportable.title
+    when User
+      reportable.display_name
+    when DiaryComment
+      "#{reportable.diary_entry.title}, Comment id ##{reportable.id}"
+    when Changeset
+      "Changeset ##{reportable.id}"
+    when Note
+      "Note ##{reportable.id}"
+    end
+  end
 end