# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2015-08-18 20:27:49 +0100 using RuboCop version 0.33.0.
+# on 2017-10-05 10:04:24 +0100 using RuboCop version 0.50.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Layout/MultilineOperationIndentation:
+ Exclude:
+ - 'lib/bounding_box.rb'
+
# Offense count: 34
Lint/AmbiguousOperator:
Exclude:
- 'test/lib/bounding_box_test.rb'
- 'test/lib/country_test.rb'
-# Offense count: 115
+# Offense count: 124
Lint/AmbiguousRegexpLiteral:
Enabled: false
-# Offense count: 29
+# Offense count: 32
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Exclude:
- 'app/controllers/application_controller.rb'
- 'app/controllers/geocoder_controller.rb'
- 'app/controllers/notes_controller.rb'
- - 'app/controllers/trace_controller.rb'
+ - 'app/controllers/traces_controller.rb'
- 'app/controllers/user_controller.rb'
- - 'app/controllers/user_preference_controller.rb'
+ - 'app/controllers/user_preferences_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/browse_helper.rb'
- 'app/models/client_application.rb'
- 'lib/osm.rb'
- 'script/deliver-message'
-# Offense count: 3
-Lint/FormatParameterMismatch:
- Exclude:
- - 'app/controllers/swf_controller.rb'
-
-# Offense count: 5
+# Offense count: 4
Lint/HandleExceptions:
Exclude:
- 'app/controllers/amf_controller.rb'
- 'app/controllers/user_controller.rb'
- - 'config/initializers/session.rb'
-# Offense count: 8
-Lint/ParenthesesAsGroupedExpression:
+# Offense count: 3
+Lint/InterpolationCheck:
Exclude:
- - 'test/controllers/amf_controller_test.rb'
- - 'test/lib/bounding_box_test.rb'
- - 'test/models/user_preference_test.rb'
+ - 'test/controllers/node_controller_test.rb'
-# Offense count: 671
+# Offense count: 2
+Lint/ShadowingOuterLocalVariable:
+ Exclude:
+ - 'app/views/changeset/list.atom.builder'
+
+# Offense count: 666
Metrics/AbcSize:
- Max: 277
+ Max: 280
+
+# Offense count: 41
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+ Max: 257
# Offense count: 12
+# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 5
-# Offense count: 62
+# Offense count: 63
# Configuration parameters: CountComments.
Metrics/ClassLength:
- Max: 1653
+ Max: 1797
-# Offense count: 67
+# Offense count: 71
Metrics/CyclomaticComplexity:
Max: 20
-# Offense count: 2535
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 3004
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
Metrics/LineLength:
- Max: 878
+ Max: 1073
-# Offense count: 628
+# Offense count: 675
# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 179
-# Offense count: 1
+# Offense count: 2
# Configuration parameters: CountComments.
Metrics/ModuleLength:
- Max: 126
+ Max: 147
# Offense count: 4
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
Max: 9
-# Offense count: 69
+# Offense count: 71
Metrics/PerceivedComplexity:
Max: 23
+# Offense count: 5
+Naming/AccessorMethodName:
+ Exclude:
+ - 'app/controllers/application_controller.rb'
+ - 'app/helpers/title_helper.rb'
+ - 'app/models/old_way.rb'
+ - 'lib/osm.rb'
+ - 'lib/potlatch.rb'
+
+# Offense count: 8
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Naming/PredicateName:
+ Exclude:
+ - 'spec/**/*'
+ - 'app/models/changeset.rb'
+ - 'app/models/old_node.rb'
+ - 'app/models/old_relation.rb'
+ - 'app/models/old_way.rb'
+ - 'app/models/user.rb'
+ - 'lib/classic_pagination/pagination.rb'
+
# Offense count: 2
# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
+Rails/Exit:
+ Exclude:
+ - 'lib/**/*.rake'
+ - 'lib/daemons/gpx_import.rb'
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
Rails/HasAndBelongsToMany:
Exclude:
- 'app/models/changeset.rb'
- 'app/models/user.rb'
-# Offense count: 66
+# Offense count: 5
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/NotNullColumn:
+ Exclude:
+ - 'db/migrate/002_cleanup_osm_db.rb'
+ - 'db/migrate/020_populate_node_tags_and_remove.rb'
+ - 'db/migrate/021_move_to_innodb.rb'
+ - 'db/migrate/025_add_end_time_to_changesets.rb'
+ - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+
+# Offense count: 20
+Rails/OutputSafety:
+ Exclude:
+ - 'app/controllers/user_controller.rb'
+ - 'app/helpers/application_helper.rb'
+ - 'app/helpers/changeset_helper.rb'
+ - 'app/helpers/geocoder_helper.rb'
+ - 'app/helpers/note_helper.rb'
+ - 'app/helpers/open_graph_helper.rb'
+ - 'app/helpers/user_blocks_helper.rb'
+ - 'app/helpers/user_roles_helper.rb'
+ - 'lib/rich_text.rb'
+ - 'test/helpers/application_helper_test.rb'
+
+# Offense count: 86
# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: strict, flexible
Rails/TimeZone:
Enabled: false
-# Offense count: 5
-Style/AccessorMethodName:
- Exclude:
- - 'app/controllers/application_controller.rb'
- - 'app/helpers/title_helper.rb'
- - 'app/models/old_way.rb'
- - 'lib/osm.rb'
- - 'lib/potlatch.rb'
-
# Offense count: 1
Style/AsciiComments:
Exclude:
- 'test/models/message_test.rb'
-# Offense count: 310
+# Offense count: 219
Style/Documentation:
Enabled: false
-# Offense count: 38
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
Exclude:
- - 'app/controllers/application_controller.rb'
- - 'app/controllers/diary_entry_controller.rb'
- - 'app/controllers/message_controller.rb'
- - 'app/controllers/notes_controller.rb'
- - 'app/controllers/site_controller.rb'
- - 'app/controllers/user_blocks_controller.rb'
- - 'app/controllers/user_controller.rb'
- - 'app/controllers/user_roles_controller.rb'
- - 'app/helpers/application_helper.rb'
- - 'app/models/changeset.rb'
- - 'app/models/user.rb'
- - 'lib/diff_reader.rb'
- - 'lib/object_metadata.rb'
+ - 'app/controllers/way_controller.rb'
# Offense count: 60
# Cop supports --auto-correct.
- 'test/controllers/relation_controller_test.rb'
- 'test/controllers/way_controller_test.rb'
-# Offense count: 69
+# Offense count: 75
# Cop supports --auto-correct.
+# Configuration parameters: Strict.
Style/NumericLiterals:
MinDigits: 11
-# Offense count: 42
+# Offense count: 95
# Cop supports --auto-correct.
-Style/PerlBackrefs:
- Exclude:
- - 'app/controllers/amf_controller.rb'
- - 'app/controllers/application_controller.rb'
- - 'app/helpers/browse_helper.rb'
- - 'config/initializers/paperclip.rb'
- - 'lib/id.rb'
- - 'lib/potlatch.rb'
- - 'test/lib/i18n_test.rb'
-
-# Offense count: 8
-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
-Style/PredicateName:
- Exclude:
- - 'app/models/changeset.rb'
- - 'app/models/old_node.rb'
- - 'app/models/old_relation.rb'
- - 'app/models/old_way.rb'
- - 'app/models/user.rb'
- - 'lib/classic_pagination/pagination.rb'
-
-# Offense count: 97
# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, exploded
Style/RaiseArgs:
Enabled: false
# Offense count: 2
-Style/RescueModifier:
+Style/RescueStandardError:
Exclude:
- 'app/helpers/browse_helper.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiteralsInInterpolation:
- Enabled: false