Merge remote-tracking branch 'upstream/pull/4562'

[rails.git] / test / integration / page_locale_test.rb

diff --git a/test/integration/page_locale_test.rb b/test/integration/page_locale_test.rb
index 60255f66c3849f8bfb2d9c09f316bd05c8f2f6e1..6f6d7779fc3ab420cb5f5a670254c3f2c5b523cc 100644 (file)
--- a/test/integration/page_locale_test.rb
+++ b/test/integration/page_locale_test.rb
@@ -1,46 +1,45 @@
 require "test_helper"
 
 class PageLocaleTest < ActionDispatch::IntegrationTest
-  fixtures :users
-
-  def setup
-    I18n.locale = "en"
-    stub_request(:get, "http://api.hostip.info/country.php?ip=127.0.0.1")
-  end
-
-  def teardown
-    I18n.locale = "en"
-  end
-
   def test_defaulting
-    user = users(:second_public_user)
-
-    post_via_redirect "/login", :username => user.email, :password => "test"
-
-    get "/diary/new", {}
-    assert_equal [], User.find(user.id).languages
-    assert_select "html[lang=?]", "en"
-
-    get "/diary/new", {}, { "HTTP_ACCEPT_LANGUAGE" => "fr, en" }
-    assert_equal %w(fr en), User.find(user.id).languages
-    assert_select "html[lang=?]", "fr"
+    I18n.with_locale "en" do
+      user = create(:user, :languages => [])
+
+      get "/login"
+      follow_redirect!
+      post "/login", :params => { :username => user.email, :password => "test" }
+      follow_redirect!
+
+      get "/diary/new"
+      assert_empty User.find(user.id).languages
+      assert_select "html[lang=?]", "en"
+
+      get "/diary/new", :headers => { "HTTP_ACCEPT_LANGUAGE" => "fr, en" }
+      assert_equal %w[fr en], User.find(user.id).languages
+      assert_select "html[lang=?]", "fr"
+    end
   end
 
   def test_override
-    user = users(:german_user)
+    I18n.with_locale "en" do
+      user = create(:user, :languages => ["de"])
 
-    get "/diary"
-    assert_select "html[lang=?]", "en"
+      get "/diary"
+      assert_select "html[lang=?]", "en"
 
-    get "/diary", :locale => "es"
-    assert_select "html[lang=?]", "es"
+      get "/diary", :params => { :locale => "es" }
+      assert_select "html[lang=?]", "es"
 
-    post_via_redirect "/login", :username => user.email, :password => "test"
+      get "/login"
+      follow_redirect!
+      post "/login", :params => { :username => user.email, :password => "test" }
+      follow_redirect!
 
-    get "/diary"
-    assert_select "html[lang=?]", "de"
+      get "/diary"
+      assert_select "html[lang=?]", "de"
 
-    get "/diary", :locale => "fr"
-    assert_select "html[lang=?]", "fr"
+      get "/diary", :params => { :locale => "fr" }
+      assert_select "html[lang=?]", "fr"
+    end
   end
 end