Fix warnings from rubocop update

[rails.git] / app / models / note.rb

diff --git a/app/models/note.rb b/app/models/note.rb
index a2937074c4053d8b4eaaca9a051fb4b67508d0e4..31056be49ca090733b483a09ddeb1ac0f4ecb805 100644 (file)
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -1,75 +1,64 @@
 class Note < ActiveRecord::Base
   include GeoRecord
 
-  has_many :comments, :class_name => "NoteComment",
-                      :foreign_key => :note_id,
-                      :order => :created_at,
-                      :conditions => { :visible => true }
+  has_many :comments, -> { where(:visible => true).order(:created_at) }, :class_name => "NoteComment", :foreign_key => :note_id
+
+  validates :id, :uniqueness => true, :presence => { :on => :update },
+                 :numericality => { :on => :update, :integer_only => true }
+  validates :latitude, :longitude, :numericality => { :only_integer => true }
+  validates :closed_at, :presence => true, :if => proc { :status == "closed" }
+  validates :status, :inclusion => %w(open closed hidden)
 
-  validates_presence_of :id, :on => :update
-  validates_uniqueness_of :id
-  validates_numericality_of :latitude, :only_integer => true
-  validates_numericality_of :longitude, :only_integer => true
-  validates_presence_of :closed_at if :status == "closed"
-  validates_inclusion_of :status, :in => ["open", "closed", "hidden"]
   validate :validate_position
 
+  scope :visible, -> { where("status != 'hidden'") }
+  scope :invisible, -> { where("status = 'hidden'") }
+
+  after_initialize :set_defaults
+
   # Sanity check the latitude and longitude and add an error if it's broken
   def validate_position
-    errors.add_to_base("Note is not in the world") unless in_world?
-  end
-
-  # Fill in default values for new notes
-  def after_initialize
-    self.status = "open" unless self.attribute_present?(:status)
+    errors.add(:base, "Note is not in the world") unless in_world?
   end
 
   # Close a note
   def close
     self.status = "closed"
     self.closed_at = Time.now.getutc
-    self.save
+    save
   end
 
-  # Return a flattened version of the comments for a note
-  def flatten_comment(separator_char, upto_timestamp = :nil)
-    resp = ""
-    comment_no = 1
-    self.comments.each do |comment|
-      next if upto_timestamp != :nil and comment.created_at > upto_timestamp
-      resp += (comment_no == 1 ? "" : separator_char)
-      resp += comment.body if comment.body
-      resp += " [ " 
-      resp += comment.author_name if comment.author_name
-      resp += " " + comment.created_at.to_s + " ]"
-      comment_no += 1
-    end
-
-    return resp
+  # Reopen a note
+  def reopen
+    self.status = "open"
+    self.closed_at = nil
+    save
   end
 
   # Check if a note is visible
   def visible?
-    return status != "hidden"
+    status != "hidden"
+  end
+
+  # Check if a note is closed
+  def closed?
+    !closed_at.nil?
   end
 
   # Return the author object, derived from the first comment
   def author
-    self.comments.first.author
+    comments.first.author
   end
 
   # Return the author IP address, derived from the first comment
   def author_ip
-    self.comments.first.author_ip
+    comments.first.author_ip
   end
 
-  # Return the author id, derived from the first comment
-  def author_id
-    self.comments.first.author_id
-  end
+  private
 
-  # Return the author name, derived from the first comment
-  def author_name
-    self.comments.first.author_name
+  # Fill in default values for new notes
+  def set_defaults
+    self.status = "open" unless self.attribute_present?(:status)
   end
 end